Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Maps to add version preview/2020-02-01-preview #8359

Merged
merged 6 commits into from
Feb 17, 2020
Merged

[Hub Generated] Review request for Microsoft.Maps to add version preview/2020-02-01-preview #8359

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d140ad5
adding system data and description fixes
Feb 11, 2020
5a31044
adding specific readonly and desc
Feb 11, 2020
3cf3293
fixing types systemData
Feb 11, 2020
32a4420
remove sec def
Feb 11, 2020
e84e488
pretty
Feb 11, 2020
b09ba8a
trying to suppress
Feb 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion specification/common-types/resource-management/v1/types.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@
"modelAsString": true
}
},
"lastModifiedByAt": {
"lastModifiedAt": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix is because it doesn't match RPC. https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-contracts.md#system-metadata-for-all-azure-resources

"type": "string",
"format": "date-time",
"description": "The type of identity that last modified the resource."
Expand Down
8 changes: 8 additions & 0 deletions .../maps/resource-manager/Microsoft.Maps/preview/2020-02-01-preview/examples/GetAccount.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@
"name": "myMapsAccount",
"type": "Microsoft.Maps/accounts",
"location": "global",
"systemData": {
"createdBy": "string",
"createdByType": "Application",
"createdAt": "2020-02-01T01:01:01.1075056Z",
"lastModifiedBy":"string",
"lastModifiedByType":"Application",
"lastModifiedAt": "2020-02-01T01:01:01.1075056Z"
},
"tags": {
"test": "true"
},
Expand Down
5 changes: 5 additions & 0 deletions ...tion/maps/resource-manager/Microsoft.Maps/preview/2020-02-01-preview/maps-management.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,6 +724,11 @@
"description": "The SKU of this account.",
"$ref": "#/definitions/Sku"
},
"systemData": {
"readOnly": true,
"description": "The system meta data relating to this resource.",
"$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/systemData"
},
"properties": {
"readOnly": true,
"description": "The map account properties.",
Expand Down