[Hub Generated] Review request for Microsoft.Maps to add version preview/2020-02-01-preview #8359

stack111 · 2020-02-11T18:51:13Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

azure-pipelines · 2020-02-11T18:51:30Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-02-11T18:52:59Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from b09ba8a with merge commit 731f2f8. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-maps [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.rst'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.rst'

openapi-sdkautomation · 2020-02-11T18:53:03Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from b09ba8a with merge commit 731f2f8. SDK Automation 13.0.17.20191226.1
⚠️maps/mgmt/2017-01-01-preview [Logs]
```
No file is changed.
```
⚠️maps/mgmt/2018-05-01 [Logs]
```
No file is changed.
```
️✔️preview/maps/mgmt/2020-02-01-preview [Logs] [Release SDK Changes]
- preview.maps.mgmt.2020-02-01-preview.zip

openapi-sdkautomation · 2020-02-11T18:53:04Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from b09ba8a with merge commit 731f2f8. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Maps [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.Maps.1.0.2.nupkg
- Microsoft.Azure.Management.Maps.1.0.2.snupkg

openapi-sdkautomation · 2020-02-11T18:53:06Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-02-11T18:53:10Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from b09ba8a with merge commit 731f2f8. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-maps [Logs] [Release SDK Changes]

azure-arm-maps-1.1.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/mapsManagementClient.js → ./dist/arm-maps.js...
[npmPack] created ./dist/arm-maps.js in 235ms

stack111 · 2020-02-11T18:53:49Z

specification/common-types/resource-management/v1/types.json

@@ -392,7 +392,7 @@
            "modelAsString": true
          }
        },
-        "lastModifiedByAt": {
+        "lastModifiedAt": {


This fix is because it doesn't match RPC. https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-contracts.md#system-metadata-for-all-azure-resources

azure-pipelines · 2020-02-11T19:12:22Z

Azure Pipelines successfully started running 1 pipeline(s).

stack111 · 2020-02-11T19:52:48Z

I need feedback for the linter failures, I would expect that systemData to be added as a valid type to the linter, or if that's considered a breaking change -- should I supress.

majastrz

Signed off from ARM side.

stack111 · 2020-02-11T22:20:05Z

I need feedback for the linter failures, I would expect that systemData to be added as a valid type to the linter, or if that's considered a breaking change -- should I supress.

@NullMDR - I'll need your assistance here.

PhoenixHe-NV · 2020-02-12T03:38:08Z

@lirenhe @jianyexi For help on this LintDiff error

azure-pipelines · 2020-02-12T18:00:17Z

Azure Pipelines successfully started running 1 pipeline(s).

…iew/2020-02-01-preview (Azure#8359) * adding system data and description fixes * adding specific readonly and desc * fixing types systemData * remove sec def * pretty * trying to suppress

Daniel Stack added 4 commits February 11, 2020 09:49

adding system data and description fixes

d140ad5

adding specific readonly and desc

5a31044

fixing types systemData

3cf3293

remove sec def

32a4420

openapi-assignment-bot bot assigned PhoenixHe-NV Feb 11, 2020

stack111 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 11, 2020

stack111 commented Feb 11, 2020

View reviewed changes

pretty

e84e488

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 11, 2020

majastrz approved these changes Feb 11, 2020

View reviewed changes

trying to suppress

b09ba8a

PhoenixHe-NV merged commit 731f2f8 into Azure:master Feb 17, 2020

stack111 deleted the dev-maps-Microsoft.Maps-2020-02-01-preview branch February 18, 2020 04:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Maps to add version preview/2020-02-01-preview #8359

[Hub Generated] Review request for Microsoft.Maps to add version preview/2020-02-01-preview #8359

stack111 commented Feb 11, 2020

azure-pipelines bot commented Feb 11, 2020

openapi-sdkautomation bot commented Feb 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 11, 2020 •

edited

Loading

stack111 Feb 11, 2020

azure-pipelines bot commented Feb 11, 2020

stack111 commented Feb 11, 2020

majastrz left a comment

stack111 commented Feb 11, 2020

PhoenixHe-NV commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

[Hub Generated] Review request for Microsoft.Maps to add version preview/2020-02-01-preview #8359

[Hub Generated] Review request for Microsoft.Maps to add version preview/2020-02-01-preview #8359

Conversation

stack111 commented Feb 11, 2020

Contribution checklist:

azure-pipelines bot commented Feb 11, 2020

openapi-sdkautomation bot commented Feb 11, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Feb 11, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Feb 11, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Feb 11, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Feb 11, 2020 • edited Loading

azure-sdk-for-js - Release

stack111 Feb 11, 2020

Choose a reason for hiding this comment

azure-pipelines bot commented Feb 11, 2020

stack111 commented Feb 11, 2020

majastrz left a comment

Choose a reason for hiding this comment

stack111 commented Feb 11, 2020

PhoenixHe-NV commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

openapi-sdkautomation bot commented Feb 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 11, 2020 •

edited

Loading