Sfrp release 2019-11-01-preview #8745

a-santamaria · 2020-03-18T02:44:55Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-03-18T02:45:12Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-03-18T02:46:28Z

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azuresdkci · 2020-03-18T02:46:30Z

Can one of the admins verify this patch?

openapi-sdkautomation · 2020-03-18T02:46:34Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 6f793f1 with merge commit 7070ddd. SDK Automation 13.0.17.20200326.3
️✔️sdk/servicefabric/mgmt-v2016_09_01 [Logs] [Release SDK Changes]

⚠️sdk/servicefabric/mgmt-v2017_07_01_preview [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicefabric/mgmt-v2017_07_01_preview/src/main/java/com/microsoft/azure/management/servicefabric/v2017_07_01_preview/implementation/ClusterImpl.java:[40,22] no suitable method found for createAsync(java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner)
[mvn]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.createAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner,com.microsoft.rest.ServiceCallback) is not applicable
[mvn]       (actual and formal argument lists differ in length)
[mvn]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.createAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner) is not applicable
[mvn]       (actual and formal argument lists differ in length)
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicefabric/mgmt-v2017_07_01_preview/src/main/java/com/microsoft/azure/management/servicefabric/v2017_07_01_preview/implementation/ClusterImpl.java:[54,22] no suitable method found for updateAsync(java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters)
[mvn]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.updateAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters,com.microsoft.rest.ServiceCallback) is not applicable
[mvn]       (actual and formal argument lists differ in length)
[mvn]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.updateAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters) is not applicable
[mvn]       (actual and formal argument lists differ in length)
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-servicefabric: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicefabric/mgmt-v2017_07_01_preview/src/main/java/com/microsoft/azure/management/servicefabric/v2017_07_01_preview/implementation/ClusterImpl.java:[40,22] no suitable method found for createAsync(java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner)
[mvn] [ERROR]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.createAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner,com.microsoft.rest.ServiceCallback) is not applicable
[mvn] [ERROR]       (actual and formal argument lists differ in length)
[mvn] [ERROR]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.createAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner) is not applicable
[mvn] [ERROR]       (actual and formal argument lists differ in length)
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicefabric/mgmt-v2017_07_01_preview/src/main/java/com/microsoft/azure/management/servicefabric/v2017_07_01_preview/implementation/ClusterImpl.java:[54,22] no suitable method found for updateAsync(java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters)
[mvn] [ERROR]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.updateAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters,com.microsoft.rest.ServiceCallback) is not applicable
[mvn] [ERROR]       (actual and formal argument lists differ in length)
[mvn] [ERROR]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.updateAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters) is not applicable
[mvn] [ERROR]       (actual and formal argument lists differ in length)
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

️✔️sdk/servicefabric/mgmt-v2018_02_01 [Logs] [Release SDK Changes]

openapi-sdkautomation · 2020-03-18T02:46:36Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 6f793f1 with merge commit 7070ddd. SDK Automation 13.0.17.20200326.3
⚠️preview/servicefabric/mgmt/2017-07-01-preview [Logs]
```
No file is changed.
```
⚠️preview/servicefabric/mgmt/2019-03-01-preview [Logs]
```
No file is changed.
```
⚠️servicefabric/mgmt/2016-09-01 [Logs]
```
No file is changed.
```
⚠️servicefabric/mgmt/2018-02-01 [Logs]
```
No file is changed.
```
⚠️servicefabric/mgmt/2019-03-01 [Logs]
```
No file is changed.
```

openapi-sdkautomation · 2020-03-18T02:49:01Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 6f793f1 with merge commit 7070ddd. SDK Automation 13.0.17.20200326.3

️✔️azure-mgmt-servicefabric [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 4.402% size of original (original: 54813 chars, delta: 2413 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model DiagnosticsStorageAccountConfig has a new parameter protected_account_key_name2
[ChangeLog]   - Model ApplicationResourceUpdate has a new parameter managed_identities
[ChangeLog]   - Model ApplicationUpgradePolicy has a new parameter upgrade_mode
[ChangeLog]   - Model ApplicationResource has a new parameter identity
[ChangeLog]   - Model ApplicationResource has a new parameter managed_identities

openapi-sdkautomation · 2020-03-18T02:52:04Z

azure-sdk-for-net - Release

❌ failed [Logs] [Expand Details]

❌ Generate from 6f793f1 with merge commit 7070ddd. SDK Automation 13.0.17.20200326.3

SDK Repository Error: {}
Error: git fetch main error: RPC failed; curl 56 GnuTLS recv error (-54): Error in the pull function.
fatal: The remote end hung up unexpectedly
fatal: early EOF
fatal: index-pack failed
at Object.<anonymous> (/z/node_modules/@ts-common/azure-js-dev-tools/dist/lib/run.js:557:31)
at step (/z/node_modules/tslib/tslib.js:136:27)
at Object.next (/z/node_modules/tslib/tslib.js:117:57)
at fulfilled (/z/node_modules/tslib/tslib.js:107:62)
at processTicksAndRejections (internal/process/task_queues.js:97:5)</pre></li></ul></details>

openapi-sdkautomation · 2020-03-18T02:53:10Z

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-03-18T03:03:17Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-18T03:09:26Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-18T03:31:59Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-18T04:05:32Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-18T04:10:34Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-24T04:50:48Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-30T05:37:56Z

Azure Pipelines successfully started running 1 pipeline(s).

majastrz

Signed off from ARM side.

weidongxu-microsoft · 2020-03-31T01:17:42Z

@a-santamaria

All approved. Let me know when you want to merge.

a-santamaria · 2020-04-02T16:12:47Z

@weidongxu-microsoft thanks, please merge now.

* base commit to compare with 2019-06-01-preview * adding api version 2019-11-01-preview * add more to protectedAccountKeyName2 description Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>

a-santamaria requested a review from samedder as a code owner March 18, 2020 02:44

openapi-assignment-bot bot assigned weidongxu-microsoft Mar 18, 2020

openapi-sdkautomation bot mentioned this pull request Mar 18, 2020

[AutoPR azure-mgmt-servicefabric] Sfrp release 2019-11-01-preview AzureSDKAutomation/azure-sdk-for-python#628

Closed

weidongxu-microsoft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 18, 2020

weidongxu-microsoft approved these changes Mar 18, 2020

View reviewed changes

a-santamaria force-pushed the sfrp_release_2019-11-01-preview branch from 6cda818 to 5a0dbf2 Compare March 18, 2020 04:10

a-santamaria mentioned this pull request Mar 24, 2020

Sfrp release 2020-03-01 #8746

Merged

5 tasks

Alfredo Santamaria Gomez added 3 commits March 29, 2020 22:35

base commit to compare with 2019-06-01-preview

9d4148e

adding api version 2019-11-01-preview

37c802f

add more to protectedAccountKeyName2 description

6f793f1

a-santamaria force-pushed the sfrp_release_2019-11-01-preview branch from 07f39d4 to 6f793f1 Compare March 30, 2020 05:37

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 30, 2020

majastrz approved these changes Mar 30, 2020

View reviewed changes

weidongxu-microsoft merged commit 7070ddd into Azure:master Apr 3, 2020

a-santamaria mentioned this pull request Apr 4, 2020

Service fabric api version 2019-11-01-preview adding missing properties #8944

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sfrp release 2019-11-01-preview #8745

Sfrp release 2019-11-01-preview #8745

a-santamaria commented Mar 18, 2020 •

edited

Loading

azure-pipelines bot commented Mar 18, 2020

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

azuresdkci commented Mar 18, 2020

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 24, 2020

azure-pipelines bot commented Mar 30, 2020

majastrz left a comment

weidongxu-microsoft commented Mar 31, 2020

a-santamaria commented Apr 2, 2020

Sfrp release 2019-11-01-preview #8745

Sfrp release 2019-11-01-preview #8745

Conversation

a-santamaria commented Mar 18, 2020 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Mar 18, 2020

openapi-sdkautomation bot commented Mar 18, 2020 • edited Loading

azure-cli-extensions - Release

azuresdkci commented Mar 18, 2020

openapi-sdkautomation bot commented Mar 18, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Mar 18, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Mar 18, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Mar 18, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Mar 18, 2020 • edited Loading

azure-sdk-for-js - Release

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 24, 2020

azure-pipelines bot commented Mar 30, 2020

majastrz left a comment

Choose a reason for hiding this comment

weidongxu-microsoft commented Mar 31, 2020

a-santamaria commented Apr 2, 2020

a-santamaria commented Mar 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading