Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service fabric api version 2019-11-01-preview adding missing properties #8944

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Service fabric api version 2019-11-01-preview adding missing properties #8944

merged 1 commit into from
Apr 10, 2020

Conversation

a-santamaria
Copy link
Member

@a-santamaria a-santamaria commented Apr 4, 2020 •
edited
Loading

we recently added this version in this pr #8745 but missed the following properties:

  • serviceDnsName to service,
  • instanceCloseDelayDuration to stateless serivce,
  • applicationTypeVersionsCleanupPolicy to cluster

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

adding serviceDnsName to service, instanceCloseDelayDuration to state…
43767e3 
…less service and ApplicationTypeVersionsCleanupPolicy to cluster
@a-santamaria a-santamaria requested a review from samedder as a code owner April 4, 2020 00:18
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 4, 2020 •
edited
Loading

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 4, 2020 •
edited
Loading

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 4, 2020 •
edited
Loading

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 43767e3 with merge commit 6e7c6b9. SDK Automation 13.0.17.20200326.3
  • ️✔️sdk/servicefabric/mgmt-v2016_09_01 [Logs]  [Release SDK Changes]
  • ⚠️sdk/servicefabric/mgmt-v2017_07_01_preview [Logs]  [Release SDK Changes] 
      [mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicefabric/mgmt-v2017_07_01_preview/src/main/java/com/microsoft/azure/management/servicefabric/v2017_07_01_preview/implementation/ClusterImpl.java:[40,22] no suitable method found for createAsync(java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner)
[mvn]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.createAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner,com.microsoft.rest.ServiceCallback) is not applicable
[mvn]       (actual and formal argument lists differ in length)
[mvn]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.createAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner) is not applicable
[mvn]       (actual and formal argument lists differ in length)
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicefabric/mgmt-v2017_07_01_preview/src/main/java/com/microsoft/azure/management/servicefabric/v2017_07_01_preview/implementation/ClusterImpl.java:[54,22] no suitable method found for updateAsync(java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters)
[mvn]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.updateAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters,com.microsoft.rest.ServiceCallback) is not applicable
[mvn]       (actual and formal argument lists differ in length)
[mvn]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.updateAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters) is not applicable
[mvn]       (actual and formal argument lists differ in length)
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-servicefabric: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicefabric/mgmt-v2017_07_01_preview/src/main/java/com/microsoft/azure/management/servicefabric/v2017_07_01_preview/implementation/ClusterImpl.java:[40,22] no suitable method found for createAsync(java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner)
[mvn] [ERROR]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.createAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner,com.microsoft.rest.ServiceCallback) is not applicable
[mvn] [ERROR]       (actual and formal argument lists differ in length)
[mvn] [ERROR]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.createAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner) is not applicable
[mvn] [ERROR]       (actual and formal argument lists differ in length)
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicefabric/mgmt-v2017_07_01_preview/src/main/java/com/microsoft/azure/management/servicefabric/v2017_07_01_preview/implementation/ClusterImpl.java:[54,22] no suitable method found for updateAsync(java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters)
[mvn] [ERROR]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.updateAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters,com.microsoft.rest.ServiceCallback) is not applicable
[mvn] [ERROR]       (actual and formal argument lists differ in length)
[mvn] [ERROR]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.updateAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters) is not applicable
[mvn] [ERROR]       (actual and formal argument lists differ in length)
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
    • ️✔️sdk/servicefabric/mgmt-v2018_02_01 [Logs]  [Release SDK Changes]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Apr 4, 2020 •
    edited
    Loading

    azure-sdk-for-go - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 43767e3 with merge commit 6e7c6b9. SDK Automation 13.0.17.20200326.3
    • ⚠️preview/servicefabric/mgmt/2017-07-01-preview [Logs]  
        No file is changed.
      • ⚠️preview/servicefabric/mgmt/2019-03-01-preview [Logs]  
          No file is changed.
        • ⚠️servicefabric/mgmt/2016-09-01 [Logs]  
            No file is changed.
          • ⚠️servicefabric/mgmt/2018-02-01 [Logs]  
              No file is changed.
            • ⚠️servicefabric/mgmt/2019-03-01 [Logs]  
                No file is changed.

              @openapi-sdkautomation
              Copy link

              openapi-sdkautomation bot commented Apr 4, 2020 •
              edited
              Loading

              azure-sdk-for-python - Release

              ️✔️ succeeded [Logs] [Expand Details]
              • ️✔️ Generate from 43767e3 with merge commit 6e7c6b9. SDK Automation 13.0.17.20200326.3
              • ️✔️azure-mgmt-servicefabric [Logs]  [Release SDK Changes] 
                [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 4.402% size of original (original: 54813 chars, delta: 2413 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model ApplicationResourceUpdate has a new parameter managed_identities
[ChangeLog]   - Model DiagnosticsStorageAccountConfig has a new parameter protected_account_key_name2
[ChangeLog]   - Model ApplicationUpgradePolicy has a new parameter upgrade_mode
[ChangeLog]   - Model ApplicationResource has a new parameter managed_identities
[ChangeLog]   - Model ApplicationResource has a new parameter identity

              @openapi-sdkautomation
              Copy link

              openapi-sdkautomation bot commented Apr 4, 2020 •
              edited
              Loading

              azure-sdk-for-net - Release

              ️✔️ succeeded [Logs] [Expand Details]

              This was referenced Apr 4, 2020
              Closed
              Closed
              Closed
              Closed
              Closed
              @azuresdkci
              Copy link
              Contributor

              Can one of the admins verify this patch?

              @a-santamaria a-santamaria added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 6, 2020
              KrisBash
              KrisBash approved these changes Apr 6, 2020
              View reviewed changes
              Copy link
              Contributor

              @KrisBash KrisBash left a comment

              Choose a reason for hiding this comment

              The reason will be displayed to describe this comment to others. Learn more.

              LGTM

              @KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 6, 2020
              @a-santamaria
              Copy link
              Member Author

              @zikalino can you merge the pr, please?

              @akning-ms akning-ms merged commit 6e7c6b9 into Azure:master Apr 10, 2020
              00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
              @a-santamaria @00Kai0
              adding serviceDnsName to service, instanceCloseDelayDuration to state…
              77651ca 
              …less service and ApplicationTypeVersionsCleanupPolicy to cluster (Azure#8944)

Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>
              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
              Reviewers

              @zikalino zikalino zikalino approved these changes

              @KrisBash KrisBash KrisBash approved these changes

              @samedder samedder Awaiting requested review from samedder samedder is a code owner

              Assignees

              @zikalino zikalino

              Labels
              ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
              Projects
              None yet
              Milestone
              No milestone
              Development

              Successfully merging this pull request may close these issues.
              5 participants
              @a-santamaria @azuresdkci @KrisBash @zikalino @akning-ms