Refinement: added x-ms-enum for tags patch operation #9828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…userAssignedIdentities.
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-python-track2 - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Jun 12, 2020
raych1
reviewed
Jun 12, 2020
| ], | ||
| "x-ms-enum": { | ||
| "name": "operation", | ||
| "modelAsString": false, |
There was a problem hiding this comment.
How about set to true for adding new value in the future?
There was a problem hiding this comment.
Sure, @raych1 could you please shed a bit more light on this 'modelAsString'? What is this for and what is the difference for setting it true or false? I can change it to 'true' in my pr if needed. I just did something similar to the property PropertyChangeType.
There was a problem hiding this comment.
It enable to add more values for enum type in the future when set modelAsString as true. It won't be breaking change. Pls refer x-ms-enum for details.
There was a problem hiding this comment.
Hello @raych1, thanks for the explanation. I have set it to true. Since @ravbhatnagar mentioned that ARM review board would not be reviewing property-level changes going forward. Could you please have another look and merge it?
openapi-assignment-bot
bot
added
the
WaitForARMFeedback
|
Can one of the admins verify this patch? |
2 tasks
ravbhatnagar
removed
the
WaitForARMFeedback
|
Removing ARM Feedback label since ARM review board will not be reviewing property level changes going forward. |
|
@Grayer123 , could you resolve the comments? |
|
@Grayer123 , are you still working on this PR? |
raych1
added
the
Reviewed-ChangesRequested
openapi-assignment-bot
bot
added
the
WaitForARMFeedback
|
No commit pushedDate could be found for PR 9828 in repo Azure/azure-rest-api-specs |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hamidtirmizi
approved these changes
Jul 17, 2020
hamidtirmizi
added
ARMSignedOff
|
Hello @raych1, there is an automation - sdk test failure? Not sure if my change could cause that, could you please help us take a look? Thanks. |
raych1
approved these changes
Jul 17, 2020
2 tasks
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* Bug fixes: skip url encoding for ScopeParameter; add client name for userAssignedIdentities. * Pretty check fix. * Move added client name into additionalProperties of userAssignedIdentities. * Added x-ms-enum property for tag patch operation. * Set modelAsString to true for TagsPatch Enum operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
As suggested in a cli pr for tags cmdlet, we did the following refinement:
Added "x-ms-enum" for tags patch operation:
Updated in mgmt:2019-10-01 and mgmt:2020-06-01.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.