Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate TaskRun to ProxyResource. #9953

Merged
merged 3 commits into from
Jul 28, 2020
Merged

Migrate TaskRun to ProxyResource. #9953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26b9d06
Migrate TaskRun to ProxyResource.
huanwu Jun 24, 2020
4e15e3d
Remove location and tags in TaskRunGetDetails
huanwu Jun 24, 2020
1191d68
Add Location back. Add TaskRunNameParameter to restrict the name.
huanwu Jul 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 25 additions & 26 deletions ...nager/Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,11 +721,7 @@
"$ref": "#/parameters/ApiVersionParameter"
},
{
"name": "taskRunName",
"in": "path",
"description": "The run request name.",
"required": true,
"type": "string"
"$ref": "#/parameters/TaskRunNameParameter"
}
],
"responses": {
Expand Down Expand Up @@ -768,11 +764,7 @@
"$ref": "#/parameters/ApiVersionParameter"
},
{
"name": "taskRunName",
"in": "path",
"description": "The name of task run.",
"required": true,
"type": "string"
"$ref": "#/parameters/TaskRunNameParameter"
},
{
"name": "taskRun",
Expand Down Expand Up @@ -831,11 +823,7 @@
"$ref": "#/parameters/ApiVersionParameter"
},
{
"name": "taskRunName",
"in": "path",
"description": "The task run name.",
"required": true,
"type": "string"
"$ref": "#/parameters/TaskRunNameParameter"
}
],
"responses": {
Expand Down Expand Up @@ -882,11 +870,7 @@
"$ref": "#/parameters/ApiVersionParameter"
},
{
"name": "taskRunName",
"in": "path",
"description": "The task run name.",
"required": true,
"type": "string"
"$ref": "#/parameters/TaskRunNameParameter"
},
{
"name": "updateParameters",
Expand Down Expand Up @@ -947,11 +931,7 @@
"$ref": "#/parameters/ApiVersionParameter"
},
{
"name": "taskRunName",
"in": "path",
"description": "The run request name.",
"required": true,
"type": "string"
"$ref": "#/parameters/TaskRunNameParameter"
}
],
"responses": {
Expand Down Expand Up @@ -1916,7 +1896,7 @@
"type": "object",
"allOf": [
{
"$ref": "#/definitions/Resource"
"$ref": "#/definitions/ProxyResource"
}
],
"properties": {
Expand All @@ -1928,6 +1908,10 @@
"$ref": "#/definitions/TaskRunProperties",
"description": "The properties associated with the task run, i.e., request and result of the run",
"x-ms-client-flatten": true
},
"location": {
"description": "The location of the resource",
"type": "string"
}
}
},
Expand Down Expand Up @@ -2028,6 +2012,10 @@
"description": "The properties for updating a task run.",
"x-ms-client-flatten": true
},
"location": {
"description": "The location of the resource",
"type": "string"
},
"tags": {
"description": "The ARM resource tags.",
"type": "object",
Expand Down Expand Up @@ -3602,6 +3590,17 @@
"minLength": 3,
"pattern": "^[a-zA-Z0-9-]*$",
"x-ms-parameter-location": "method"
},
"TaskRunNameParameter": {
"name": "taskRunName",
"in": "path",
"description": "The name of the task run.",
"required": true,
"type": "string",
"maxLength": 50,
"minLength": 5,
"pattern": "^[a-zA-Z0-9-]*$",
"x-ms-parameter-location": "method"
}
},
"securityDefinitions": {
Expand Down
16 changes: 2 additions & 14 deletions ...nager/Microsoft.ContainerRegistry/preview/2019-06-01-preview/examples/TaskRunsCreate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@
"api-version": "2019-06-01-preview",
"taskRunName": "myRun",
"taskRun": {
"location": "westus",
"tags": {
"key": "value"
},
"properties": {
"forceUpdateTag": "test",
"runRequest": {
Expand Down Expand Up @@ -67,11 +63,7 @@
}
},
"id": "/subscriptions/4385cf00-2d3a-425a-832f-f4285b1c9dce/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/taskRuns/myRun",
"name": "myrun",
"tags": {
"key": "value"
},
"location": "WESTUS"
"name": "myrun"
}
},
"201": {
Expand Down Expand Up @@ -114,11 +106,7 @@
}
},
"id": "/subscriptions/4385cf00-2d3a-425a-832f-f4285b1c9dce/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/taskRuns/myRun",
"name": "myrun",
"tags": {
"key": "value"
},
"location": "WESTUS"
"name": "myrun"
}
}
}
Expand Down
6 changes: 1 addition & 5 deletions ...-manager/Microsoft.ContainerRegistry/preview/2019-06-01-preview/examples/TaskRunsGet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,7 @@
}
},
"id": "/subscriptions/3647315e-0c5b-4ce4-8739-b071e144b2c9/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/taskRuns/myRun",
"name": "myRun",
"tags": {
"key": "value"
},
"location": "WESTUS"
"name": "myRun"
}
}
}
Expand Down
6 changes: 1 addition & 5 deletions ...r/Microsoft.ContainerRegistry/preview/2019-06-01-preview/examples/TaskRunsGetDetails.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,7 @@
}
},
"id": "/subscriptions/3647315e-0c5b-4ce4-8739-b071e144b2c9/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/taskRuns/myRun",
"name": "myRun",
"tags": {
"key": "value"
},
"location": "WESTUS"
"name": "myRun"
}
}
}
Expand Down
6 changes: 1 addition & 5 deletions ...manager/Microsoft.ContainerRegistry/preview/2019-06-01-preview/examples/TaskRunsList.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,7 @@
}
},
"id": "/subscriptions/4385cf00-2d3a-425a-832f-f4285b1c9dce/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/taskRuns/myRun",
"name": "mytestrun",
"tags": {
"key": "value"
},
"location": "WESTUS"
"name": "mytestrun"
}
]
}
Expand Down
12 changes: 2 additions & 10 deletions ...nager/Microsoft.ContainerRegistry/preview/2019-06-01-preview/examples/TaskRunsUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,7 @@
}
},
"id": "/subscriptions/4385cf00-2d3a-425a-832f-f4285b1c9dce/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/taskRuns/myRun",
"name": "mytestrun",
"tags": {
"key": "value"
},
"location": "WESTUS"
"name": "mytestrun"
}
},
"201": {
Expand Down Expand Up @@ -111,11 +107,7 @@
}
},
"id": "/subscriptions/4385cf00-2d3a-425a-832f-f4285b1c9dce/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/taskRuns/myRun",
"name": "mytestrun",
"tags": {
"key": "value"
},
"location": "WESTUS"
"name": "mytestrun"
}
}
}
Expand Down