Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate TaskRun to ProxyResource. #9953

Merged
merged 3 commits into from
Jul 28, 2020

Conversation

huanwu
Copy link
Contributor

@huanwu huanwu commented Jun 24, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@huanwu huanwu requested a review from northtyphoon June 24, 2020 18:54
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 24, 2020

[Staging] Swagger Validation Report

BreakingChange: 21 Errors, 0 Warnings [Detail] [Expand] Only 10 items are listed, please refer to log for more details.
Rule Message
1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json#L1894:5
Old: Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json#L1914:5
1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json#L940:13
Old: Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json#L960:13
1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json#L788:13
Old: Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json#L796:13
1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json#L888:13
Old: Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json#L904:13
1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json#L894:13
Old: Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json#L910:13
1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json#L730:13
Old: Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json#L734:13
1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json#L2049:11
Old: Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json#L2061:11
1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json#L774:13
Old: Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json#L782:13
1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json#L782:13
Old: Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json#L790:13
1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
New: Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json#L920:9
Old: Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json#L949:11
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 24, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 24, 2020

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 24, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 24, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 24, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 1191d68 with merge commit c31ecb3. SDK Automation 13.0.17.20200619.4
  • ️✔️@azure/arm-containerregistry [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/containerRegistryManagementClient.js → ./dist/arm-containerregistry.js...
    [npmPack] created ./dist/arm-containerregistry.js in 650ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/arm-containerregistry@8.0.0
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 12.3kB  esm/operations/agentPools.js                         
    [npmPack] npm notice 1.9kB   esm/models/agentPoolsMappers.js                      
    [npmPack] npm notice 409.5kB dist/arm-containerregistry.js                        
    [npmPack] npm notice 143.8kB dist/arm-containerregistry.min.js                    
    [npmPack] npm notice 2.5kB   esm/containerRegistryManagementClient.js             
    [npmPack] npm notice 2.6kB   esm/containerRegistryManagementClientContext.js      
    [npmPack] npm notice 9.0kB   esm/operations/exportPipelines.js                    
    [npmPack] npm notice 1.8kB   esm/models/exportPipelinesMappers.js                 
    [npmPack] npm notice 9.0kB   esm/operations/importPipelines.js                    
    [npmPack] npm notice 1.8kB   esm/models/importPipelinesMappers.js                 
    [npmPack] npm notice 345B    esm/models/index.js                                  
    [npmPack] npm notice 781B    esm/operations/index.js                              
    [npmPack] npm notice 145.9kB esm/models/mappers.js                                
    [npmPack] npm notice 2.3kB   esm/operations/operations.js                         
    [npmPack] npm notice 572B    esm/models/operationsMappers.js                      
    [npmPack] npm notice 6.6kB   esm/models/parameters.js                             
    [npmPack] npm notice 8.8kB   esm/operations/pipelineRuns.js                       
    [npmPack] npm notice 1.8kB   esm/models/pipelineRunsMappers.js                    
    [npmPack] npm notice 9.7kB   esm/operations/privateEndpointConnections.js         
    [npmPack] npm notice 1.9kB   esm/models/privateEndpointConnectionsMappers.js      
    [npmPack] npm notice 26.3kB  esm/operations/registries.js                         
    [npmPack] npm notice 2.3kB   esm/models/registriesMappers.js                      
    [npmPack] npm notice 11.4kB  esm/operations/replications.js                       
    [npmPack] npm notice 1.9kB   esm/models/replicationsMappers.js                    
    [npmPack] npm notice 1.0kB   rollup.config.js                                     
    [npmPack] npm notice 9.1kB   esm/operations/runs.js                               
    [npmPack] npm notice 1.9kB   esm/models/runsMappers.js                            
    [npmPack] npm notice 11.2kB  esm/operations/scopeMaps.js                          
    [npmPack] npm notice 1.8kB   esm/models/scopeMapsMappers.js                       
    [npmPack] npm notice 12.1kB  esm/operations/taskRuns.js                           
    [npmPack] npm notice 1.9kB   esm/models/taskRunsMappers.js                        
    [npmPack] npm notice 12.0kB  esm/operations/tasks.js                              
    [npmPack] npm notice 2.2kB   esm/models/tasksMappers.js                           
    [npmPack] npm notice 10.9kB  esm/operations/tokens.js                             
    [npmPack] npm notice 1.8kB   esm/models/tokensMappers.js                          
    [npmPack] npm notice 15.1kB  esm/operations/webhooks.js                           
    [npmPack] npm notice 2.0kB   esm/models/webhooksMappers.js                        
    [npmPack] npm notice 1.8kB   package.json                                         
    [npmPack] npm notice 457B    tsconfig.json                                        
    [npmPack] npm notice 3.3kB   esm/operations/agentPools.d.ts.map                   
    [npmPack] npm notice 5.9kB   esm/operations/agentPools.js.map                     
    [npmPack] npm notice 1.1kB   esm/models/agentPoolsMappers.d.ts.map                
    [npmPack] npm notice 1.1kB   esm/models/agentPoolsMappers.js.map                  
    [npmPack] npm notice 723.7kB dist/arm-containerregistry.js.map                    
    [npmPack] npm notice 104.3kB dist/arm-containerregistry.min.js.map                
    [npmPack] npm notice 1.1kB   esm/containerRegistryManagementClient.d.ts.map       
    [npmPack] npm notice 1.6kB   esm/containerRegistryManagementClient.js.map         
    [npmPack] npm notice 501B    esm/containerRegistryManagementClientContext.d.ts.map
    [npmPack] npm notice 1.4kB   esm/containerRegistryManagementClientContext.js.map  
    [npmPack] npm notice 2.4kB   esm/operations/exportPipelines.d.ts.map              
    [npmPack] npm notice 4.2kB   esm/operations/exportPipelines.js.map                
    [npmPack] npm notice 1.1kB   esm/models/exportPipelinesMappers.d.ts.map           
    [npmPack] npm notice 1.1kB   esm/models/exportPipelinesMappers.js.map             
    [npmPack] npm notice 2.4kB   esm/operations/importPipelines.d.ts.map              
    [npmPack] npm notice 4.2kB   esm/operations/importPipelines.js.map                
    [npmPack] npm notice 1.1kB   esm/models/importPipelinesMappers.d.ts.map           
    [npmPack] npm notice 1.1kB   esm/models/importPipelinesMappers.js.map             
    [npmPack] npm notice 53.3kB  esm/models/index.d.ts.map                            
    [npmPack] npm notice 420B    esm/operations/index.d.ts.map                        
    [npmPack] npm notice 126B    esm/models/index.js.map                              
    [npmPack] npm notice 435B    esm/operations/index.js.map                          
    [npmPack] npm notice 7.3kB   esm/models/mappers.d.ts.map                          
    [npmPack] npm notice 81.8kB  esm/models/mappers.js.map                            
    [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map                   
    [npmPack] npm notice 1.4kB   esm/operations/operations.js.map                     
    [npmPack] npm notice 254B    esm/models/operationsMappers.d.ts.map                
    [npmPack] npm notice 267B    esm/models/operationsMappers.js.map                  
    [npmPack] npm notice 1.2kB   esm/models/parameters.d.ts.map                       
    [npmPack] npm notice 4.9kB   esm/models/parameters.js.map                         
    [npmPack] npm notice 2.4kB   esm/operations/pipelineRuns.d.ts.map                 
    [npmPack] npm notice 4.2kB   esm/operations/pipelineRuns.js.map                   
    [npmPack] npm notice 1.1kB   esm/models/pipelineRunsMappers.d.ts.map              
    [npmPack] npm notice 1.1kB   esm/models/pipelineRunsMappers.js.map                
    [npmPack] npm notice 2.5kB   esm/operations/privateEndpointConnections.d.ts.map   
    [npmPack] npm notice 4.2kB   esm/operations/privateEndpointConnections.js.map     
    [npmPack] npm notice 1.1kB   esm/models/privateEndpointConnectionsMappers.d.ts.map
    [npmPack] npm notice 1.1kB   esm/models/privateEndpointConnectionsMappers.js.map  
    [npmPack] npm notice 7.4kB   esm/operations/registries.d.ts.map                   
    [npmPack] npm notice 13.1kB  esm/operations/registries.js.map                     
    [npmPack] npm notice 1.3kB   esm/models/registriesMappers.d.ts.map                
    [npmPack] npm notice 1.3kB   esm/models/registriesMappers.js.map                  
    [npmPack] npm notice 2.8kB   esm/operations/replications.d.ts.map                 
    [npmPack] npm notice 5.3kB   esm/operations/replications.js.map                   
    [npmPack] npm notice 1.1kB   esm/models/replicationsMappers.d.ts.map              
    [npmPack] npm notice 1.1kB   esm/models/replicationsMappers.js.map                
    [npmPack] npm notice 2.9kB   esm/operations/runs.d.ts.map                         
    [npmPack] npm notice 4.8kB   esm/operations/runs.js.map                           

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 24, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 24, 2020

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 1191d68 with merge commit c31ecb3. SDK Automation 13.0.17.20200619.4
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2018-02-01-preview'} in label v2018_02_01_preview
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2018-02-01-preview based on label v2018_02_01_preview
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2018-09-01'} in label v2018_09_01
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2018-09-01 based on label v2018_09_01
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2019-04-01'} in label v2019_04_01
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2019-04-01 based on label v2019_04_01
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2019-05-01', '2019-04-01'} in label v2019_05_01
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01 based on label v2019_05_01
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2019-05-01-preview'} in label v2019_05_01_preview
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01-preview based on label v2019_05_01_preview
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2019-05-01', '2019-06-01-preview', '2019-05-01-preview'} in label v2019_06_01_preview
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2019-06-01-preview based on label v2019_06_01_preview
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2019-06-01-preview', '2019-12-01-preview', '2019-05-01-preview'} in label v2019_12_01_preview
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2019-12-01-preview based on label v2019_12_01_preview
  • ⚠️azure-mgmt-containerregistry [View full logs]  [Release SDK Changes] Breaking Change Detected
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-containerregistry
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-containerregistry
    [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2018-02-01-preview'} in label v2018_02_01_preview
    [after_scripts|python] WARNING:__main__:Guessing you want 2018-02-01-preview based on label v2018_02_01_preview
    [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2018-09-01'} in label v2018_09_01
    [after_scripts|python] WARNING:__main__:Guessing you want 2018-09-01 based on label v2018_09_01
    [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2019-04-01'} in label v2019_04_01
    [after_scripts|python] WARNING:__main__:Guessing you want 2019-04-01 based on label v2019_04_01
    [after_scripts|python] WARNING:__main__:Found too much API version: {'2019-05-01', '2019-04-01'} in label v2019_05_01
    [after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01 based on label v2019_05_01
    [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2019-05-01-preview'} in label v2019_05_01_preview
    [after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01-preview based on label v2019_05_01_preview
    [after_scripts|python] WARNING:__main__:Found too much API version: {'2019-05-01', '2019-06-01-preview', '2019-05-01-preview'} in label v2019_06_01_preview
    [after_scripts|python] WARNING:__main__:Guessing you want 2019-06-01-preview based on label v2019_06_01_preview
    [after_scripts|python] WARNING:__main__:Found too much API version: {'2019-06-01-preview', '2019-12-01-preview', '2019-05-01-preview'} in label v2019_12_01_preview
    [after_scripts|python] WARNING:__main__:Guessing you want 2019-12-01-preview based on label v2019_12_01_preview
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 0.483% size of original (original: 120631 chars, delta: 583 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model ImportPipeline has a new parameter location
    [ChangeLog]   - Model TaskRunUpdateParameters has a new parameter location
    [ChangeLog]   - Model ExportPipeline has a new parameter location
    [ChangeLog] 
    [ChangeLog] **Breaking changes**
    [ChangeLog] 
    [ChangeLog]   - Model TaskRun no longer has parameter tags

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 24, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@huanwu
Copy link
Contributor Author

huanwu commented Jun 24, 2020

@fengzhou-msft This is to update the swagger because we migrated the taskrun to proxyresource. Could you clarify if it is a breaking change? cc: @northtyphoon

@fengzhou-msft
Copy link
Member

Yes. The following breaking change is detected in Python SDK:

[ChangeLog] - Model TaskRun no longer has parameter tags
[ChangeLog] - Model TaskRun no longer has parameter location

@fengzhou-msft fengzhou-msft added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 25, 2020
@northtyphoon
Copy link
Member

OK. We found we need to keep location for TaskRun as it supports managed identity. /cc: @huanwu

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@huanwu
Copy link
Contributor Author

huanwu commented Jul 7, 2020

OK. We found we need to keep location for TaskRun as it supports managed identity. /cc: @huanwu

@northtyphoon Resolved. Could you take another look?

Copy link
Member

@northtyphoon northtyphoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengzhou-msft fengzhou-msft added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jul 28, 2020
@fengzhou-msft fengzhou-msft merged commit c31ecb3 into Azure:master Jul 28, 2020
iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Oct 5, 2020
…into fix_kv_python_readme

* 'master' of https://github.com/Azure/azure-rest-api-specs: (154 commits)
  Key Vault 7.1-preview to stable (GA) (Azure#10239)
  Fix data plane cosmosdb (Azure#10277)
  Fix example request for expanding policyEvaluationDetails (Azure#10203)
  Databricks Swagger Changes for Double Encryption (Azure#9941)
  add column delimiter for SAP Table/open hub (Azure#10269)
  add doc for typescript md (Azure#10187)
  Fix sfrp 2020-01-01-preview (Azure#10268)
  [Datafactory]Add cloudType and snapshot to ADF public swagger (Azure#10235)
  Migrate TaskRun to ProxyResource. (Azure#9953)
  [Datashare]Add sorting query parameters (Azure#10209)
  [Hub Generated] Review request for Microsoft.Insights to add version preview/2018-06-17-preview (Azure#10173)
  Update dataController onPremise property (Azure#10263)
  Changed the Client description to include Gen2 (Azure#10178)
  Managed Clusters Generate SDK (Azure#10247)
  Dev monitor microsoft.insights 2020 05 01 preview (Azure#10101)
  Add Location property to ExportPipeline and ImportPipeline (Azure#10177)
  Add enableAutomaticUpgrade property to VMExtensions for VMs and VMSS (Azure#10134)
  Add a new api and add 2020-02-02-preview versions (Azure#9710)
  Adding AML Workspace ID Property (Azure#10073)
  Add missing nullable attributes (Azure#10245)
  ...
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants