Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azservicebus] Report proper status codes and errors from our http ATOM layer #15801

Closed
richardpark-msft opened this issue Oct 15, 2021 · 1 comment
Closed

[azservicebus] Report proper status codes and errors from our http ATOM layer #15801

richardpark-msft opened this issue Oct 15, 2021 · 1 comment
Assignees
@richardpark-msft
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Milestone
[2021] November

Comments

@richardpark-msft
Copy link
Member

Basically, we'll have the same bug that the old code had here: Azure/azure-service-bus-go#258

We just need to check and return, based on the http response.
@richardpark-msft richardpark-msft added Service Bus Client This issue points to a problem in the data-plane of the library. labels Oct 15, 2021
@richardpark-msft richardpark-msft added this to the [2021] November milestone Oct 15, 2021
@richardpark-msft richardpark-msft self-assigned this Oct 15, 2021
richardpark-msft added a commit that referenced this issue Nov 4, 2021
@richardpark-msft
[azservicebus] AdminClient can now create topics and subscriptions (#…
14e0cee 
…16044)

Adding in ability to create/update/delete Topics and Subscriptions.
- Adding in proper request/response objects, as specified by guidelines.
- Adding in tests for handling low privilege failures
- (internal) Removing old _manager structs, in favor of the new AdminClient.

Fixes #15090, #15801
@richardpark-msft
Copy link
Member Author

Fixed (generically) as part of #16044

jhendrixMSFT pushed a commit to jhendrixMSFT/azure-sdk-for-go that referenced this issue Jan 12, 2022
@richardpark-msft @jhendrixMSFT
[azservicebus] AdminClient can now create topics and subscriptions (A…
534748b 
…zure#16044)

Adding in ability to create/update/delete Topics and Subscriptions.
- Adding in proper request/response objects, as specified by guidelines.
- Adding in tests for handling low privilege failures
- (internal) Removing old _manager structs, in favor of the new AdminClient.

Fixes Azure#15090, Azure#15801
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@richardpark-msft richardpark-msft

Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Milestone
[2021] November
Development

No branches or pull requests
1 participant
@richardpark-msft