This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Return the http status code information in the error text for the "Managers" #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s codes. It doesn't appear to ever be the right thing to do, so now we just have a standard check that looks at the 'err' and then the 'resp' to see if there's something reportable.
… 'not found' is okay since the subscription isn't always created.
jhendrixMSFT
approved these changes
Oct 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The various manager APIs all had their own error handling code, which would result in them occasionally obscuring the actual HTTP response error.
We're now respecting the HTTP status codes and anything >= 400 causes us to fail with an actual error with text, rather than an empty error.
(This fix will need to be imported into the new SDK as well)
Fixes #229