Retry policy will always clone the *http.Request #20843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the entirety of the request is restored on retries.
jhendrixMSFT
requested review from
RickWinter,
chlowell and
richardpark-msft
as code owners
chlowell
reviewed
May 11, 2023
chlowell
approved these changes
May 11, 2023
jhendrixMSFT
added a commit
to jhendrixMSFT/azure-sdk-for-go
that referenced
this pull request
Jun 5, 2023
* Retry policy will always clone the *http.Request This ensures that the entirety of the request is restored on retries. * simplify test
jhendrixMSFT
added a commit
that referenced
this pull request
Jun 5, 2023
* Retry policy will always clone the *http.Request (#20843) * Retry policy will always clone the *http.Request This ensures that the entirety of the request is restored on retries. * simplify test * Handle more error codes when an RP isn't registered (#20848) There's more than one error code returned from unregistered RPs. * Add another non-standard error code for RP registration (#20860) * Prep azcore v1.6.1 for release Cherry-picked the following commits. - a3b2c13 - 889be58 - 6879d7e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the entirety of the request is restored on retries.