Switch to x/crypto/pkcs12 instead of Azure repo #225
Conversation
|
Can you vendor with godep? |
|
yup, one sec |
|
done |
|
Doesn't seem right. Did you use godep tool to vendor the pkg or just edited the json file? Source files are missing. |
|
I used the tool, but forgot to |
|
👍 Just confirmed that this PR fixes the Terraform master build, which was broken when Azure/go-pkcs12#26 landed. |
| @@ -7,7 +7,7 @@ import ( | |||
| "fmt" | |||
| "io/ioutil" | |||
|
|
|||
| "github.com/Azure/go-pkcs12" | |||
| "github.com/Azure/azure-sdk-for-go/Godeps/_workspace/src/golang.org/x/crypto/pkcs12" | |||
There was a problem hiding this comment.
This line is wrong. The import path should be just "golang.org/x/crypto/pkcs12"
There was a problem hiding this comment.
See https://github.com/Azure/azure-sdk-for-go/blob/master/arm/compute/client.go#L22 for example. This is what godeps does to your import paths. This is not wrong, IMHO.
There was a problem hiding this comment.
that's what happens when you do godep save -r which rewrites your paths IMHO. I don't think we need path rewriting here but let's leave it as is for consistency until somebody complains. :)
There was a problem hiding this comment.
also keep in mind that if some project imports this package + golang.org/x/crypto/pkcs12 separately, then it'll end up two copies of it, possibly even duplicate types with the same name in the runtime.
|
LGTM. Feel free to merge after import path fix. |
Switch to x/crypto/pkcs12 instead of Azure repo
* Add associated-link-name property to RenewLocks message. Fix connection idle timeout for messages with >=10minsprocessing time. * Upgrade go-amqp * Make message.getLinkName package level function * only set associated link name if available Co-authored-by: Robert Zakrzewski <Robert.Zakrzewski@tomtom.com> Co-authored-by: Joel Hendrix <jhendrix@microsoft.com>
* Add associated-link-name property to RenewLocks message. Fix connection idle timeout for messages with >=10minsprocessing time. * Upgrade go-amqp * Make message.getLinkName package level function * only set associated link name if available Co-authored-by: Robert Zakrzewski <Robert.Zakrzewski@tomtom.com> Co-authored-by: Joel Hendrix <jhendrix@microsoft.com>
No description provided.