-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
@ahmetalpbalkan is this the right way? |
Maybe we should just delete the repo. |
Having func init() {
log.Println("Azure/go-pkcs12: This package has moved to golang.org/x/crypto/pkcs12")
} or equivalent is a bit nicer. |
That sounds worse than a compile-time error to me. If the depending program was doing something sensitive with the output then it can potentially break users. |
It's nice keeping a README around for a while. The amz package forces a compile time error with: package error
func error() {
`ERROR: the correct import path is gopkg.in/amz.v1 ... `
} Though no code at all would be a compile time error as well. |
the |
I think a compilation error @nathany suggested is better. |
@ahmetalpbalkan @nathany better? |
LGTM |
package error | ||
|
||
func error() { | ||
`ERROR: the correct import path is golang.org/x/crypto/pkcs12 ... ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for ...
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
analogous to amz. Besides, I love '...' most of my text messages end in '...'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like txting but I'll let that slide lol
Since this is now moved into golang.org/x/crypto/pkcs12, let's force everyone to use that version...