Skip to content
This repository has been archived by the owner on Feb 23, 2021. It is now read-only.

Deprecate this repository #26

Merged
merged 1 commit into from
Oct 14, 2015
Merged

Deprecate this repository #26

merged 1 commit into from
Oct 14, 2015

Conversation

paulmey
Copy link
Member

@paulmey paulmey commented Oct 13, 2015

Since this is now moved into golang.org/x/crypto/pkcs12, let's force everyone to use that version...

@paulmey
Copy link
Member Author

paulmey commented Oct 13, 2015

@ahmetalpbalkan is this the right way?

@ahmetb
Copy link
Contributor

ahmetb commented Oct 13, 2015

Maybe we should just delete the repo.

@dgryski
Copy link
Contributor

dgryski commented Oct 13, 2015

Having

func init() {
        log.Println("Azure/go-pkcs12: This package has moved to golang.org/x/crypto/pkcs12")
}

or equivalent is a bit nicer.

@ahmetb
Copy link
Contributor

ahmetb commented Oct 13, 2015

That sounds worse than a compile-time error to me. If the depending program was doing something sensitive with the output then it can potentially break users.

@nathany
Copy link
Contributor

nathany commented Oct 13, 2015

It's nice keeping a README around for a while. The amz package forces a compile time error with:

package error

func error() {
    `ERROR: the correct import path is gopkg.in/amz.v1 ... `
}

Though no code at all would be a compile time error as well.

@paulmey
Copy link
Member Author

paulmey commented Oct 14, 2015

the // import comment generates a error on go get using Go 1.4 and up. See the broken travis build for the error...

@ahmetb
Copy link
Contributor

ahmetb commented Oct 14, 2015

I think a compilation error @nathany suggested is better.

@paulmey
Copy link
Member Author

paulmey commented Oct 14, 2015

@ahmetalpbalkan @nathany better?

@nathany
Copy link
Contributor

nathany commented Oct 14, 2015

LGTM

package error

func error() {
`ERROR: the correct import path is golang.org/x/crypto/pkcs12 ... `
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for ... ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

analogous to amz. Besides, I love '...' most of my text messages end in '...'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like txting but I'll let that slide lol

paulmey added a commit that referenced this pull request Oct 14, 2015
Deprecate this repository
@paulmey paulmey merged commit 3492eed into Azure:master Oct 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants