Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Monitor Query] Test cases for querying logs #22262

Closed
28 of 32 tasks
srnagar opened this issue Jun 13, 2021 · 4 comments
Closed
28 of 32 tasks

[Azure Monitor Query] Test cases for querying logs #22262

srnagar opened this issue Jun 13, 2021 · 4 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Monitor Monitor, Monitor Ingestion, Monitor Query
Milestone

Comments

@srnagar
Copy link
Member

srnagar commented Jun 13, 2021

Logs query

Client test

  • Every request should include user-agent header in the expected format
  • Test distributed tracing instrumentation
  • Test support for different cloud environments*

Single query

  • Test a single query - happy case
  • Test a single query with partial success (returns 200 response but response body has tables + error)
  • Test a single query that returns an error (non-200 response)
  • Test all column data types are handled
  • Test mapping a table row into a strongly typed model
  • Test query for specific time ranges
    • Start and end datetime range (2021-06-08/2021-06-09)
    • Start datetime and end duration (2021-06-09/PT3H)
    • Start duration and end datetime (PT3H/2021-06-09)
    • Duration (PT12H)
    • No time range (query full dataset)
  • Test query that returns statistics
  • Test query that returns visualization data
  • Test query that requires > 3m to run and set server timeout value to 10 m
  • Test query that uses additional workspaces
    • Azure resource id
    • Workspace name
    • Workspace id
    • Fully qualified resource id

Batch query

  • Test a batch request - happy case
  • Test a batch request with error (server returns non-200 response)
  • Test a batch request with partial success (some queries in batch fail)
  • Test a batch request with individual queries returning partial success (single query in a batch has status 200 with error in the result)
  • Test a batch request which contains a query that requires > 3m to run and set the server timeout value to 10 m for that query
  • Test a batch request that returns statistics (for some or all queries in the batch)
  • Test a batch request that returns visualization data (for some or all queries in the batch)
  • Test a batch request that uses different workspaces for different queries in the batch
  • Test a batch request that uses additional workspaces for a query in the batch
  • Test a batch request that has n queries (n > 200) in a batch (service supports up to 200 requests in 30-second window) to validate server returning 429 response for n - 200 queries and successful response for first 200 queries.
@srnagar srnagar added Client This issue points to a problem in the data-plane of the library. Monitor - Log labels Jun 13, 2021
@srnagar srnagar added this to the [2021] July milestone Jun 13, 2021
@srnagar srnagar self-assigned this Jun 13, 2021
@pakrym
Copy link
Contributor

pakrym commented Jun 14, 2021

Test a single query with partial success (returns 200 response but response body has tables + error)

What's the expected user experience?

@pakrym
Copy link
Contributor

pakrym commented Jun 14, 2021

Test query that returns visualization data

How do we plan to expose the visualization data?

Same as statistics.

@srnagar
Copy link
Member Author

srnagar commented Jun 21, 2021

What's the expected user experience?

@pakrym The result will contain a non-null tables property and error property when this happens. The user should ideally check for both to ensure there are no errors.

However, most users would check the error field and assume the query failed (if they check errors first) or assume that the query succeeded if the tables field had results even though it was only a partial success. So, we should clearly document and provide samples to check for both fields.

We could additionally include an enum to indicate the result status - {ERROR, SUCCESS, PARTIAL_SUCCESS} to make this obvious and the user can check this first to know how to process the result.

Thoughts?

@pakrym
Copy link
Contributor

pakrym commented Jun 23, 2021

Thoughts?

Sounds good on exposing error. I've also exposed a HasFailed property to differentiate between full failure and partial one.

@srnagar srnagar closed this as completed Jun 6, 2022
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this issue Feb 1, 2023
Machinelearningservices microsoft.machine learning services 2022 12 01 preview (Azure#21761)

* Adds base for updating Microsoft.MachineLearningServices from version preview/2022-10-01-preview to version 2022-12-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add Dec API Registries Swagger (Azure#21419)

* add december registries swagger + examples

* add status code 202 in examples

* fix 202 examples

* fixes

* fixes

* fix

* add 202 back in for put/patch

Co-authored-by: Komal Yadav <komalyadav@microsoft.com>

* remove location (Azure#21430)

Co-authored-by: Komal Yadav <komalyadav@microsoft.com>

* remove readonly flag on schedules property for CI (Azure#21653)

Co-authored-by: Naman Agarwal <naagarw@microsoft.com>

* add missing workspace properties (Azure#21725)

* December preview updating mfe.json specs (Azure#21510)

* December preview updating mfe.json specs

* MFE Dec 2022 Preview API - Adding logbase

* MFE 2022-12-01-preview swagger spec model validation fix

* MFE 2022-12-01-preview swagger spec model validation fix, add missing location

* MFE 2022-12-01-preview swagger spec model validation - typo fix

* MFE 2022-12-01-preview swagger spec model validation - fix api version in automljob example

* MFE 2022-12-01-preview swagger spec model validation - fix for multiselectenabled error

* MFE 2022-12-01-preview swagger spec model validation - fix for multiselectenabled error

* Fix  for 1006 - RemovedDefinition (RecurrenceTrigger,CronTrigger) (Azure#21822)

* fix ReadonlyPropertyChanged of MLC (Azure#21814)

Co-authored-by: Bingchen Li <bingchenli@microsoft.com>

* fixed custom-words conflict (Azure#21829)

* fix custom-words conflict merge (Azure#21830)

* example fix (INVALID_REQUEST_PARAMETER) (Azure#21832)

Co-authored-by: Ivaliy Ivanov <ivaliyivanov@Ivaliys-MacBook-Air.local>

* example fix, use correct api preview version  - (INVALID_REQUEST_PARAMETER) (Azure#21833)

Co-authored-by: Ivaliy Ivanov <ivaliyivanov@Ivaliys-MacBook-Air.local>

* Revert breaking change for MLC swagger 2022-12-01-preview (Azure#21885)

Co-authored-by: Bingchen Li <bingchenli@microsoft.com>

* Revert Connection Category back to enum. (Azure#21939)

* revert provisioning state change (Azure#21940)

* remove body (Azure#21978)

Co-authored-by: Komal Yadav <komalyadav@microsoft.com>

* Addressed comments, added x-ms-long-running-operation to a patch call (Azure#22005)

* Addressed comments, added x-ms-long-running-operation to a patch call

* fix examples for patch - remove body

* fixed formatting

* Ivalbert fix patch2 (Azure#22006)

* Addressed comments, added x-ms-long-running-operation to a patch call

* fix examples for patch - remove body

* fixed formatting

* fixed formatting

* Updated custom words (Azure#22262)

* Fixed prettier errors (Azure#22237)

* fixed examples for LRO_RESPONSE_HEADER check (Azure#22293)

* fixed examples for LRO_RESPONSE_HEADER check (Azure#22294)

* Example fix - OBJECT_MISSING_REQUIRED_PROPERTY - Missing required property: triggerType (Azure#22317)

---------

Co-authored-by: Komal Yadav <23komal.yadav23@gmail.com>
Co-authored-by: Komal Yadav <komalyadav@microsoft.com>
Co-authored-by: Naman Agarwal <namanag16@gmail.com>
Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
Co-authored-by: ZhidaLiu <zhili@microsoft.com>
Co-authored-by: libc16 <88697960+libc16@users.noreply.github.com>
Co-authored-by: Bingchen Li <bingchenli@microsoft.com>
Co-authored-by: Ivaliy Ivanov <ivaliyivanov@Ivaliys-MacBook-Air.local>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
@srnagar srnagar added Monitor Monitor, Monitor Ingestion, Monitor Query and removed Monitor - Log labels Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Monitor Monitor, Monitor Ingestion, Monitor Query
Projects
None yet
Development

No branches or pull requests

2 participants