Create new test module: azure-spring-boot-test-aad-resource-server #18412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenrujun
commented
Dec 31, 2020
•
chenrujun
commented
- Add new test module: azure-spring-boot-test-aad-resource-server.
- Update HOW_TO_RUN_AAD_INTEGRATION_TEST_IN_LOCALHOST.md about how to expose api.
- Update the required dependency about oauth2-client and oauth2-resource-server.
- Delete duplicated codes in aad integration test modules.
- Rename azure-spring-boot-sample-active-directory-resource-server-with-filter to azure-spring-boot-sample-active-directory-resource-server-by-filter.
- Rename azure-spring-boot-sample-active-directory-resource-server-stateless to azure-spring-boot-sample-active-directory-resource-server-by-filter-stateless.
- Move filter related test into a new module: azure-spring-boot-test-aad-resource-server-by-filter
- Update HOW_TO_RUN_AAD_INTEGRATION_TEST_IN_LOCALHOST.md
2. Update HOW_TO_RUN_AAD_INTEGRATION_TEST_IN_LOCALHOST.md about how to expose api.
chenrujun
requested review from
alzimmermsft,
backwind1233,
danieljurek,
jialindai,
JimSuplizio,
mitchdenny,
samvaity,
saragluna and
yiliuTo
as code owners
ghost
added
the
chenrujun
commented
Dec 31, 2020
| <groupId>org.springframework.security</groupId> | ||
| <artifactId>spring-security-oauth2-client</artifactId> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-oauth2-client</artifactId> |
There was a problem hiding this comment.
@yiliuTo ,
(cc: @saragluna , @backwind1233 , FYI)
we should use xxx-starter instead of xxx, because xxx-starter can include other necessary dependencies. Like spring-security-oauth2-jose.
chenrujun
commented
Dec 31, 2020
| ``` | ||
| [//]: # "{x-version-update-end}" | ||
|
|
||
| To use this starter in a resource server with OBO function, please add following packages: |
There was a problem hiding this comment.
The dependency is different between resource-server and resource-server with obo function.
chenrujun
commented
Dec 31, 2020
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…est-aad-resource-server
…d-resource-server-by-filter
…-filter to azure-spring-boot-sample-active-directory-resource-server-by-filter.
…eless to azure-spring-boot-sample-active-directory-resource-server-by-filter-stateless.
…zure-spring-boot-test-aad-resource-server-by-filter.
…ing" folder. 2. Add commands about run test of other aad integration test modules.
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi, @yiliuTo , @saragluna , @backwind1233 , please help to review this PR. 🙏 |
…est-aad-resource-server
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chenrujun
pushed a commit
to alzimmermsft/azure-sdk-for-java
that referenced
this pull request
Jan 5, 2021
...er-by-filter/src/test/java/com/azure/test/aad/filter/stateful/AADAuthenticationFilterIT.java
Show resolved
Hide resolved
chenrujun
pushed a commit
to alzimmermsft/azure-sdk-for-java
that referenced
this pull request
Jan 5, 2021
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi, @lzc-1997-abel , if you approve this PR, please comment |
|
LGTM |
|
/check-enforcer override |
yiliuTo
approved these changes
Jan 6, 2021
chenrujun
deleted the
create-new-test-module-azure-spring-boot-test-aad-resource-server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.