Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unnecessary dependency in webapi samples #18423

Merged
merged 4 commits into from
Jan 7, 2021
Merged

Replace unnecessary dependency in webapi samples #18423

merged 4 commits into from
Jan 7, 2021

Conversation

wujack778
Copy link
Contributor

Replace unnecessary dependency in webapi samples
task link

@ghost ghost added the azure-spring All azure-spring related issues label Jan 4, 2021
chenrujun
chenrujun approved these changes Jan 4, 2021
View reviewed changes
Copy link

@chenrujun chenrujun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @wujack778 , did you test it after you update the pom?

@chenrujun chenrujun added the azure-spring-aad Spring active directory related issues. label Jan 4, 2021
@wujack778
Copy link
Contributor Author

wujack778 commented Jan 4, 2021 •
edited
Loading

I passed the sample @chenrujun

saragluna
saragluna approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saragluna
Copy link
Member

@wujack778 I will merge this PR for now. @moarychan will help create another PR, to:

image
image

  • Remove the include packages part for two Web API samples, to make them consistent with our other samples.

@saragluna saragluna merged commit 026fdc3 into Azure:master Jan 7, 2021
@wujack778 wujack778 deleted the remove-unnecessary-dependency-webapi branch January 29, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrujun chenrujun chenrujun approved these changes

@saragluna saragluna saragluna approved these changes

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@jialindai jialindai Awaiting requested review from jialindai

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wujack778 @saragluna @chenrujun