Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Jackson to 2.12 #18884

Merged
merged 19 commits into from
Feb 22, 2021
Merged

Upgrade Jackson to 2.12 #18884

merged 19 commits into from
Feb 22, 2021

Conversation

alzimmermsft
Copy link
Member

@alzimmermsft alzimmermsft commented Jan 29, 2021 •
edited
Loading

This PR upgrades all Jackson dependencies from 2.11 to 2.12.

In the newest version, Jackson made a few changes to how XML serialization and deserialization handled inferring types and handling default scenarios. Default handling for empty lists and strings changed from null to being empty, additionally Jackson introduced a new concept of Coercion which takes precedence over configurations such as FromXmlParser.Feature.EMPTY_ELEMENT_AS_NULL.

@alzimmermsft alzimmermsft added Do Not Merge Client This issue points to a problem in the data-plane of the library. common common module used by all azure SDKs (e.g. client, Mgmt) labels Jan 29, 2021
@alzimmermsft alzimmermsft self-assigned this Jan 29, 2021
@ghost ghost added App Configuration Azure.ApplicationModel.Configuration Batch Azure.Core azure-core Cosmos azure-spring All azure-spring related issues DigitalTwins KeyVault labels Jan 29, 2021
@alzimmermsft
Copy link
Member Author

/azp run java - storage

@alzimmermsft
Copy link
Member Author

/azp run java - eventhubs

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

srnagar
srnagar approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@srnagar srnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alzimmermsft alzimmermsft requested a review from conniey February 1, 2021 18:20
@gapra-msft gapra-msft mentioned this pull request Feb 16, 2021
Closed
3 tasks
@rickle-msft rickle-msft mentioned this pull request Feb 16, 2021
Closed
3 tasks
@alzimmermsft
Copy link
Member Author

@kushagraThapar could you review, or find someone to review, the Cosmos changes?

@kushagraThapar
Copy link
Member

@kushagraThapar could you review, or find someone to review, the Cosmos changes?

I don't see any cosmos code changes. And since you already ran the cosmos ci, I think you are good from cosmos point of view.

@alzimmermsft
Copy link
Member Author

/azp run java - appconfiguration - tests

@alzimmermsft
Copy link
Member Author

/azp run java - search - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alzimmermsft
Copy link
Member Author

/azp run java - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

kushagraThapar
kushagraThapar approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alzimmermsft - if you have time and bandwidth, please run the cosmos live tests as well, just to give us good confidence in this upgrade.

@alzimmermsft
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

gapra-msft
gapra-msft reviewed Feb 22, 2021
View reviewed changes
Copy link
Member

@gapra-msft gapra-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a storage perspective

@alzimmermsft alzimmermsft merged commit c080eff into Azure:master Feb 22, 2021
@alzimmermsft alzimmermsft deleted the AzVersion_UpgradeJackson branch February 22, 2021 21:47
This was referenced Feb 22, 2021
Merged
Closed
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request May 10, 2022
@tyler-lloyd @gossion
@karataliu @ShiqianTao @ZeroMagic @UtheMan
CodeGen from PR 18900 in Azure/azure-rest-api-specs
ba27522 
Review request for Microsoft.ContainerService to add version 2022-04-02-preview (Azure#18900)

* Adds base for updating Microsoft.ContainerService from version preview/2022-03-02-preview to version 2022-04-02-preview

* Updates readme

* Updates API version in new specs and examples

* update readme (Azure#18714)

* add NetworkPluginMode to ManagedCluster (Azure#18735)

* add NetworkPluginMode to ManagedCluster

* add overlay example

* remove example

* only keep overlap as option

* Add properties for apiserver-vnet-integration (Azure#18705)

* Update for AKS trusted access feature (Azure#18708)

* Update for AKS trusted access feature

* fixup! Update for AKS trusted access feature

* fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* OSSKU supports Windows options (Azure#18706)

* OSSKU supports Windows options

* Add example Create Agent Pool with Windows OSSKU

* Improve description about the default value

* Improve the description to clarify

* Improve description about default Windows OSSKU

* add storageProfile into managedcluster (Azure#18817)

Signed-off-by: Ji An Liu <jiliu8@microsoft.com>

* capatalize NetworkPluginMode name (Azure#18884)

* capatalize NetworkPluginMode name

* capitalize in description

* aks: add enableCustomCATrust in v20220402-preview api-version (Azure#18830)

* aks: add enableCustomCATrust in v20220402-preview api-version

* aks: add description of CustomCATrust

* aks: fix typo, add DaemonSet to custom words list

Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com>

* [AKS] Update on trustedaccess resource (Azure#18947)

* Add paging for trusted access

* update async state

* fixup! update async state

* Use enum for TrustedAccessRoleBinding's ProvisioningState (Azure#18950)

Co-authored-by: Tyler Lloyd <tyler.lloyd@microsoft.com>
Co-authored-by: gossion <guwe@microsoft.com>
Co-authored-by: Dong Liu <doliu@microsoft.com>
Co-authored-by: Shiqian Tao <62196586+ShiqianTao@users.noreply.github.com>
Co-authored-by: Ji'an Liu <jiliu8@microsoft.com>
Co-authored-by: Mikołaj Umański <mik.umanski@gmail.com>
Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srnagar srnagar srnagar approved these changes

@gapra-msft gapra-msft gapra-msft left review comments

@kushagraThapar kushagraThapar kushagraThapar approved these changes

@conniey conniey conniey approved these changes

@abhipsaMisra abhipsaMisra Awaiting requested review from abhipsaMisra

@amishra-dev amishra-dev Awaiting requested review from amishra-dev

@anuchandy anuchandy Awaiting requested review from anuchandy

@azabbasi azabbasi Awaiting requested review from azabbasi

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@barustum barustum Awaiting requested review from barustum

@bgklein bgklein Awaiting requested review from bgklein

@bikamani bikamani Awaiting requested review from bikamani

@chenrujun chenrujun Awaiting requested review from chenrujun

@danieljurek danieljurek Awaiting requested review from danieljurek

@drwill-ms drwill-ms Awaiting requested review from drwill-ms

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel

@g2vinay g2vinay Awaiting requested review from g2vinay

@hemanttanwar hemanttanwar Awaiting requested review from hemanttanwar

@jaschrep-msft jaschrep-msft Awaiting requested review from jaschrep-msft

@jialindai jialindai Awaiting requested review from jialindai

@jianghaolu jianghaolu Awaiting requested review from jianghaolu

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio

@joshfree joshfree Awaiting requested review from joshfree

@kasobol-msft kasobol-msft Awaiting requested review from kasobol-msft

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli

@matthchr matthchr Awaiting requested review from matthchr

@mbhaskar mbhaskar Awaiting requested review from mbhaskar

@milismsft milismsft Awaiting requested review from milismsft

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@moderakh moderakh Awaiting requested review from moderakh

@mssfang mssfang Awaiting requested review from mssfang

@rickle-msft rickle-msft Awaiting requested review from rickle-msft

@samvaity samvaity Awaiting requested review from samvaity

@saragluna saragluna Awaiting requested review from saragluna

@simplynaveen20 simplynaveen20 Awaiting requested review from simplynaveen20

@timtay-microsoft timtay-microsoft Awaiting requested review from timtay-microsoft

@vcolin7 vcolin7 Awaiting requested review from vcolin7

@vinagesh vinagesh Awaiting requested review from vinagesh

@xingwu1 xingwu1 Awaiting requested review from xingwu1

@xinlian12 xinlian12 Awaiting requested review from xinlian12

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

Assignees

@alzimmermsft alzimmermsft

Labels
App Configuration Azure.ApplicationModel.Configuration Azure.Core azure-core azure-spring All azure-spring related issues Batch Client This issue points to a problem in the data-plane of the library. common common module used by all azure SDKs (e.g. client, Mgmt) Cosmos KeyVault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alzimmermsft @kushagraThapar @conniey @gapra-msft @srnagar @jsquire