Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check to catch delinquent eng/common changes #18900

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Add check to catch delinquent eng/common changes #18900

merged 1 commit into from
Feb 11, 2021

Conversation

chidozieononiwu
Copy link
Member

Add check to catch delinquent eng/common changes

@check-enforcer
Copy link

check-enforcer bot commented Feb 1, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@chidozieononiwu
Copy link
Member Author

Please help approve @mitchdenny @weshaggard

@weshaggard
Copy link
Member

/azp run java - template

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

weshaggard
weshaggard reviewed Feb 11, 2021
View reviewed changes
eng/pipelines/templates/jobs/archetype-sdk-client.yml
@@ -181,6 +181,7 @@ jobs:
name: ${{ parameters.LinuxPool }}

steps:
- template: /eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml
- pwsh: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it would be nice to have a blank line here.

@chidozieononiwu chidozieononiwu force-pushed the AddEngCommonWorkflowEnforcer branch from 7883b61 to 5338e51 Compare February 11, 2021 21:57
@chidozieononiwu
Copy link
Member Author

/check-enforcer override

@chidozieononiwu chidozieononiwu merged commit f66e8ac into Azure:master Feb 11, 2021
weshaggard added a commit that referenced this pull request Feb 11, 2021
@weshaggard
Revert "Add check to catch delinquent eng/common changes (#18900)"
024475c 
This reverts commit f66e8ac.
@weshaggard weshaggard mentioned this pull request Feb 11, 2021
Merged
weshaggard added a commit that referenced this pull request Feb 11, 2021
@weshaggard
Revert "Add check to catch delinquent eng/common changes (#18900)" (#…
08872ec 
…19198)

This reverts commit f66e8ac.
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request May 10, 2022
@tyler-lloyd @gossion
@karataliu @ShiqianTao @ZeroMagic @UtheMan
CodeGen from PR 18900 in Azure/azure-rest-api-specs
ba27522 
Review request for Microsoft.ContainerService to add version 2022-04-02-preview (Azure#18900)

* Adds base for updating Microsoft.ContainerService from version preview/2022-03-02-preview to version 2022-04-02-preview

* Updates readme

* Updates API version in new specs and examples

* update readme (Azure#18714)

* add NetworkPluginMode to ManagedCluster (Azure#18735)

* add NetworkPluginMode to ManagedCluster

* add overlay example

* remove example

* only keep overlap as option

* Add properties for apiserver-vnet-integration (Azure#18705)

* Update for AKS trusted access feature (Azure#18708)

* Update for AKS trusted access feature

* fixup! Update for AKS trusted access feature

* fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* OSSKU supports Windows options (Azure#18706)

* OSSKU supports Windows options

* Add example Create Agent Pool with Windows OSSKU

* Improve description about the default value

* Improve the description to clarify

* Improve description about default Windows OSSKU

* add storageProfile into managedcluster (Azure#18817)

Signed-off-by: Ji An Liu <jiliu8@microsoft.com>

* capatalize NetworkPluginMode name (Azure#18884)

* capatalize NetworkPluginMode name

* capitalize in description

* aks: add enableCustomCATrust in v20220402-preview api-version (Azure#18830)

* aks: add enableCustomCATrust in v20220402-preview api-version

* aks: add description of CustomCATrust

* aks: fix typo, add DaemonSet to custom words list

Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com>

* [AKS] Update on trustedaccess resource (Azure#18947)

* Add paging for trusted access

* update async state

* fixup! update async state

* Use enum for TrustedAccessRoleBinding's ProvisioningState (Azure#18950)

Co-authored-by: Tyler Lloyd <tyler.lloyd@microsoft.com>
Co-authored-by: gossion <guwe@microsoft.com>
Co-authored-by: Dong Liu <doliu@microsoft.com>
Co-authored-by: Shiqian Tao <62196586+ShiqianTao@users.noreply.github.com>
Co-authored-by: Ji'an Liu <jiliu8@microsoft.com>
Co-authored-by: Mikołaj Umański <mik.umanski@gmail.com>
Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@danieljurek danieljurek Awaiting requested review from danieljurek

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chidozieononiwu @weshaggard