-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TA] Fixed incompatible changes after using the latest swagger SHA #30278
Conversation
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
@mssfang I don't see it in this PR, but what swagger commit did you use? I'm using e59b6449e6613c0e4ecb73daacacdff320d65f67. |
it is in the feature branch: 31d2099 The Swagger reference is https://raw.githubusercontent.com/Azure/azure-rest-api-specs/f705a46c74af9e4c096556e914d9a45c01c47b5e/specification/cognitiveservices/data-plane/Language/stable/2022-05-01/analyzetext.json |
/check-enforcer evaluate |
We should only be GA'ind SDKs from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't FhirVersion.java just be deleted? GitHub is showing it as an empty file. 😕
...-textanalytics/src/main/java/com/azure/ai/textanalytics/implementation/AnalyzeTextsImpl.java
Show resolved
Hide resolved
It is deleting an empty FHRI file. It should be deleted but I think I resolved it with leave it as an empty file before. |
/check-enforcer evaluate |
/azp run java - textanalytics - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - textanalytics - ci |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
/azp run java - textanalytics - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
CI passed in https://dev.azure.com/azure-sdk/public/_build/results?buildId=1762278&view=results It has something wrong with live test, My local llve tests passed but not pipeline. Will resolve this issue in the future PR. |
* [TA] Regenerated based on the new swagger 2022-05-01 (Azure#29479) * regenerate without any changes * [TA] Fixed incompatible changes after using the latest swagger SHA (Azure#30278) * [TA] Added Bespoke methods to SDK (Azure#29589) * record bespoke methods (Azure#30407)
This PR fixed the incompatible changes after merged changes to the feature branch using the latest swagger SHA.