Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TA] Fixed incompatible changes after using the latest swagger SHA #30278

Merged
merged 4 commits into from
Aug 5, 2022

Conversation

mssfang
Copy link
Member

@mssfang mssfang commented Aug 4, 2022

This PR fixed the incompatible changes after merged changes to the feature branch using the latest swagger SHA.

@mssfang mssfang added Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics labels Aug 4, 2022
@mssfang mssfang added this to the 2022-08 milestone Aug 4, 2022
@mssfang mssfang self-assigned this Aug 4, 2022
@mssfang mssfang marked this pull request as ready for review August 4, 2022 18:39
@mssfang mssfang requested a review from samvaity as a code owner August 4, 2022 18:39
@check-enforcer
Copy link

check-enforcer bot commented Aug 4, 2022

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@heaths
Copy link
Member

heaths commented Aug 4, 2022

@mssfang I don't see it in this PR, but what swagger commit did you use? I'm using e59b6449e6613c0e4ecb73daacacdff320d65f67.

@mssfang
Copy link
Member Author

mssfang commented Aug 4, 2022

@mssfang I don't see it in this PR, but what swagger commit did you use? I'm using e59b6449e6613c0e4ecb73daacacdff320d65f67.

it is in the feature branch: 31d2099

The Swagger reference is https://raw.githubusercontent.com/Azure/azure-rest-api-specs/f705a46c74af9e4c096556e914d9a45c01c47b5e/specification/cognitiveservices/data-plane/Language/stable/2022-05-01/analyzetext.json

@mssfang
Copy link
Member Author

mssfang commented Aug 4, 2022

/check-enforcer evaluate

@heaths
Copy link
Member

heaths commented Aug 4, 2022

We should only be GA'ind SDKs from main.

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't FhirVersion.java just be deleted? GitHub is showing it as an empty file. 😕

@mssfang
Copy link
Member Author

mssfang commented Aug 5, 2022

Shouldn't FhirVersion.java just be deleted? GitHub is showing it as an empty file. 😕

It is deleting an empty FHRI file. It should be deleted but I think I resolved it with leave it as an empty file before.

@mssfang
Copy link
Member Author

mssfang commented Aug 5, 2022

/check-enforcer evaluate

@mssfang
Copy link
Member Author

mssfang commented Aug 5, 2022

/azp run java - textanalytics - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssfang mssfang requested a review from samvaity August 5, 2022 19:58
@mssfang
Copy link
Member Author

mssfang commented Aug 5, 2022

/azp run java - textanalytics - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mssfang
Copy link
Member Author

mssfang commented Aug 5, 2022

/azp run java - textanalytics - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssfang
Copy link
Member Author

mssfang commented Aug 5, 2022

CI passed in https://dev.azure.com/azure-sdk/public/_build/results?buildId=1762278&view=results

It has something wrong with live test, My local llve tests passed but not pipeline. Will resolve this issue in the future PR.

@mssfang mssfang merged commit 9e152e6 into Azure:TA-5.2.0 Aug 5, 2022
@mssfang mssfang deleted the TA-regenerate-latest-sha branch August 5, 2022 22:02
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 11, 2022
* [TA] Regenerated based on the new swagger 2022-05-01 (Azure#29479)

* regenerate without any changes

* [TA] Fixed incompatible changes after using the latest swagger SHA (Azure#30278)

* [TA] Added Bespoke methods to SDK (Azure#29589)

* record bespoke methods (Azure#30407)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants