Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TA] Added the test json files for the bespoken methods #30407

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

mssfang
Copy link
Member

@mssfang mssfang commented Aug 11, 2022

No description provided.

@mssfang mssfang added Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics labels Aug 11, 2022
@mssfang mssfang added this to the 2022-08 milestone Aug 11, 2022
@mssfang mssfang self-assigned this Aug 11, 2022
@mssfang mssfang marked this pull request as ready for review August 11, 2022 18:27
@mssfang mssfang requested a review from samvaity as a code owner August 11, 2022 18:27
Configuration.getGlobalConfiguration().get(AZURE_TEXT_ANALYTICS_CUSTOM_ENTITIES_PROJECT_NAME),
Configuration.getGlobalConfiguration().get(AZURE_TEXT_ANALYTICS_CUSTOM_ENTITIES_DEPLOYMENT_NAME))
);
asList(AZURE_TEXT_ANALYTICS_CUSTOM_ENTITIES_PROJECT_NAME,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you just now enable these tests, how were not failing before without the recordings?

Copy link
Member Author

@mssfang mssfang Aug 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't test before. Somehow, for my PR merges to feature branch. Don't pick up a CI, so I would run the test when merging to main

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@mssfang mssfang merged commit bdacef2 into Azure:TA-5.2.0 Aug 11, 2022
@mssfang mssfang deleted the TA-fix-live-tests branch August 11, 2022 19:25
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 11, 2022
* [TA] Regenerated based on the new swagger 2022-05-01 (Azure#29479)

* regenerate without any changes

* [TA] Fixed incompatible changes after using the latest swagger SHA (Azure#30278)

* [TA] Added Bespoke methods to SDK (Azure#29589)

* record bespoke methods (Azure#30407)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants