Add Additional Synchronous Polling APIs #31495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
added
Client
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
alzimmermsft
requested review from
srnagar,
anuchandy,
lmolkova,
vcolin7,
mssfang,
JonathanGiles and
billwert
as code owners
|
tagging @srnagar for review from Autorest side. |
srnagar
reviewed
Nov 3, 2022
| * response body should be kept. This should match the generic parameter {@link U}. | ||
| * @return a poll response containing the status and the response content | ||
| */ | ||
| default PollResponse<T> onInitialResponseSync(Response<?> response, PollingContext<T> pollingContext, |
There was a problem hiding this comment.
All these default sync APIs on this interface indicate that we could create a SyncPollingStrategy but not sure how that will impact existing implementations if we do that.
There was a problem hiding this comment.
This PR shows, a subset of, what this would look like: #31495
|
Closed for #31923 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds additional synchronous polling APIs
SyncPoller.PollingStrategyAll SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines