Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SyncPollingStrategy Compliment to PollingStrategy #31923

Merged
merged 4 commits into from
Nov 3, 2022
Merged

SyncPollingStrategy Compliment to PollingStrategy #31923

merged 4 commits into from
Nov 3, 2022

Conversation

alzimmermsft
Copy link
Member

Description

Adds additional synchronous polling APIs

  • Additional factory method on SyncPoller.
  • Synchonrous PollingStratgy SyncPollingStrategy.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft changed the title Example of SyncPollingStrategy SyncPollingStrategy Compliment to PollingStrategy Nov 3, 2022
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-core

@alzimmermsft alzimmermsft marked this pull request as ready for review November 3, 2022 19:18
@alzimmermsft alzimmermsft merged commit 24a912a into Azure:main Nov 3, 2022
@alzimmermsft alzimmermsft deleted the AzCore_AddSynchronousPollingStrategyAsSeparateInterface branch November 3, 2022 20:32
@alzimmermsft alzimmermsft mentioned this pull request Nov 3, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srnagar srnagar srnagar approved these changes

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@lmolkova lmolkova Awaiting requested review from lmolkova lmolkova is a code owner

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 is a code owner

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@billwert billwert Awaiting requested review from billwert billwert is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alzimmermsft @azure-sdk @srnagar