Skip to content

Commit

Permalink
Squashed commit of the following:
Browse files Browse the repository at this point in the history 
commit ac86a56
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Wed Oct 13 10:43:51 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 2095 (#18149)

    * Mitigate relative path calculation error on multiple iterations

    * Revert "Mitigate relative path calculation error on multiple iterations"

    This reverts commit 45baedd990c6a3085742a38a4891d8706a93be77.

    * GetRelativePath should check if path is already relative before calling [IO.Path]::GetRelativePath

    Co-authored-by: Daniel Jurek <djurek@microsoft.com>

commit 0afa58e
Author: KarishmaGhiya <kaghiya@microsoft.com>
Date:   Tue Oct 12 19:12:09 2021 -0700

    add troubleshooting guide for identity (#17734)

    * add troubleshooting guide for identity
    Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

commit a319c90
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date:   Tue Oct 12 22:01:34 2021 -0400

    [Identity] On Behalf Of sample (#18109)

    * [Identity] On Behalf Of sample

    * once again, I forgot to remove en-us

    * Apply suggestions from code review

    Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

    * extra line

    * removed old section

    * Apply suggestions from code review

    Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

    Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

commit 63be7d2
Author: KarishmaGhiya <kaghiya@microsoft.com>
Date:   Tue Oct 12 18:15:34 2021 -0700

    Readme inconsistency (#18098)

commit 8066272
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date:   Tue Oct 12 15:51:28 2021 -0400

    [Identity] What if we accepted the PEM certificate string contents? (#18017)

    This PR serves to explore the idea of changing the public API of ClientCertificateCredential before we release v2, to allow users to either pass the path to a PEM certificate in the filesystem, or the string certificate contents directly.

    .NET allows a similar set of alternatives (with more flexibility on the type of certificates than us): https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/identity/Azure.Identity/api/Azure.Identity.netstandard2.0.cs#L96

    This could help us provide a better experience for issues similar to #17715

    Feedback appreciated 🙏

commit 68fbad6
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date:   Tue Oct 12 14:57:34 2021 -0400

    [Identity] Removed AzureApplicationCredential from our public API (#18129)

    * [Identity] Removed AzureApplicationCredential from our public API

    * Apply suggestions from code review

    Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>

    Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>

commit 1e706fc
Author: Hiroshi Yoshioka <40815708+hyoshioka0128@users.noreply.github.com>
Date:   Wed Oct 13 00:23:18 2021 +0900

    Typo "Typescript"→"TypeScript" (#18141)

    https://docs.microsoft.com/en-us/javascript/api/overview/azure/service-bus-readme?view=azure-node-latest
    related: "MicrosoftDocs/azure-docs-sdk-node#1287 (review)"
    @danieljurek  - Thank you for your suggestion.

commit 1d9ba8c
Author: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>
Date:   Tue Oct 12 12:33:54 2021 +0800

    Refresh purview catalog for release (#17870)

    * refresh-purview-catalog-for-release

    * manual update dependencies

    * update test recordings

    * resolve format

    * update readme.md

    * regenerate with header support

    * format update

    * update test without lro

    * fix ci failure

commit 1fa8a24
Author: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>
Date:   Tue Oct 12 12:29:46 2021 +0800

    refresh purview scanning for release (#17871)

    * refresh purview scanning for release

    * update readme.md

    * update paginate test support

    * format update

    * format fix

commit 5d16ee4
Author: KarishmaGhiya <kaghiya@microsoft.com>
Date:   Mon Oct 11 15:24:23 2021 -0700

    update tracing for consistency (#18076)

commit e5a2bf2
Author: Jeremy Meng <yumeng@microsoft.com>
Date:   Mon Oct 11 14:04:18 2021 -0700

    [core-http] terminate connection when download stream is closed (#14015)

    The issue is that when the stream is closed explicitly by `stream.destroy()`
    call, we don't ask the underlying transportation layer to cancel the request,
    thus leaving network connection to service open which could cause resource
    exhaustion.

    Addresses #11850

commit b92ae58
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Mon Oct 11 13:38:16 2021 -0700

    Post release automated changes for azure-arm-quota (#18089)

commit c20d707
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Mon Oct 11 13:29:59 2021 -0700

    Post release automated changes for azure-arm-extendedlocation (#18097)

commit 7a12b14
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date:   Mon Oct 11 13:57:32 2021 -0400

    [Identity] AuthenticationRequiredError options (#17987)

    This PR comes from the feedback from @xirzec on the API review for the upcoming Identity release. The feedback stated that these optional parameters to AuthenticationRequiredError should be in an options bag, and that the `getTokenOptions` public property in that error class should be optional.

    This PR:
    - Moves the optional parameters of AuthenticationRequiredError to an options bag.
    - And also moves the two errors we expose into the same file, in a more convenient location.

    Feedback appreciated 🙏

commit 0d80df2
Author: Jeremy Meng <yumeng@microsoft.com>
Date:   Mon Oct 11 10:45:56 2021 -0700

    [KeyVault][Test] remove async iterator polyfill (#18108)

    since Node 8 is no longer supported.

commit 34d6c1d
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date:   Mon Oct 11 13:35:52 2021 -0400

    [Identity] Following up on reference renames from ApplicationCredential to AzureApplicationCredential (#18110)

    Continuing from: #18072

    I merged that one by mistake. I took a walk and after I came back I was too excited to see it approved, I got too close of the merge button and then I realized my mistake.

    Here’s the follow-up.

commit 0d68696
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date:   Mon Oct 11 13:17:02 2021 -0400

    [Identity] We had an extra type issue that slipped through our last PR (#18103)

    * [Identity] We had an extra type issue that slipped through our last PR

    * no more async runCommand, and always logging errors

    * Apply suggestions from code review

    Co-authored-by: Will Temple <witemple@microsoft.com>

    * feedback from Will

    Co-authored-by: Will Temple <witemple@microsoft.com>

commit d6c267e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Mon Oct 11 09:45:05 2021 -0700

    Automatic rush update --full (#18013)

commit ef323b7
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date:   Sat Oct 9 14:48:41 2021 +0800

    track2-version-bump (#18111)

    * track2-version-bump

    * update

    * update

commit 25caf58
Author: Renhe Li <renhe.li@hotmail.com>
Date:   Sat Oct 9 11:42:36 2021 +0800

    Update the track 2 migration guide (#18112)

    * Update the track 2 migration guide

    * Minor change of the quote

    * Change the content to fix typo

    Co-authored-by: FAREAST\renhel <renhel@microsoft.com>

commit 5a8cb4c
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date:   Fri Oct 8 19:14:54 2021 -0400

    [Identity] Changes after the architects review (#18072)

    * ApplicationCredential to AzureApplicationCredential

    * Removed the persistence options from DefaultAzureCredential and EnvironmentCredential

    * Merged the configuration and the options bag on the OnBehalfOfCredential

commit 3e3c702
Author: luc <44377201+LuChen-Microsoft@users.noreply.github.com>
Date:   Fri Oct 8 16:03:43 2021 -0700

    export models from signaling client (#18105)

    * export models from signaling client
    * fix lint

commit 33eccef
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Fri Oct 8 14:50:26 2021 -0700

    Avoid overwriting package info properties when dev version is added (#18083)

    Co-authored-by: Praveen Kuttappan <praveen.kuttappan@gmail.com>

commit b9f21d4
Author: Maor Leger <maorleger@users.noreply.github.com>
Date:   Fri Oct 8 14:47:19 2021 -0700

    [KeyVault] - Export KnownKeyExportEncryptionAlgorithm enum (#18104)

    I forgot to re-export these known enums when adding Secure Key Release for Key Vault. This commit just corrects that mistake.

commit 2ee4056
Author: Maor Leger <maorleger@users.noreply.github.com>
Date:   Fri Oct 8 13:24:07 2021 -0700

    [KeyVault] - Update test-resources.json (#18085)

    No functional changes, just refactoring a bit. dotnet recently added their SKR container deployment to the template and made some changes that I want to take into JS.

commit 051d17f
Author: luc <44377201+LuChen-Microsoft@users.noreply.github.com>
Date:   Fri Oct 8 12:27:46 2021 -0700

    Update signaling client (#18068)

    * update signaling client

    * format code

    * fix

    * update api view

    * keep the api same

    * format the code

    * add signaling client options

    * update signaling client

    * format code

    * fix

    * update api view

    * keep the api same

    * format the code

    * add signaling client options

    * fix package

commit 3304363
Author: Maor Leger <maorleger@users.noreply.github.com>
Date:   Fri Oct 8 10:22:59 2021 -0700

    [KeyVault] - Fix key rotation sample (#18100)

    Recent Key Vault service changes for Key Rotation resulted in this sample causing a runtime error. @mccoyp noticed that the
    JS sample is now outdated and would not work with the new validation rules in place.

    To be specific, the validation rules always existed; however, they weren't enforced until recently.

    This commit fixes the sample so that it works again

commit 4e25dba
Author: AriZavala2 <77034370+AriZavala2@users.noreply.github.com>
Date:   Fri Oct 8 10:17:25 2021 -0700

    Making identity optional when getting TURN credentials (#17983)

    * Making identity and communication request optional

    * Add recordings

    * Update PR

    * Fix build issues

    * Fix format

commit a2aebbe
Author: Kevan Yang <58233223+Kevan-Y@users.noreply.github.com>
Date:   Fri Oct 8 10:39:12 2021 -0400

    Add typescript to dictionaries in cspell.json (#17978)

    Fixes #15248
    Add typescript to dictionaries in cspell.json
    Tested by adding `instanceof` in any .md file and run `npx cspell --config .vscode/cspell.json`
    ```
    npx cspell --config .vscode/cspell.json README.md
    1/1 .\README.md 495.98ms X
    c:\Users\User\Desktop\test\azure-sdk-for-js\README.md:55:110 - Unknown word (MSRC)
    c:\Users\User\Desktop\test\azure-sdk-for-js\README.md:55:325 - Unknown word (MSRC)
    CSpell: Files checked: 1, Issues found: 2 in 1 files
    ```

commit b37a332
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date:   Fri Oct 8 17:22:07 2021 +0800

    extendedlocation-track2 (#18092)

commit 966cd8d
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date:   Fri Oct 8 14:20:47 2021 +0800

    eventhub-track2-2021-06-preview (#18088)

    * eventhub-track2-2021-06-preview

    * eventhub-track2-2021-06-preview

    * eventhub-track2-2021-06-preview

    * update package.json

commit d755dba
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date:   Fri Oct 8 11:04:29 2021 +0800

    quota-track2 (#17905)

    * quota-track2

    * update

commit 908df9d
Author: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
Date:   Thu Oct 7 20:21:05 2021 -0400

    Update rush version to latest (#18014)

    * Update rush version to latest

commit db4825b
Author: AlonsoMondal <80124074+AlonsoMondal@users.noreply.github.com>
Date:   Thu Oct 7 14:04:30 2021 -0600

    Preprare communication phone numbers & sms release versions oct 2021 (#18047)

    * preparing release for oct-2021 on communication phone numbers

    * preparing release for oct-2021 on communication sms

commit cacc6c6
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Thu Oct 7 12:31:30 2021 -0700

    Post release automated changes for formrecognizer releases (#18080)

    Post release automated changes for azure-ai-form-recognizer

commit 8871ee0
Author: KarishmaGhiya <kaghiya@microsoft.com>
Date:   Thu Oct 7 12:27:02 2021 -0700

    update versions for monitor-query (#18074)

commit 68abacc
Author: Will Temple <witemple@microsoft.com>
Date:   Thu Oct 7 14:34:48 2021 -0400

    [ai-form-recognizer] Set release date correctly (#18078)

    The release was delayed by a couple of days.

commit b27dcc0
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Thu Oct 7 10:06:14 2021 -0700

    Skip unnecessary and misleading role assignment warnings in local test resource deployment (#18066)

    Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

commit 2a29ea7
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date:   Thu Oct 7 09:06:13 2021 -0400

    [Identity] Migration guide (v1 to v2) (#17796)

    * [Identity] Migration guide

    * Apply suggestions from code review

    Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

    * reference in the README and fixed links

    * Apply suggestions from code review

    Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

    * Feedback by Ramya, and other small polishes

    * removed the service fabric note

    * Separated the changelog entries from the migration guide, and moved to version 2.0.0

    * packages to v2

    * fixed bad link -- though these Troubleshooting links wont work until Karishmas PR is merged

    * Mentioning the lack of Service Fabric support

    * improvements after thorough reading

    * Update sdk/identity/identity/migration-v1-v2.md

    Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>

    * improved the CHANGELOG and the migration guide

    * using the caret

    * all seems good now

    * Update CHANGELOG.md

    * Update CHANGELOG.md

    * Small changes around RegionalAuthority

    * Apply suggestions from code review

    Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

    * Apply suggestions from code review

    Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>

    * addressed more of the feedback

    * Removed references to RegionalAuthorities

    * moved network change out of breaking changes

    * Apply suggestions from code review

    Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>

    * [Identity] Disabling regional authority support (#18026)

    * [Identity] Disabling regional authority support

    * feedback from Scott Schaab

    * [ai-form-recognizer] Merge 4.0.0-beta.1 (#18036)

    * Obliterate existing FR SDK for clean history

    * [ai-form-recognizer] Migrate Form Recognizer SDK work to public repo. (#17955)

    * Migrate Form Recognizer SDK work to public repo.

    * Fixed a couple of little things in the source.

    * Updated README and CHANGELOG

    * Use latest swagger

    * Updated CHANGELOG

    * Some more fixes

    * WIP Migration Guide

    * README fixes

    * Renamed common options type

    * Apply suggestions from code review

    * Update CHANGELOG

    * Fixed TypeScript version mismatch in dev-tool.

    * re-recorded tests and enabled AAD

    * Updated skip list

    * added summaries to all samples

    * Updated skip list

    * Updated doc string

    * Pick internal/hidden

    * Generated camera-ready samples

    * Extend migration guide

    * Fix link

    Co-authored-by: Will Temple <will@wtemple.net>

    Co-authored-by: Will Temple <will@wtemple.net>

    * Post release automated changes for keyvault releases (#18034)

    Post release automated changes for azure-keyvault-keys

    * [Schema Registry] Update changelog (#18041)

    * [Azure Monitor OpenTelemetry Exporter]Update changelog for 1.0.0-beta.5 release (#18038)

    * Update changelog

    * Update sdk/monitor/monitor-opentelemetry-exporter/CHANGELOG.md

    Co-authored-by: KarishmaGhiya <kghiya8@gmail.com>

    * Update sdk/monitor/monitor-opentelemetry-exporter/CHANGELOG.md

    Co-authored-by: KarishmaGhiya <kghiya8@gmail.com>

    * Format

    Co-authored-by: KarishmaGhiya <kghiya8@gmail.com>

    * fix sample on readme (#18022)

    * [EventGrid] Update System Events, Prepare for Release (#17977)

    Update our swagger reference commit to pull in some new system events
    and add them to our mappings.

    * Handle multiple segments in service directory path (#18015)

    Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

    * Post release automated changes for azure-service-bus (#18045)

    * [Synapse Artifacts] Re generate for October Release (#17981)

    * Update synapse artifacts

    * Undo recording changes

    * Update changelog

    * update recordings

    * Update changelog

    * Remove .deb file

    * Revert change back (#18040)

    Reverts back to a version that does not have mysterious Credential Issue

    Co-authored-by: Sean Kane <68240067+seankane-msft@users.noreply.github.com>

    * [Schema Registry] Edit readme (#18048)

    * Re-enable api extractor when building abort-controller (#17986)

    This PR re-enables the use of api extractor in the build step for the abort-controller package.
    I no longer see the problems reported in #10320

    Fixes #10320

    * [Synapse Spark] Regenerate with latest release tag package-spark-2020-12-01 (#17980)

    * Regenerate with latest release tag package-spark-2020-12-01

    * Update changelog

    * Post release automated changes for schemaregistry releases (#18051)

    Post release automated changes for azure-schema-registry-avro

    * Reduce test scope for test-utils pipeline (#18046)

    * Reduce test scope for test-utils pipeline

    * Post release automated changes for eventgrid releases (#18050)

    Post release automated changes for azure-eventgrid

    * [Schema Registry] Post release automation (#18052)

    * [Schema Registry] Post release automation

    * bump SR dep ver

    * update changelog

    * [Identity] Caught up with POD Identity fix added on 1.5.1 (#18054)

    * remaining feedback from Ramya

    * removed references to the troubleshooting guide

    * Update sdk/identity/identity/CHANGELOG.md

    Co-authored-by: Harsha Nalluru <sanallur@microsoft.com>

    * added a placeholder for the Troubleshooting.md file

    * Update sdk/identity/identity/CHANGELOG.md

    Co-authored-by: Harsha Nalluru <sanallur@microsoft.com>

    * last references to Identity 2.0.0-beta.7

    * Fixed 2.0.0-beta.7 reference in monitor-query perf tests

    Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
    Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
    Co-authored-by: Will Temple <witemple@microsoft.com>
    Co-authored-by: Will Temple <will@wtemple.net>
    Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
    Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
    Co-authored-by: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com>
    Co-authored-by: KarishmaGhiya <kghiya8@gmail.com>
    Co-authored-by: KarishmaGhiya <kaghiya@microsoft.com>
    Co-authored-by: Matt Ellis <matell@microsoft.com>
    Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
    Co-authored-by: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
    Co-authored-by: Sean Kane <68240067+seankane-msft@users.noreply.github.com>
    Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
    Co-authored-by: Harsha Nalluru <sanallur@microsoft.com>

commit 2bb7759
Author: KarishmaGhiya <kaghiya@microsoft.com>
Date:   Wed Oct 6 23:29:37 2021 -0700

    remove audience support for GA release (#18071)

commit 751d92f
Author: Mike Harder <mharder@microsoft.com>
Date:   Wed Oct 6 17:42:13 2021 -0700

    [Perf] Storage test updates (#18070)

    - Update dependencies to latest non-beta source version
    - Align tsconfig.json with storage-blob perf test
      - "target: es5" fails with "TypeError: Class constructor PerfStressTest cannot be invoked without 'new'"

commit d54a817
Author: Mike Harder <mharder@microsoft.com>
Date:   Wed Oct 6 16:13:49 2021 -0700

    [Perf Framework] Support multiple test proxies (#18031)

commit 5022248
Author: Will Temple <witemple@microsoft.com>
Date:   Wed Oct 6 15:35:13 2021 -0400

    [dev-tool] Use host package's TypeScript in module loader. (#18064)

    * [dev-tool] Use host package's TypeScript in module loader.

    * Made it just a little bit smarter

commit a3d8612
Author: KarishmaGhiya <kaghiya@microsoft.com>
Date:   Wed Oct 6 11:17:08 2021 -0700

    Perf tests for monitor query (#18063)

commit 1c4d060
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Wed Oct 6 10:30:29 2021 -0700

    Add devops variable setting/clearing to eng/common (#18055)

    Co-authored-by: Daniel Jurek <djurek@microsoft.com>

commit 524edff
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Wed Oct 6 09:33:34 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 2064 (#18059)

commit 50ba79c
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date:   Tue Oct 5 20:38:19 2021 -0400

    [Identity] Caught up with POD Identity fix added on 1.5.1 (#18054)

commit 906cecf
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date:   Tue Oct 5 20:30:32 2021 -0400

    [Schema Registry] Post release automation (#18052)

    * [Schema Registry] Post release automation

    * bump SR dep ver

    * update changelog

commit a97f5e4
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Tue Oct 5 16:06:18 2021 -0700

    Post release automated changes for eventgrid releases (#18050)

    Post release automated changes for azure-eventgrid

commit 85b0bf2
Author: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
Date:   Tue Oct 5 18:21:06 2021 -0400

    Reduce test scope for test-utils pipeline (#18046)

    * Reduce test scope for test-utils pipeline

commit 542c496
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Tue Oct 5 14:17:47 2021 -0700

    Post release automated changes for schemaregistry releases (#18051)

    Post release automated changes for azure-schema-registry-avro

commit 284ec8a
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date:   Tue Oct 5 15:45:31 2021 -0500

    [Synapse Spark] Regenerate with latest release tag package-spark-2020-12-01 (#17980)

    * Regenerate with latest release tag package-spark-2020-12-01

    * Update changelog

commit 953c143
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date:   Tue Oct 5 13:37:05 2021 -0700

    Re-enable api extractor when building abort-controller (#17986)

    This PR re-enables the use of api extractor in the build step for the abort-controller package.
    I no longer see the problems reported in #10320

    Fixes #10320

commit f331495
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date:   Tue Oct 5 16:13:41 2021 -0400

    [Schema Registry] Edit readme (#18048)

commit e439174
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Tue Oct 5 13:10:43 2021 -0700

    Revert change back (#18040)

    Reverts back to a version that does not have mysterious Credential Issue

    Co-authored-by: Sean Kane <68240067+seankane-msft@users.noreply.github.com>

commit d8f499a
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date:   Tue Oct 5 15:09:57 2021 -0500

    [Synapse Artifacts] Re generate for October Release (#17981)

    * Update synapse artifacts

    * Undo recording changes

    * Update changelog

    * update recordings

    * Update changelog

    * Remove .deb file

commit 311a6ac
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Tue Oct 5 12:45:40 2021 -0700

    Post release automated changes for azure-service-bus (#18045)

commit 7154ded
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Tue Oct 5 11:55:44 2021 -0700

    Handle multiple segments in service directory path (#18015)

    Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

commit b1a914e
Author: Matt Ellis <matell@microsoft.com>
Date:   Tue Oct 5 11:51:25 2021 -0700

    [EventGrid] Update System Events, Prepare for Release (#17977)

    Update our swagger reference commit to pull in some new system events
    and add them to our mappings.

commit d38c812
Author: KarishmaGhiya <kaghiya@microsoft.com>
Date:   Tue Oct 5 11:04:44 2021 -0700

    fix sample on readme (#18022)

commit 927f225
Author: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com>
Date:   Tue Oct 5 11:04:31 2021 -0700

    [Azure Monitor OpenTelemetry Exporter]Update changelog for 1.0.0-beta.5 release (#18038)

    * Update changelog

    * Update sdk/monitor/monitor-opentelemetry-exporter/CHANGELOG.md

    Co-authored-by: KarishmaGhiya <kghiya8@gmail.com>

    * Update sdk/monitor/monitor-opentelemetry-exporter/CHANGELOG.md

    Co-authored-by: KarishmaGhiya <kghiya8@gmail.com>

    * Format

    Co-authored-by: KarishmaGhiya <kghiya8@gmail.com>

commit 885f106
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date:   Tue Oct 5 13:54:04 2021 -0400

    [Schema Registry] Update changelog (#18041)

commit 58330f0
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Tue Oct 5 10:02:54 2021 -0700

    Post release automated changes for keyvault releases (#18034)

    Post release automated changes for azure-keyvault-keys

commit bf37377
Author: Will Temple <witemple@microsoft.com>
Date:   Tue Oct 5 12:23:32 2021 -0400

    [ai-form-recognizer] Merge 4.0.0-beta.1 (#18036)

    * Obliterate existing FR SDK for clean history

    * [ai-form-recognizer] Migrate Form Recognizer SDK work to public repo. (#17955)

    * Migrate Form Recognizer SDK work to public repo.

    * Fixed a couple of little things in the source.

    * Updated README and CHANGELOG

    * Use latest swagger

    * Updated CHANGELOG

    * Some more fixes

    * WIP Migration Guide

    * README fixes

    * Renamed common options type

    * Apply suggestions from code review

    * Update CHANGELOG

    * Fixed TypeScript version mismatch in dev-tool.

    * re-recorded tests and enabled AAD

    * Updated skip list

    * added summaries to all samples

    * Updated skip list

    * Updated doc string

    * Pick internal/hidden

    * Generated camera-ready samples

    * Extend migration guide

    * Fix link

    Co-authored-by: Will Temple <will@wtemple.net>

    Co-authored-by: Will Temple <will@wtemple.net>

commit f211c2a
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date:   Mon Oct 4 21:11:38 2021 -0400

    [Identity] Disabling regional authority support (#18026)

    * [Identity] Disabling regional authority support

    * feedback from Scott Schaab

commit a8021f5
Author: Harsha Nalluru <sanallur@microsoft.com>
Date:   Mon Oct 4 17:33:55 2021 -0700

    [Service Bus] Fix live test failure (#18027)

    * changelog

    * fix test

    * remove .only

commit c7f39c1
Author: Harsha Nalluru <sanallur@microsoft.com>
Date:   Mon Oct 4 16:08:27 2021 -0700

    [Service Bus] Release 7.4.0-beta.1 (#18024)

    * changelog

    * 7.4.0-beta.1

commit e099b12
Author: Harsha Nalluru <sanallur@microsoft.com>
Date:   Mon Oct 4 15:39:29 2021 -0700

    [Unified Recorder] TestProxyClient takes test context to generate recordings at desired location (#17388)

    * TestProxyClient takes test context to generate recordings at desired location

    * set /workspaces/azure-sdk-for-js/ as entry point

    * use Test as testContext type

    * update recorder-new tests

    * update tests with before and after each

    * relativePathCalculator - for browser => done

    * create utils folder

    * export relativeRecordingsPathForBrowser to use in karma.conf

    * utils folder updates

    * RECORDINGS_RELATIVE_PATH env variable in karma.conf

    * node side draft

    * relativeRecordingsPathForNode

    * findRecordingsFolderPath

    * remove console.logs

    * Update sdk/test-utils/recorder-new/README.md

    * throw new Error(
              "Unable to determine the recording file path, testContext provided is not defined."
            );

    * Update sdk/test-utils/recorder-new/README.md

    * lock file

    * --net=host docs

    * sample recordings

    * refactor existing tests

    * server and tests hitting the server

    * unrelated changes in package.json

    * changelog

    * lock file

    * Jeremy's feedbackl

    * lock file

    * lock file

    * Update sdk/test-utils/recorder-new/README.md

    Co-authored-by: Will Temple <witemple@microsoft.com>

    * Update sdk/test-utils/recorder-new/README.md

    Co-authored-by: Will Temple <witemple@microsoft.com>

    * readme

    * removing the exclamations. 🙂

    * address feedback

    * clientHttpClient

    * sample recordings

    * relativeRecordingsPathForBrowser -> relativeRecordingsPath

    * massive update to relativeRecordingsPath - which works fine on linux

    * RECORDINGS_RELATIVE_PATH in karma.conf

    * dist-esm/test/index.spec.js doesn't exist

    * lock file

    * updates for windows

    * `--add-host host.docker.internal:host-gateway`

    * more comments

    * remove unintended file

    * Update sdk/test-utils/recorder-new/CHANGELOG.md

    Co-authored-by: Daniel Rodríguez <sadasant@users.noreply.github.com>

    * remove sq brackets

    Co-authored-by: Will Temple <witemple@microsoft.com>
    Co-authored-by: Daniel Rodríguez <sadasant@users.noreply.github.com>

commit 0e569b5
Author: Harsha Nalluru <sanallur@microsoft.com>
Date:   Mon Oct 4 15:03:02 2021 -0700

    [Service Bus] Release 7.3.1-beta.1 (#18020)

commit fddd527
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date:   Mon Oct 4 18:02:23 2021 -0400

    [Schema Registry] Edit readme (#18019)

commit 223e285
Author: Mike Harder <mharder@microsoft.com>
Date:   Mon Oct 4 14:51:15 2021 -0700

    [Perf] Update keyvault-secrets test to match .NET (#17799)

    - Move single-secret code from SecretTest to GetSecretTest
    - Ensure vault contains 0 secrets before ListSecretsTest
    - Delete and purge all created secrets

commit c2a25c7
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date:   Mon Oct 4 16:52:18 2021 -0400

    [Schema Registry] Return undefined on 404 codes (#18018)

commit 520db84
Author: Maor Leger <maorleger@users.noreply.github.com>
Date:   Mon Oct 4 13:47:00 2021 -0700

    [KeyVault] - Add information about SKR live tests (#18016)

commit 7548d72
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date:   Mon Oct 4 16:23:15 2021 -0400

    [Identity] Fixes after manual tests (#18011)

    * AzureCLI fix and better comments

    * several improvements

commit 73bc2bc
Author: Ben Broderick Phillips <bebroder@microsoft.com>
Date:   Mon Oct 4 12:51:19 2021 -0400

    Remove canary test matrix node verison filter (#17976)

commit 95d8136
Author: Hiroshi Yoshioka <40815708+hyoshioka0128@users.noreply.github.com>
Date:   Tue Oct 5 01:45:53 2021 +0900

    Cosmos readme: Typo "Typescript"→"TypeScript" (#17988)

commit 2186357
Author: Mike Harder <mharder@microsoft.com>
Date:   Fri Oct 1 17:31:51 2021 -0700

    [Perf] Call runAsync() once before starting recording (#17993)

    - Avoids capturing one-time setup like authorization requests
    - Adds ServiceClientGetTest for directly testing the core-client features

commit adf7cf9
Author: Sarangan Rajamanickam <sarajama@microsoft.com>
Date:   Fri Oct 1 15:08:05 2021 -0700

    Upgrade search-documents SDK to core-rest-pipeline (#17872)

    * Upgrade search-documents SDK to core-rest-pipeline

    * Updated recordings

    * Fix linting

    * Updated Recordings

    * Updated Recordings II

    * Additional Changes

    * Some More changes

    * Fix odataMetadata Policy

    * Minor change

    * Additional Changes

    * Additional Changes

    * Update Commit Ids

    * Update Changelog

    * Remove dependency of core-http completely

    * Minor Change

commit a2c6d2e
Author: KarishmaGhiya <kaghiya@microsoft.com>
Date:   Fri Oct 1 14:07:51 2021 -0700

    update the error handling for Logs Query and Logs Query Batch (#17965)

    Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

commit b7735dd
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Fri Oct 1 14:04:33 2021 -0700

    Update docker-start-proxy.ps1 (#17991)

    Update to the latest version of the container

    Co-authored-by: Sean Kane <68240067+seankane-msft@users.noreply.github.com>

commit 04a1f58
Author: Jeremy Meng <yumeng@microsoft.com>
Date:   Fri Oct 1 13:44:50 2021 -0700

    Add newline after comments in rush.json (#17912)

    to make it easier to `grep -v` comment lines and get valid json.

commit 497cfde
Author: Maor Leger <maorleger@users.noreply.github.com>
Date:   Fri Oct 1 10:15:09 2021 -0700

    Update CHANGELOG for KV October release (#17970)

commit 0815972
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date:   Fri Oct 1 12:56:53 2021 -0400

    [Identity] Fixing types on the Kubernetes manual test (#17910)

    * [Identity] Fixing types on the Kubernetes manual test

    * string | unknown -> unknown

    * awaiting L88

commit 0456250
Author: Liangying.Wei <lianwei@microsoft.com>
Date:   Sat Oct 2 00:27:32 2021 +0800

    Fix eslint for wps express (#17962)

    * Fix eslint for wps express

    * fix format failure

commit afff61b
Author: Harsha Nalluru <sanallur@microsoft.com>
Date:   Thu Sep 30 18:00:27 2021 -0700

    [Service Bus] Support MaxMessageSizeInKilobytes (#17953)

    * Fix retry handling for Session Not Found errors

    * Update sdk/cosmosdb/cosmos/test/internal/session.spec.ts

    Co-authored-by: Zachary Foster <zfoster@users.noreply.github.com>

    * Update CODEOWNERS for Application Insights (#17055)

    * MaxMessageSizeInKilobytes api

    * sample,test.env

    * API Report

    * add tests

    * finish the tests

    * remove console.log

    * arm template

    * put .only to test in CI with limited tests

    * minor test update

    * remove .only, add changelog

    * Update sdk/servicebus/service-bus/src/util/constants.ts

    Co-authored-by: chradek <51000525+chradek@users.noreply.github.com>

    * wrap text - changelog

    * maxMessageSizeInKilobytes: 256 by default for Standard namespaces

    * Revert "maxMessageSizeInKilobytes: 256 by default for Standard namespaces"

    This reverts commit 4f42563.

    * exclude "maxMessageSizeInKilobytes"

    * (Configurable only for Premium Tier Service Bus namespace.)

    * Version 7.3.1-beta.1

    * update version at more places

    * lock file

    * Update sdk/servicebus/service-bus/CHANGELOG.md

    Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>

    * lock file

    * non optional in EntityProperties

    * api report

    Co-authored-by: Steve Faulkner <southpolesteve@gmail.com>
    Co-authored-by: Zachary Foster <zfoster@users.noreply.github.com>
    Co-authored-by: omziv <80668253+omziv@users.noreply.github.com>
    Co-authored-by: chradek <51000525+chradek@users.noreply.github.com>
    Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>

commit f5f8524
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date:   Thu Sep 30 19:22:32 2021 -0400

    small improvements (#17979)

commit 7084ffb
Author: Harsha Nalluru <sanallur@microsoft.com>
Date:   Thu Sep 30 13:21:21 2021 -0700

    [Perf Framework] Allow connecting to the proxy-tool with https too (#17898)

    * checkpoint - reject unauth

    * rejectUnauthorized: false

    * remove console.logs

    * -p 5001:5001 port in docs

    * httpsAgent

    * revert redundancy

    * gettiong started commands update

    * add insecure option and booleanoptions bug fix

    * getCachedHttpsAgent

    * changelog

    * request.allowInsecureConnection = this._uri.startsWith("http:");

commit 0d02174
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Thu Sep 30 13:15:27 2021 -0700

    Post release automated changes for core releases (#17974)

    Post release automated changes for azure-core-http

commit de8e547
Author: Jeff Fisher <jeffish@microsoft.com>
Date:   Thu Sep 30 11:42:38 2021 -0700

    [core-rest-pipeline] Fix race condition in aborting request on Node (#17956)

    Address an issue on Node where if we were still reading a response while an abort signal was triggered, the AbortError wouldn't be surfaced properly and instead a RestError would be raised.

commit ff2f53c
Author: Harsha Nalluru <sanallur@microsoft.com>
Date:   Thu Sep 30 10:01:37 2021 -0700

    [App Config] update sync-token docs url from 404 to a valid url (#17960)

commit e219c0a
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date:   Thu Sep 30 10:40:47 2021 -0500

    [Rest Client] Purview administration (#17875)

    * Initial POC for multi client rest package

    * Rush and lock

    * Format and lint

    * Update CI

    * Use modules

    * Update lock

    * update links

    * Address PR comments

    * Remove locale from links

    * Update recordings

    * Update changelog and recordings

    * Update lint rules

    * FIx format

commit 9dc6167
Author: Maor Leger <maorleger@users.noreply.github.com>
Date:   Thu Sep 30 08:07:26 2021 -0700

    Update API Extractor for all packages (#17917)

    ## What

    - Update API Extractor to the latest version (currently 7.18.11)
    - Regenerate all API reviews by building all the packages

    ## Why

    This is something we keep bumping into. First, we needed to upgrade API Extractor to allow us to re-export directly from
    `@opentelemetry/api`. Then, it looks like we needed this to upgrade TypeScript to 4.4.

    We are way behind on this version, and it's time to upgrade.

    ## Callouts

    How noisy is this?! Here's what's happening - somewhere around 7.9 I think API Extractor improved the way it detects name
    collisions with predefined globals. Things like KeyType, Response, etc.

    If there's a clash, the generated API markdown file will rename <Item> to <Item_2> to make the name collision explicit.

    Talking to folks on the team, and the poor souls that will be doing API Review approvals, we agreed that doing the upgrade
    in one fell swoop is the way to go.

    Resolves #9410

commit 4aeb47a
Author: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com>
Date:   Wed Sep 29 17:27:35 2021 -0700

    [OpenTelemetry Exporter] Update AI mapping with latest spec changes (#17916)

    * Update with latest mapping spec

    * Format

commit 0dea73f
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date:   Wed Sep 29 20:16:32 2021 -0400

    [Schema Registry Avro] make schema group optional (#17922)

    * [Schema Registry Avro] make schema group optional

    * update the changelog

    * address feedback

commit 3ebdf60
Author: Jeremy Meng <yumeng@microsoft.com>
Date:   Wed Sep 29 16:59:58 2021 -0700

    [core-http] Prepare CHANGELOG for Oct. release (#17958)

commit 1ffd8dd
Author: chradek <51000525+chradek@users.noreply.github.com>
Date:   Wed Sep 29 16:35:04 2021 -0700

    [core] prepare core packages for release (#17957)

commit fd3faee
Author: chradek <51000525+chradek@users.noreply.github.com>
Date:   Wed Sep 29 15:47:45 2021 -0700

    Unblock react native support when using corev2 packages (#17783)

    ~This is a WIP. Currently these changes, along with a shims file, allows our packages that depend on core-client to run in react native.~

    ~ToDo: I've created expo and react-native cli projects that illustrate what shims are needed to get this working. Currently working on getting those samples into this PR.~

    This PR has been updated to just include making the changes needed for the corev2 packages to run in react native, assuming that the requisite browser APIs are pollyfilled.

commit 5d9f840
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date:   Wed Sep 29 18:41:46 2021 -0400

    [Identity] Removed allowMultiTenantAuthentication (#17915)

    * [Identity] Removed allowMultiTenantAuthentication

    * small changelog improvement

    * review file

    * adfs error message

commit 584693d
Author: KarishmaGhiya <kaghiya@microsoft.com>
Date:   Wed Sep 29 13:19:57 2021 -0700

    Monitor query test enable browser and recordings (#17897)

commit af719ec
Author: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Date:   Wed Sep 29 13:53:59 2021 -0500

    Apply Monitor Query READMEfile updates (#17933)

commit 576f2b2
Author: Chidozie Ononiwu (His Righteousness) <31145988+chidozieononiwu@users.noreply.github.com>
Date:   Wed Sep 29 11:32:38 2021 -0700

    Add policheck to CI run, update policheck steps with common template (#17859)

commit da46250
Author: AlonsoMondal <80124074+AlonsoMondal@users.noreply.github.com>
Date:   Wed Sep 29 11:08:50 2021 -0600

    Modifying codeowners file to reflect SDK handoff for communication SMS & Phone Numbers (#17935)

commit b8409f9
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Wed Sep 29 07:05:16 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 2046 (#17911)

    * Pass package name from calling pipeline to uniquely identify pull request review

    * Update log summary

    * Update eng/common/scripts/Detect-Api-Changes.ps1

    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

    Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
    Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

commit 632629c
Author: KarishmaGhiya <kaghiya@microsoft.com>
Date:   Tue Sep 28 18:50:44 2021 -0700

    Api Consistency Review feedback (#17873)

commit 49f8480
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date:   Tue Sep 28 19:21:39 2021 -0400

    [Schema Registry] Rename definition to schemaDefinition (#17919)

    * [Schema Registry] Rename definition to schemaDefinition

    * rename endpoint to fullyQualifiedNamespace

    * rename endpoint everywhere

    * more renamings

    * renames in the avro lib

    * unpublish samples

    * unpublish samples

commit 0ad4ea3
Author: Maor Leger <maorleger@users.noreply.github.com>
Date:   Tue Sep 28 13:32:17 2021 -0700

    [KeyVault] - Add key_ops to JWK and deprecate keyOps (#17914)

    ## What

    - Add `key_ops` to `JsonWebKey` model
    - Mark `keyOps` as deprecated in `JsonWebKey`

    ## Why

    As per [IETF rfc7517](https://datatracker.ietf.org/doc/html/rfc7517#section-4.3) the correct name for this field is `key_ops`... our TypeScript codegen will of course camelCase this
    but snake_case is the expected convention.

    I am only marking `keyOps` as deprecated in the JWK, and of course we will continue to populate it for 4.x, but this will
    allow anyone to take the key material and use it where a JWK is expected without any conversions.

    Resolves #17721

commit ffd13c1
Author: Vishnu Reddy <vishnureddy@microsoft.com>
Date:   Tue Sep 28 10:13:29 2021 -0700

    Update CODEOWNERS for Digital twins (#17908)

commit 9c33c97
Author: Maor Leger <maorleger@users.noreply.github.com>
Date:   Tue Sep 28 09:41:04 2021 -0700

    [Governance] - Update tar to latest patch (#17909)

commit 8eba05d
Author: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
Date:   Tue Sep 28 11:30:06 2021 -0400

    Publish api json file and enable api change detection (#17837)

    * Publish api file and enable api change detection

commit 740a343
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date:   Tue Sep 28 17:11:00 2021 +0800

    eventgrid-track2 (#17904)

    * eventgrid-track2

    * update ci.yml

commit 61a4560
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Tue Sep 28 01:29:25 2021 -0700

    Post release automated changes for redis releases (#17903)

    Post release automated changes for azure-arm-rediscache

commit 5ce2c7b
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date:   Tue Sep 28 14:29:30 2021 +0800

    redis-track2 (#17900)

    * redis-track2

    * update

commit 5cca66b
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date:   Mon Sep 27 19:46:54 2021 -0400

    [Schema Registry] Enable min/max testing (#17854)

    * [Schema Registry] Enable min/max testing

    * address feedback

    * add integration tests scripts

    * remove index

    * remove the import of OperationOptions

commit fed1cb1
Author: Peter Marcu <Petermarcu@hotmail.com>
Date:   Mon Sep 27 14:33:26 2021 -0700

    Simply say this repo contains all libraries. (#17863)

commit e4408ed
Author: ckairen <38804567+ckairen@users.noreply.github.com>
Date:   Mon Sep 27 14:32:09 2021 -0700

    Fixing nightly run smoke test (#17791)

    * Fixing nightly run smoke test

    * PR mod

    * condition modification

    * pr-mod
  • Loading branch information
@zihzhan-msft
zihzhan-msft committed Oct 13, 2021
1 parent 68a6fa2 commit f46a54a
Show file tree
Hide file tree
Showing 1,356 changed files with 105,092 additions and 77,914 deletions.
6 changes: 3 additions & 3 deletions .github/CODEOWNERS
View file
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@
# PRLabel: %Communication
/sdk/communication/communication-identity/ @Azure/acs-identity-sdk
/sdk/communication/communication-chat/ @LuChen-Microsoft
/sdk/communication/communication-phone-numbers/ @miguhern
/sdk/communication/communication-phone-numbers/ @miguhern @danielav7 @whisper6284 @AlonsoMondal
/sdk/communication/communication-network-traversal/ @AriZavala2
/sdk/communication/communication-sms/ @RoyHerrod
/sdk/communication/communication-sms/ @RoyHerrod @arifibrahim4
/sdk/communication/communication-common/ @Azure/acs-identity-sdk

# PRLabel: %Container Registry
Expand All @@ -48,7 +48,7 @@
/sdk/cosmosdb/ @kushagraThapar @simorenoh @simplynaveen20 @xinlian12 @moderakh

# PRLabel: %Digital Twins
/sdk/digitaltwins/ @vishnureddy17
/sdk/digitaltwins/ @johngallardo

# PRLabel: %Event Grid
/sdk/eventgrid/ @xirzec @ellismg
Expand Down
2 changes: 1 addition & 1 deletion .vscode/cspell.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"version": "0.1",
"language": "en",
"languageId": "typescript,javascript",
"dictionaries": ["powershell"],
"dictionaries": ["powershell", "typescript"],
"ignorePaths": [
"**/node_modules/**",
"**/recordings/**",
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

[![Packages](https://img.shields.io/badge/packages-latest-blue.svg)](https://azure.github.io/azure-sdk/releases/latest/js.html) [![Dependencies](https://img.shields.io/badge/dependency-report-blue.svg)](https://azuresdkartifacts.blob.core.windows.net/azure-sdk-for-js/dependencies/dependencies.html) [![DependencyGraph](https://img.shields.io/badge/dependency-graph-blue.svg)](https://azuresdkartifacts.blob.core.windows.net/azure-sdk-for-js/dependencies/InterdependencyGraph.html)

This repository is for the Azure SDK for JavaScript (Node.js & Browser). It contains the management libraries for all Azure services and client libraries for a growing subset of Azure services. Management libraries are packages that you would use to provision and manage Azure resources. Client libraries are packages that you would use to consume these resources and interact with them.
This repository is for the Azure SDK for JavaScript (Node.js & Browser). It contains libraries for the breadth of Azure services. Management libraries are packages that you would use to provision and manage Azure resources. Client libraries are packages that you would use to consume these resources and interact with them.

## Getting started

Expand Down
8 changes: 4 additions & 4 deletions common/scripts/install-run-rush.js
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion common/scripts/install-run.js
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions common/tools/dev-tool/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"prettier": "^1.16.4",
"ts-node": "^10.0.0",
"tslib": "^2.2.0",
"typescript": "~4.2.0",
"typescript": "~4.4.0",
"yaml": "~1.10.0"
},
"devDependencies": {
Expand All @@ -71,7 +71,6 @@
"rollup": "^1.16.3",
"rollup-plugin-sourcemaps": "^0.4.2",
"rollup-plugin-visualizer": "^4.0.4",
"typedoc": "0.15.2",
"typescript": "~4.2.0"
"typedoc": "0.15.2"
}
}
11 changes: 7 additions & 4 deletions common/tools/dev-tool/register.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,20 @@
*/

const path = require("path");

const ts = require("typescript");

const cwd = process.cwd();

// This is the calling module, which will be the node repl context.
const main = module.parent;
const main = require.main || module.parent;

// We need to know which package name to monkey patch
const { name: hostPackageName } = main.require("./package.json");

// We need to use whatever version of TypeScript the calling package uses to inspect syntax nodes, because
// that is what the ts-node invocation will use, and we need to agree with it on syntax brands.
const ts = hostPackageName === "@azure/dev-tool"
? require(path.join(cwd, "node_modules", "typescript"))
: main.require("typescript");

// If we're bootstrapping a dev-tool command, we need to patch the package from
// CWD instead. This will still end up being dev-tool if we end up in a
// self-hosting situation where dev-tool calls itself from its own scripts.
Expand Down
16 changes: 12 additions & 4 deletions common/tools/dev-tool/src/commands/samples/publish.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -199,10 +199,16 @@ async function processSources(
if (summary === undefined) {
for (const tag of tags) {
log.debug(`File ${relativeSourcePath} has tag ${tag.tagName.text}`);

// New TS introduced comment: NodeArray, so we join the text if it is made of many nodes.
const comment = Array.isArray(tag.comment)
? tag.comment.map((node: ts.JSDocText) => node.text ?? " ").join(" ")
: (tag.comment as string | undefined);

if (tag.tagName.text === "summary") {
log.debug("Found summary tag on node:", node.getText(sourceFile));
// Replace is required due to multi-line splitting messing with table formatting
summary = tag.comment?.replace(/\s*\r?\n\s*/g, " ");
summary = comment?.replace(/\s*\r?\n\s*/g, " ");
} else if (tag.tagName.text.startsWith(`${AZSDK_META_TAG_PREFIX}`)) {
// We ran into an `azsdk` directive in the metadata
const metaTag = tag.tagName.text.replace(
Expand All @@ -211,11 +217,13 @@ async function processSources(
) as keyof AzSdkMetaTags;
log.debug(`File ${relativeSourcePath} has azsdk tag ${tag.tagName.text}`);
if (VALID_AZSDK_META_TAGS.includes(metaTag)) {
const comment = tag.comment?.trim();
const trimmedComment = comment?.trim();
// If there was _no_ comment, then we can assume it is a boolean tag
// and so being specified at all is an indication that we should use
// `true`
azSdkTags[metaTag as keyof AzSdkMetaTags] = comment ? JSON.parse(comment) : true;
azSdkTags[metaTag as keyof AzSdkMetaTags] = trimmedComment
? JSON.parse(trimmedComment)
: true;
} else {
log.warn(
`Invalid azsdk tag ${metaTag}. Valid tags include ${VALID_AZSDK_META_TAGS}`
Expand Down Expand Up @@ -578,7 +586,7 @@ export default leafCommand(commandInfo, async (options) => {
return factory(basePath);
});
} catch (ex) {
log.error(ex.message);
log.error((ex as Error).message);
return false;
}

Expand Down
2 changes: 1 addition & 1 deletion common/tools/dev-tool/src/commands/samples/run.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ async function runSingle(name: string, accumulatedErrors: Array<[string, string]
await sampleMain();
}
} catch (err) {
const truncatedError: string = err
const truncatedError: string = (err as Error)
.toString()
.split("\n")[0]
.slice(0, 100);
Expand Down
29 changes: 15 additions & 14 deletions documentation/MIGRATION-guide-for-next-generation-management-libraries.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,26 +4,27 @@ This document is intended to show the customers of the JavaScript/TypeScript man

**For new customers of the JavaScript/TypeScript SDK ([azure-sdk-for-js](https://github.com/Azure/azure-sdk-for-js)) please see [quick start for next generation](https://github.com/Azure/azure-sdk-for-js/blob/main/documentation/next-generation-quickstart.md).**

## Why switch to the next-generation
## Current status

Compared to the current management libraries, the next-generation has the following changes:
Currently, we have previewed several packages such as `azure/arm-resources`, `@azure/arm-storage`, `@azure/arm-compute`, `@azure/arm-network` for next-generation. See more from npmjs.com and find the latest version under `next` tag and have a try.

1. Authentication: The packages `@azure/ms-rest-nodeauth` or `@azure/ms-rest-browserauth` are no longer supported. Use package [@azure/identity](https://www.npmjs.com/package/@azure/identity) instead. Select a credential from Azure Identity examples based on the authentication method of your choice
1. Callbacks: Method overloads that used callbacks have been removed and the use of promises is encouraged instead
1. List operations now return an iterable result that follows the `PagedAsyncIterableIterator` interface as opposed to the previous model where you had to make a new request using the link to the next page.
1. Long running operations i.e. the Lro related object returned by methods whose names started with `begin`, now uses `pollUntilDone` to check whether the request is finished, instead of `pollUntilFinished`. To get the final result, use the corresponding method that will have the suffix `AndWait`.
1. The SDK only supports ECMAScript 2015 (ES6) and beyond, all projects that referenced this SDK should be upgraded to use ES6.
## Why Switching to the next-generation

If you have an existing application that uses the JavaScript/TypeScript Azure SDK packages and you're interested in updating your application to use the next-generation JavaScript/TypeScript Azure SDK packages, then the good news is that there is very little for you to do. Here's the things that have changed with this new set of SDKs:
Compared to the current management libraries, the next-generation libraries have the following changes:

## Current status
1. Authentication: The packages `@azure/ms-rest-nodeauth` or `@azure/ms-rest-browserauth` are no longer supported. Use package [@azure/identity](https://www.npmjs.com/package/@azure/identity) instead. Select a credential from Azure Identity examples based on the authentication method of your choice.
1. Callbacks: Method overloads that use callbacks have been removed and please use Promise instead.
1. You could iterate the result of List operations by using the `PagedAsyncIterableIterator` interface, compared with in previous model, you have to make a new request using the link to the next page.
1. Interface and API change for Long running operations: To check the final result of the Poller object returned by long running operations like `beginCreateOrUpdate`, please use `pollUntilDone` instead of `pollUntilFinished`. To get the final result directly, use the method with the suffix `AndWait` e.g.`beginCreateOrUpdateAndWait`.
1. The SDK only supports ECMAScript 2015 (ES6) and beyond, all projects that referenced this SDK should be upgraded to use ES6.

Currently, we have previewed several packages such as `azure/arm-resources`, `@azure/arm-storage`, `@azure/arm-compute`, `@azure/arm-network` for next-generation. See more from npmjs.com and find the latest version under `next` tag and have a try.
If you have an existing application that uses the JavaScript/TypeScript Azure SDK packages and you're interested in updating your application to use the next-generation SDKs, the migration steps are quite straightforward. Here are the things that you need to do for the migration:

## Authentication

In the next-generation JavaScript/TypeScript packages, we only support using `@azure/identity` to do the Authentication. And we have deprecated the authentication methods defined `@azure/ms-rest-nodeauth` and `@azure/ms-rest-browserauth`. If you are using them, please change it accordingly.
For example, if you are using `loginWithServicePrincipalSecret` method in `@azure/ms-rest-nodeauth` to get the credential, you may replace it with `ClientSecretCredential` in `@azure/identity`.
In the next-generation JavaScript/TypeScript packages, we only support using `@azure/identity` to do the Authentication. We have deprecated the authentication methods defined `@azure/ms-rest-nodeauth` and `@azure/ms-rest-browserauth`. If you are still using them, please follow the below example to do the migration.

If you are using `loginWithServicePrincipalSecret` method in `@azure/ms-rest-nodeauth` to get the credential, please replace it with `ClientSecretCredential` in `@azure/identity`.

change

Expand Down Expand Up @@ -151,7 +152,7 @@ Refer to [@azure/core-paging](https://www.npmjs.com/package/@azure/core-paging)

## Long Running Operations

Many operations could take a long time before sending the desired response. The SDK provides two types of methods to interact with such operations. First type is a method that simply returns the result after the operation finishes processing and those methods' names correspond to the name of the API they call. One issue with these methods is that they do not provide a way to check on the current status of the operation or to access any partial results computed so far. The next-generation SDK provides similar methods but with a slightly different name, it has the prefix `begin` and the postfix `AndWait`. The other type of methods is one that returns a poller object which gives you access to the underlying state of the operation. Previously, these methods returned an object of type [`LROPoller`](https://github.com/Azure/ms-rest-azure-js/blob/a9cee4480a8710d5c81890ae7cb7a1dea559ec65/lib/lroPoller.ts#L13), a class that is exported by `@azure/ms-rest-azure-js` but the new operations return an object that implements the [`PollerLike`](https://github.com/Azure/azure-sdk-for-js/blob/35f86a68def5022d4c03a32d4c8c0362a0158772/sdk/core/core-lro/src/poller.ts#L50) interface instead which is exported by `@azure/core-lro`. The name of those methods did not change, both versions use the prefix `begin` with no postfix.
Many operations may take a long time before receiving the desired response. The SDK provides two types of methods to interact with such operations. First type is a method that simply returns the result after the operation finishes processing and those methods' names correspond to the name of the API they call. One issue with these methods is that they do not provide a way to check on the current status of the operation or to access any partial results computed so far. The next-generation SDK provides similar methods but with a slightly different name, it has the prefix `begin` and the postfix `AndWait`. The other type of methods is one that returns a poller object which gives you access to the underlying state of the operation. Previously, these methods returned an object of type [`LROPoller`](https://github.com/Azure/ms-rest-azure-js/blob/a9cee4480a8710d5c81890ae7cb7a1dea559ec65/lib/lroPoller.ts#L13), a class that is exported by `@azure/ms-rest-azure-js` but the new operations return an object that implements the [`PollerLike`](https://github.com/Azure/azure-sdk-for-js/blob/35f86a68def5022d4c03a32d4c8c0362a0158772/sdk/core/core-lro/src/poller.ts#L50) interface instead which is exported by `@azure/core-lro`. The name of those methods did not change, both versions use the prefix `begin` with no postfix.

<!-- markdownlint-disable MD033 -->
<table>
Expand Down Expand Up @@ -334,4 +335,4 @@ We also provide some samples [here](https://github.com/Azure-Samples/azure-sampl

## Need help

If you have encountered an issue during migration, please file an issue via `Github Issues <https://github.com/Azure/azure-sdk-for-js/issues>`and make sure you add the "Preview" label to the issue
If you have encountered an issue during migration, please file an issue via [Github Issues](https://github.com/Azure/azure-sdk-for-js/issues) and make sure you add the 'Preview' label to the issue.
13 changes: 8 additions & 5 deletions eng/common/TestResources/New-TestResources.ps1
View file
Original file line number Diff line number Diff line change
Expand Up @@ -329,9 +329,9 @@ try {
$sp.Id
}

# If the ServiceDirectory is an absolute path use the last directory name
# (e.g. D:\foo\bar\ -> bar)
$serviceName = if (Split-Path -IsAbsolute $ServiceDirectory) {
# If the ServiceDirectory has multiple segments use the last directory name
# e.g. D:\foo\bar -> bar or foo/bar -> bar
$serviceName = if (Split-Path $ServiceDirectory) {
Split-Path -Leaf $ServiceDirectory
} else {
$ServiceDirectory
Expand Down Expand Up @@ -463,7 +463,10 @@ try {
# service principal without permissions to grant RBAC roles to other service principals. That should not be
# considered a critical failure, as the test application may have subscription-level permissions and not require
# the explicit grant.
if (!$resourceGroupRoleAssigned) {
#
# Ignore this check if $AzureTestPrincipal is specified as role assignment will already have been attempted on a
# previous run, and these error messages can be misleading for local runs.
if (!$resourceGroupRoleAssigned -and !$AzureTestPrincipal) {
Log "Attempting to assigning the 'Owner' role for '$ResourceGroupName' to the Test Application '$TestApplicationId'"
$principalOwnerAssignment = New-AzRoleAssignment -RoleDefinitionName "Owner" -ApplicationId "$TestApplicationId" -ResourceGroupName "$ResourceGroupName" -ErrorAction SilentlyContinue

Expand Down Expand Up @@ -916,4 +919,4 @@ Run this in an Azure DevOps CI (with approrpiate variables configured) before
executing live tests. The script will output variables as secrets (to enable
log redaction).
#>
#>
20 changes: 20 additions & 0 deletions eng/common/pipelines/templates/steps/devops-variables-clear.yml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
parameters:
- name: Variables
type: object
default: []
- name: ContinueOnError
type: boolean
default: false

steps:
- pwsh: |
$rawVariables = @"
${{ convertToJson(parameters.Variables) }}
"@
$variables = ConvertFrom-Json $rawVariables -AsHashtable
foreach ($key in $variables.Keys) {
Write-Host "Clearing: $key"
Write-Host "##vso[task.setvariable variable=$key]"
}
continueOnError: ${{ parameters.ContinueOnError }}
displayName: Clear DevOps Variables
21 changes: 21 additions & 0 deletions eng/common/pipelines/templates/steps/devops-variables-set.yml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
parameters:
- name: Variables
type: object
default: []
- name: ContinueOnError
type: boolean
default: false

steps:
- pwsh: |
$rawVariables = @"
${{ convertToJson(parameters.Variables) }}
"@
$variables = ConvertFrom-Json $rawVariables -AsHashtable
foreach ($key in $variables.Keys) {
$value = $variables[$key]
Write-Host "Setting: $key = $value"
Write-Host "##vso[task.setvariable variable=$key]$value"
}
continueOnError: ${{ parameters.ContinueOnError }}
displayName: Set DevOps Variables
2 changes: 1 addition & 1 deletion eng/common/pipelines/templates/steps/update-docsms-metadata.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ steps:
DefaultBranchVariableName: TargetBranchName

- pwsh: |
$packageInfoJson = '${{ convertToJson(parameters.PackageInfoLocations) }}'.Trim('"')
$packageInfoJson = '${{ convertToJson(parameters.PackageInfoLocations) }}'.Trim('"').Replace("\\", "/")
$packageInfoLocations = ConvertFrom-Json $packageInfoJson
${{ parameters.ScriptDirectory }}/Update-DocsMsMetadata.ps1 `
-PackageInfoJsonLocations $packageInfoLocations `
Expand Down
Loading

0 comments on commit f46a54a

Please sign in to comment.