Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have consistent lint scripts for all packages that use the eslint plugin #11256

Closed
ramya-rao-a opened this issue Sep 15, 2020 · 1 comment
Closed
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. eslint plugin

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Sep 15, 2020

We currently have a mix of different ways the lint script is written in the package.json file of the packages that use the eslint plugin:

  • eslint -c ../../.eslintrc.old.json src test samples --ext .ts
  • eslint package.json api-extractor.json src test --ext .ts

and a few others...

The only difference we should have is whether the output is routed to an html file and ignore errors using the || exit 0 or not.
The former would be for packages for which we have not fixed linting errors yet.
The latter would be for packages for which all current linting errors are fixed

Another issue with these scripts are that some of them have the wrong package name in the linting report, potentially due to copy/paste errors

@deyaaeldeen
Copy link
Member

Now that #11266, #11468, #11469, #11471, #11472, and #11515 have been merged, this issue has been resolved and can be closed.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. eslint plugin
Projects
None yet
Development

No branches or pull requests

2 participants