Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cosmos] Does not use .eslintrc.old.json #11471

Merged
merged 1 commit into from
Sep 25, 2020
Merged

[Cosmos] Does not use .eslintrc.old.json #11471

merged 1 commit into from
Sep 25, 2020

Conversation

deyaaeldeen
Copy link
Member

@deyaaeldeen deyaaeldeen commented Sep 24, 2020 •
edited
Loading

We are planning on removing .eslintrc.old.json file and this PR removes its use in cosmos package. See #11256.

@ghost ghost added the Cosmos label Sep 24, 2020
@deyaaeldeen deyaaeldeen changed the title [Cosmos] Do not use .eslintrc.old.json [Cosmos] Does not use .eslintrc.old.json Sep 24, 2020
ramya-rao-a
ramya-rao-a approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for an approval from @zfoster as well

@zfoster AFAIK, this is used by the lint script defined in the package.json file and should not affect the tslint step that you have running as part of the build script

@deyaaeldeen deyaaeldeen merged commit f809020 into Azure:master Sep 25, 2020
@deyaaeldeen deyaaeldeen deleted the cosmos-deprecate-old-eslint-config branch September 25, 2020 16:58
deyaaeldeen added a commit to deyaaeldeen/azure-sdk-for-js that referenced this pull request Sep 25, 2020
@deyaaeldeen
[Cosmos] Do not use .eslintrc.old.json (Azure#11471)
3fb6414
@deyaaeldeen deyaaeldeen mentioned this pull request Sep 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@southpolesteve southpolesteve southpolesteve approved these changes

@ramya-rao-a ramya-rao-a ramya-rao-a approved these changes

@zfoster zfoster Awaiting requested review from zfoster

Assignees
No one assigned
Labels
Cosmos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deyaaeldeen @southpolesteve @ramya-rao-a