[Event Hub] Use our ESLint plugin #11468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deyaaeldeen
requested review from
chradek,
HarshaNalluru and
richardpark-msft
as code owners
ghost
added
the
richardpark-msft
previously requested changes
Sep 24, 2020
|
@deyaaeldeen Perhaps linking to the related issue might have helped. I dont have an answer for whether we will have more errors or not, taking a look at the generated lint report before and after this change can help there |
ramya-rao-a
approved these changes
Sep 24, 2020
ramya-rao-a
reviewed
Sep 24, 2020
|
@richardpark-msft |
|
@deyaaeldeen - looks great to me. Looks like we even pick up some better validation around our package.json too, which is a plus! |
deyaaeldeen
added a commit
to deyaaeldeen/azure-sdk-for-js
that referenced
this pull request
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching the eslint configuration file to use the newer one in the root of the repository. See #11256.