Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EventHub] Add a code sample for express #12146

Closed
ruowan opened this issue Oct 29, 2020 · 1 comment · Fixed by #12246
Closed

[EventHub] Add a code sample for express #12146

ruowan opened this issue Oct 29, 2020 · 1 comment · Fixed by #12246
Assignees
@chradek
Labels
Client This issue points to a problem in the data-plane of the library. Docs Event Hubs
Milestone
MQ-2020

Comments

@ruowan
Copy link
Member

ruowan commented Oct 29, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
I am using EventHub. When I first use EventHub I found there is missing some complex code sample, such as how to integrate EventHub with Node express. I believe there maybe be other people who have the same issue. So I want to share my service scenario code.

Describe the solution you'd like
I want to contribute EventHub code sample doc. Share my best practice (integrate Node Express with Azure EventHub). What's the contributionion process? Could I directly create a PR?

Describe alternatives you've considered

Additional context
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 29, 2020
@ramya-rao-a
Copy link
Contributor

Hey @ruowan

We have generic documentation on bundling which would apply to all our packages.

We also have an event hubs specific browser sample

Please feel free to create a PR to add another folder say "express" right next to the "browserSample" folder above.

We can use the PR to discuss further details

@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Docs Event Hubs labels Nov 1, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 1, 2020
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Nov 1, 2020
@ramya-rao-a ramya-rao-a changed the title [EventHub] Add a code sample [EventHub] Add a code sample for express Nov 1, 2020
@ruowan ruowan linked a pull request Nov 3, 2020 that will close this issue
add express sample for event hub #12246
Merged
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, MQ-2020 Nov 16, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Mar 9, 2021
@xaliciayang @ayeletshpigelman
CodeGen from PR 13332 in Azure/azure-rest-api-specs
29e445a 
Release microsoft.sql 2020-11-01 preview API version (Azure#13332)

* Adds base for updating Microsoft.Sql from version preview/2020-08-01-preview to version 2020-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add updated 2020-11-01-preview versions of LongTermRetenionBackups.json and Databases.json (Azure#12146)

* add updated databases.json swagger

* update readme with new package

* v4 -> v5

* add missing chunk in readme

* add correct swaggeR

* add examples

* add correct examplese

* remove unreferenced examples

* update swagger and examples. add 2020-11 pure package

* Fix reference to 2020-08-01 reference to ElasticPools.json

* update Databases.json name

* update examples

* remove nonexistant swagger

* fixed reference capitals in readme

* update package composite and fix ref to ManagedInstances.jsON

* make backupstorageredundancy settings consistent

* add requestedBackupStorageRedundancy to properties object in example

* add LTR swagger and examples

* add LTR Policies swagger and examples

* make v5 match v4

* add updated Databses.json

* merge conflicts in LTR Policies swagger'

* take out comments in readme

* taking ImportExport.json out from 2020-11 package

* remove duplicate 2020-11 tag in readme

* modify Databases_legacy.json to exclude ImportExport-related APIs

* add servers.json for IE APIS and remove unused databases examples

* fix model & prettier errors; add missing server example

* add missing servers examples

* fix example to exclude property from server obj

* change RecommendedActions definitoins

* change tag to composite v4

* Add missing properties for api version 2020-02-02-preview of securityAlertPolicies (Azure#13117)

* Add missing properties for api version 2020-02-02-preview

* fix checks

* fix according to prettier check

* Add the change to version 2020-08-01-preview and version 2020-11-01-preview

* remove changes in package-lock

* Add new line at the end of file

* update version 2020-11-01-preview

* Update the ref to system data in serverdevopsaudit

* add missing point

* fix the validation errors (Azure#13325)

* fix the validation errors

* Delete ServerDevOpsAudit.json

* fix the validation errors

* re add ServerDevOpsAudit.json

Co-authored-by: xaliciayang <59986952+xaliciayang@users.noreply.github.com>
Co-authored-by: ayeletshpigelman <ayshpige@microsoft.com>
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Mar 29, 2021
@xaliciayang @ayeletshpigelman
@strehan1993 @kukislav @athreya-geetha
CodeGen from PR 13689 in Azure/azure-rest-api-specs
22b27dd 
Dev sql microsoft.sql 2020 11 01 preview minor change (Azure#13689)

* Adds base for updating Microsoft.Sql from version preview/2020-08-01-preview to version 2020-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add updated 2020-11-01-preview versions of LongTermRetenionBackups.json and Databases.json (Azure#12146)

* add updated databases.json swagger

* update readme with new package

* v4 -> v5

* add missing chunk in readme

* add correct swaggeR

* add examples

* add correct examplese

* remove unreferenced examples

* update swagger and examples. add 2020-11 pure package

* Fix reference to 2020-08-01 reference to ElasticPools.json

* update Databases.json name

* update examples

* remove nonexistant swagger

* fixed reference capitals in readme

* update package composite and fix ref to ManagedInstances.jsON

* make backupstorageredundancy settings consistent

* add requestedBackupStorageRedundancy to properties object in example

* add LTR swagger and examples

* add LTR Policies swagger and examples

* make v5 match v4

* add updated Databses.json

* merge conflicts in LTR Policies swagger'

* take out comments in readme

* taking ImportExport.json out from 2020-11 package

* remove duplicate 2020-11 tag in readme

* modify Databases_legacy.json to exclude ImportExport-related APIs

* add servers.json for IE APIS and remove unused databases examples

* fix model & prettier errors; add missing server example

* add missing servers examples

* fix example to exclude property from server obj

* change RecommendedActions definitoins

* change tag to composite v4

* Add missing properties for api version 2020-02-02-preview of securityAlertPolicies (Azure#13117)

* Add missing properties for api version 2020-02-02-preview

* fix checks

* fix according to prettier check

* Add the change to version 2020-08-01-preview and version 2020-11-01-preview

* remove changes in package-lock

* Add new line at the end of file

* update version 2020-11-01-preview

* Update the ref to system data in serverdevopsaudit

* add missing point

* fix the validation errors

* Delete ServerDevOpsAudit.json

* fix the validation errors

* re add ServerDevOpsAudit.json

* fix the validation errors (Azure#13325)

* fix the validation errors

* Delete ServerDevOpsAudit.json

* fix the validation errors

* re add ServerDevOpsAudit.json

* address PrivateEndpointConnections.json validation issues in v3, v2 and v1

* Address Private Endpoint validation issues in V3, V2 and V1 SDK tags (Azure#13404)

* fix the validation errors

* Delete ServerDevOpsAudit.json

* fix the validation errors

* re add ServerDevOpsAudit.json

* address PrivateEndpointConnections.json validation issues in v3, v2 and v1

* Identity/Key/external Admin API (Azure#13411)

* Add examples for sql mi remove maintenance configuration (Azure#13390)

* Add missing specs 2020 11 01 (Azure#13488)

* fix the validation errors

* Delete ServerDevOpsAudit.json

* fix the validation errors

* re add ServerDevOpsAudit.json

* address PrivateEndpointConnections.json validation issues in v3, v2 and v1

* add missing specs in 2020-11-01-preview

* update the validation errors

* update systemData and sync with global common/v1/types.json

* update legacy to match the latest database specs

* remove RestorableDroppedManagedInstances due to it should be internal

* Updated database extensions (Azure#13584)

Co-authored-by: Geetha Athreya <geathrey@microsoft.com>

Co-authored-by: xaliciayang <59986952+xaliciayang@users.noreply.github.com>
Co-authored-by: ayeletshpigelman <ayshpige@microsoft.com>
Co-authored-by: strehan1993 <70013163+strehan1993@users.noreply.github.com>
Co-authored-by: Ivan Kulezic <72797230+kukislav@users.noreply.github.com>
Co-authored-by: Geetha Athreya <43223869+athreya-geetha@users.noreply.github.com>
Co-authored-by: Geetha Athreya <geathrey@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chradek chradek

Labels
Client This issue points to a problem in the data-plane of the library. Docs Event Hubs
Projects
None yet
Milestone
MQ-2020
Development

Successfully merging a pull request may close this issue.

add express sample for event hub ruowan/azure-sdk-for-js
3 participants
@ramya-rao-a @chradek @ruowan