Revert "[Recorder] Workaround for the "url-path with single quotes" bug in nock (#13474)" #13488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ug in nock (Azure#13474)" This reverts commit 5cd508c.
xirzec
approved these changes
Jan 29, 2021
|
Hello @HarshaNalluru! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
/check-enforcer override |
ghost
merged commit
HarshaNalluru
added a commit
to HarshaNalluru/azure-sdk-for-js
that referenced
this pull request
Jan 30, 2021
…uotes" bug in nock (Azure#13474)" (Azure#13488)" This reverts commit 230fd72.
ghost
pushed a commit
that referenced
this pull request
Feb 1, 2021
…rted "workaround" (#13494) #13474 added a workaround in the recorder but was reverted soon at #13488 because the presence of single quotes in the request body had corrupted the updated fixture due to the workaround. For the case with request bodies, since the request body may contain literally anything, it is not trivial to come up with a regex to split the arguments. Any regex would have assumptions on the line saved by nock, i.e., the number of spaces in between the arguments and the characters with which the payload would start and what the url-path may contain. Given the problems, it might be much better if we get the fix from nock before the string/fixture is saved. And since we have only seen the single quotes with the delete requests and that too for the requests without the request body, I'm inclined to have the workaround only for that case(without the request bodies). I have left a TODO for the case with request bodies for now. Have tested this fix with the data-tables SDK, and I was able to record and playback all the `data-tables` tests. This would unblock #12548.
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Mar 29, 2021
Dev sql microsoft.sql 2020 11 01 preview minor change (Azure#13689) * Adds base for updating Microsoft.Sql from version preview/2020-08-01-preview to version 2020-11-01-preview * Updates readme * Updates API version in new specs and examples * Add updated 2020-11-01-preview versions of LongTermRetenionBackups.json and Databases.json (Azure#12146) * add updated databases.json swagger * update readme with new package * v4 -> v5 * add missing chunk in readme * add correct swaggeR * add examples * add correct examplese * remove unreferenced examples * update swagger and examples. add 2020-11 pure package * Fix reference to 2020-08-01 reference to ElasticPools.json * update Databases.json name * update examples * remove nonexistant swagger * fixed reference capitals in readme * update package composite and fix ref to ManagedInstances.jsON * make backupstorageredundancy settings consistent * add requestedBackupStorageRedundancy to properties object in example * add LTR swagger and examples * add LTR Policies swagger and examples * make v5 match v4 * add updated Databses.json * merge conflicts in LTR Policies swagger' * take out comments in readme * taking ImportExport.json out from 2020-11 package * remove duplicate 2020-11 tag in readme * modify Databases_legacy.json to exclude ImportExport-related APIs * add servers.json for IE APIS and remove unused databases examples * fix model & prettier errors; add missing server example * add missing servers examples * fix example to exclude property from server obj * change RecommendedActions definitoins * change tag to composite v4 * Add missing properties for api version 2020-02-02-preview of securityAlertPolicies (Azure#13117) * Add missing properties for api version 2020-02-02-preview * fix checks * fix according to prettier check * Add the change to version 2020-08-01-preview and version 2020-11-01-preview * remove changes in package-lock * Add new line at the end of file * update version 2020-11-01-preview * Update the ref to system data in serverdevopsaudit * add missing point * fix the validation errors * Delete ServerDevOpsAudit.json * fix the validation errors * re add ServerDevOpsAudit.json * fix the validation errors (Azure#13325) * fix the validation errors * Delete ServerDevOpsAudit.json * fix the validation errors * re add ServerDevOpsAudit.json * address PrivateEndpointConnections.json validation issues in v3, v2 and v1 * Address Private Endpoint validation issues in V3, V2 and V1 SDK tags (Azure#13404) * fix the validation errors * Delete ServerDevOpsAudit.json * fix the validation errors * re add ServerDevOpsAudit.json * address PrivateEndpointConnections.json validation issues in v3, v2 and v1 * Identity/Key/external Admin API (Azure#13411) * Add examples for sql mi remove maintenance configuration (Azure#13390) * Add missing specs 2020 11 01 (Azure#13488) * fix the validation errors * Delete ServerDevOpsAudit.json * fix the validation errors * re add ServerDevOpsAudit.json * address PrivateEndpointConnections.json validation issues in v3, v2 and v1 * add missing specs in 2020-11-01-preview * update the validation errors * update systemData and sync with global common/v1/types.json * update legacy to match the latest database specs * remove RestorableDroppedManagedInstances due to it should be internal * Updated database extensions (Azure#13584) Co-authored-by: Geetha Athreya <geathrey@microsoft.com> Co-authored-by: xaliciayang <59986952+xaliciayang@users.noreply.github.com> Co-authored-by: ayeletshpigelman <ayshpige@microsoft.com> Co-authored-by: strehan1993 <70013163+strehan1993@users.noreply.github.com> Co-authored-by: Ivan Kulezic <72797230+kukislav@users.noreply.github.com> Co-authored-by: Geetha Athreya <43223869+athreya-geetha@users.noreply.github.com> Co-authored-by: Geetha Athreya <geathrey@microsoft.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5cd508c.
Since the regex had replaced an expected fixture at data-tables PR.
TODO: Come up with another regex that would not affect the single quotes in the second argument of
post()call in the nock fixture.