Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Identity] Broken link in Identity examples #15324

Closed
ramya-rao-a opened this issue May 18, 2021 · 0 comments · Fixed by #15031
Closed

[Identity] Broken link in Identity examples #15324

ramya-rao-a opened this issue May 18, 2021 · 0 comments · Fixed by #15031
Assignees
@sadasant
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. Docs
Milestone
[2021] July

Comments

@ramya-rao-a
Copy link
Contributor

The link to "Enable applications for device code flow" is broken in https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/identity/identity/samples/AzureIdentityExamples.md#authenticating-a-user-account-with-device-code-flow

image
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 18, 2021
@ramya-rao-a ramya-rao-a added Azure.Identity Client This issue points to a problem in the data-plane of the library. Docs labels May 18, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 18, 2021
@ramya-rao-a ramya-rao-a added this to the [2021] June milestone May 18, 2021
@sadasant sadasant modified the milestones: [2021] June, [2021] July Jun 7, 2021
This was referenced Jun 9, 2021
Closed
Merged
@ghost ghost closed this as completed in #15031 Jun 24, 2021
ghost pushed a commit that referenced this issue Jun 24, 2021
@sadasant
[Identity] Samples aligned with other languages (v1 compatible) (#15031)
9b9a9d1 
In this PR we're aligning the samples of Identity with other languages. The samples I'm adding in this PR are:

- Rolling certificates with ClientCertificateCredential ([.Net](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/identity/Azure.Identity/samples/ClientCertificateCredentialSamples.md#rolling-certificates)).
- ClientCertificateCredential with a Key Vault Certificate ([Python](Azure/azure-sdk-for-python#18109)) (decided not to use `@azure/keyvault-certificates` because of the possible issues converting certificates from one format to another in Node).
- Custom credentials ([.Net](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/identity/Azure.Identity/samples/DefiningCustomCredentialTypes.md#defining-custom-credential-types)).
- Using MSAL directly ([.Net](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/identity/Azure.Identity/samples/DefiningCustomCredentialTypes.md#authenticating-with-msal-directly)).
- On Behalf Of Flow ([.Net](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/identity/Azure.Identity/samples/DefiningCustomCredentialTypes.md#authenticating-with-the-on-behalf-of-flow)).

New samples related to the v2-specific features will be added after the Identity package is separated.

Related to #14435

---

I’ve decided to use this opportunity to:

Fix #15324

This PR also implicitly:

Fixes #15573
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. Docs
Projects
None yet
Milestone
[2021] July
2 participants
@sadasant @ramya-rao-a