Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Identity] Document how to use msal-node and msal-browser directly #15573

Closed
sadasant opened this issue Jun 4, 2021 · 0 comments · Fixed by #15031
Closed

[Identity] Document how to use msal-node and msal-browser directly #15573

sadasant opened this issue Jun 4, 2021 · 0 comments · Fixed by #15031
Assignees
Milestone

Comments

@sadasant
Copy link
Contributor

sadasant commented Jun 4, 2021

While we work on improvements for our Identity story, we should document how users could leverage MSAL packages directly to use our SDKs. We’ll need to add information on how to create a TokenCredential that would resolve the getToken method with a token retrieved using @azure/msal-node and @azure/ msal-browser.

We have a sample talking about creating custom TokenCredentials (similar to how .NET also has). Still, we should specifically mention the cases where it will make sense to use MSAL directly with custom TokenCredentials and why.

Closes #15569
Closes #15078

@sadasant sadasant added this to the [2021] July milestone Jun 4, 2021
@sadasant sadasant self-assigned this Jun 4, 2021
@ghost ghost closed this as completed in #15031 Jun 24, 2021
ghost pushed a commit that referenced this issue Jun 24, 2021
In this PR we're aligning the samples of Identity with other languages. The samples I'm adding in this PR are:

- Rolling certificates with ClientCertificateCredential ([.Net](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/identity/Azure.Identity/samples/ClientCertificateCredentialSamples.md#rolling-certificates)).
- ClientCertificateCredential with a Key Vault Certificate ([Python](Azure/azure-sdk-for-python#18109)) (decided not to use `@azure/keyvault-certificates` because of the possible issues converting certificates from one format to another in Node).
- Custom credentials ([.Net](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/identity/Azure.Identity/samples/DefiningCustomCredentialTypes.md#defining-custom-credential-types)).
- Using MSAL directly ([.Net](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/identity/Azure.Identity/samples/DefiningCustomCredentialTypes.md#authenticating-with-msal-directly)).
- On Behalf Of Flow ([.Net](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/identity/Azure.Identity/samples/DefiningCustomCredentialTypes.md#authenticating-with-the-on-behalf-of-flow)).

New samples related to the v2-specific features will be added after the Identity package is separated.

Related to #14435

---

I’ve decided to use this opportunity to:

Fix #15324

This PR also implicitly:

Fixes #15573
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Aug 10, 2021
resolving correctness error in preview (Azure#15573)

* resolving correctness error in preview

* adding max time for long running operations

Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant