Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapping up min-max testing #17830

Closed
15 tasks
jeremymeng opened this issue Sep 23, 2021 · 3 comments
Closed
15 tasks

Wrapping up min-max testing #17830

jeremymeng opened this issue Sep 23, 2021 · 3 comments
Labels
Client This issue points to a problem in the data-plane of the library. Epic

Comments

@jeremymeng
Copy link
Member

jeremymeng commented Sep 23, 2021 •
edited by HarshaNalluru
Loading

This tracks remaining libraries that haven't had min-max testing enabled.

The following libraries still have min-max testing disabled because of

     MatrixFilters:
        - DependencyVersion=^$

We need to ensure

  1. their tests are separated into internal and public folders
  2. enable min-max testing by removing the filter

Additional Details for test separation into internal and public folders :
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. Epic labels Sep 23, 2021
@jeremymeng
Copy link
Member Author

closing as we have #9442 already

@jeremymeng jeremymeng reopened this Sep 23, 2021
@jeremymeng
Copy link
Member Author

closing as we have #9442 already

Re-opening as #9442 only tracks the separation work.

@KarishmaGhiya KarishmaGhiya mentioned this issue Sep 24, 2021
Merged
This was referenced Sep 27, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@deyaaeldeen deyaaeldeen mentioned this issue Sep 28, 2021
Closed
@jeremymeng jeremymeng changed the title Wrapping up min-max testing Wrapping up min-max testing for Jan-June 2022 Sep 29, 2021
This was referenced Dec 21, 2021
Closed
Closed
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 28, 2022
@laithhisham @royrein @akning-ms
CodeGen from PR 17924 in Azure/azure-rest-api-specs
4539185 
Dev securityinsights microsoft.security insights 2021 10 01 (Azure#17924)

* Adds base for updating Microsoft.SecurityInsights from version stable/2021-04-01 to version 2021-10-01

* Updates readme

* Updates API version in new specs and examples

* Add AlertRules to microsoft.security insights 2021 10 01 (Azure#15657)

* Adds base for updating Microsoft.SecurityInsight's AlertRules from version stable/2020-01-01 to version 2021-10-01

* Updates API version in AlertRules specs and examples

* Use common types in AlertRules.json and remove redundant SecurityInsights

* Add AlertRules to readme

* Copy action examples for alert rules

* Add type:object where missing

* Align CloudError with rest of the resources in this version

* Update readme

Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com>

* Use newest common types to align with rest of Azure (Azure#16130)

* Use newest common types to align with rest of Azure

* Use ErrorResponse instead of CloudError in operations

Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com>

* Add AlertRules Stable version to 2021-10-01 (Azure#16268)

* Add AlertRules Stable version to 2021-10-01

* Fix missing alignment in common types

* prettier fixes

* move tactics and severity to common

* fix common types file extension

* more prettier fixes

* Add template version field

* prettier

* added version to required fields

* dummy change to trigger checks again

* Add onboarding states to new stable version (Azure#16290)

* Add onboarding states to new stable version

* Update readme.md

* cr fix - remove unused params

* Add missing resources 2021 10 01 (Azure#16666)

* Add missing resources and examples from 2020-01-01

* Update version in added resources and examples

* Use existing common types

* Remove unnesessary SecurityInsights.json

* Update readme

* Use sentinel common types in Incidents and Watchlist

* Extract and common IncidentInfo and IncidentSeverity

* Extract EntityTypes

* Correct double allOf in EntityTypes

* update readme

* Remove eventGroupingSettings and entityMappings from GetAlertRuleTemplateById example.

* rename operations.json

Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com>

* Fix analytics templates model (Azure#16689)

* add missing properties to scheduled template

* prettier fixes

* restore templates example after merge

* fix templates example after merge and run prettier

* Use CloudError instead of ErrorResponse to align with preview versions and our back-end. (Azure#17472)

* Automation - Stable Version (Azure#17491)

* First

* readMe

* cloudError

* CloudError

* schema

* prettier

* Fix

* test

* fix identifier

* fix description

* fix lable

* fix lable

* ownerInfo

* Fix

* types

* conditionMaxLength

Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>

* Done (Azure#17728)

Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>

* Correct 2021 10 01 (Azure#17830)

* Remove OperationalInsightsResourceProvider parameter in ThreatIntelligence

* Remove OperationalInsightProviderParameter from Watchlist

* Align stable operation names with preview

* Add missing disciminator property in ThreatIntelligence

* Done (Azure#17844)

Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>

* Align enum names with preview (Azure#17831)

* Fix 2021 10 01 validation errors (Azure#17937)

* Add x-ms-identifiers to all arrays

* Add operations_list example

* Add x-ms-identifier in all arrays

* Run prettier

* Fix spelling error

* Add isDataAction to operation schema (Azure#18018)

Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com>
Co-authored-by: laithhisham <49263932+laithhisham@users.noreply.github.com>
Co-authored-by: royrein <37300636+royrein@users.noreply.github.com>
Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>
Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com>
@jeremymeng jeremymeng changed the title Wrapping up min-max testing for Jan-June 2022 Wrapping up min-max testing Aug 24, 2023
@github-actions GitHub Actions
Copy link

Hi @jeremymeng, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Epic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeremymeng