Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate the need to decode AMQP body that does not have the content field #18216

Closed
ramya-rao-a opened this issue Oct 15, 2021 · 1 comment
Closed

Investigate the need to decode AMQP body that does not have the content field #18216

ramya-rao-a opened this issue Oct 15, 2021 · 1 comment
Assignees
@deyaaeldeen
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs help wanted This issue is tracking work for which community contributions would be welcomed and appreciated Service Bus

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Oct 15, 2021 •
edited
Loading

Package: @azure/event-hubs

The decode() method that is applied on every event that is received over AMQP first attempts to read from body.content if the message has a valid type code otherwise reads from body.

This issue is to investigate if we need this fall back at all. Does AMQP dictate that every message should have a valid type code? Does rhea, the AMQP library we use, support storing anything in body directly instead of using body.content?

This applies to @azure/service-bus as well where we use similar logic
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 15, 2021
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Event Hubs Service Bus labels Oct 15, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 15, 2021
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Oct 15, 2021
@ramya-rao-a ramya-rao-a added the help wanted This issue is tracking work for which community contributions would be welcomed and appreciated label Oct 15, 2021
@ramya-rao-a ramya-rao-a mentioned this issue Oct 15, 2021
Merged
8 tasks
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Mar 22, 2022
@zjpjack @matthchr
CodeGen from PR 18324 in Azure/azure-rest-api-specs
c604780 
Review request for Microsoft.ContainerService to add version 2022-02-01 (Azure#18324)

* Adds base for updating Microsoft.ContainerService from version stable/2022-01-01 to version 2022-02-01

* Updates readme

* Updates API version in new specs and examples

* Update readmes for the 2022-02-01 dev branch of container service (Azure#17887)

* update readme

* remove useless -only tags

* Fix violated rule R2026 for 2022-02-01 managedCluster swagger (Azure#18024)

* fix allof

* add missing type

* GA alias minor version (Azure#18038)

* GA alias minor version

* polish more details on kubernetesVersion and currentKubernetesVersion

* Update specification/containerservice/resource-manager/Microsoft.ContainerService/stable/2022-02-01/managedClusters.json

minor revision

Co-authored-by: Matthew Christopher <matthchr@microsoft.com>

Co-authored-by: Matthew Christopher <matthchr@microsoft.com>

* add missing type object (Azure#18115)

* Revert "GA alias minor version (Azure#18038)" (Azure#18291)

This reverts commit 3a99cda3cb48e05c74923f5467c0737014322b0f.

* Align modifications of several common definitions with 2022-02-02-preview for container service 2022-02-01 (Azure#18216)

* sync modification

* fix ref

Co-authored-by: Jianping Zeng <zjpjack@users.noreply.github.com>
Co-authored-by: Matthew Christopher <matthchr@microsoft.com>
@deyaaeldeen deyaaeldeen self-assigned this Feb 23, 2023
@github-actions GitHub Actions
Copy link

Hi @ramya-rao-a, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deyaaeldeen deyaaeldeen

Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs help wanted This issue is tracking work for which community contributions would be welcomed and appreciated Service Bus
Projects
Azure SDK for Event Hubs
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xirzec @deyaaeldeen @ramya-rao-a