Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing sdk in the path in codeowners file #18324

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Conversation

ramya-rao-a
Copy link
Contributor

Fixing the incorrect path in the codeowners file

@ghost
Copy link

ghost commented Oct 22, 2021

Hello @ramya-rao-a!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

@qiaozha
Copy link
Member

qiaozha commented Oct 25, 2021

/check-enforcer override

@ghost
Copy link

ghost commented Oct 25, 2021

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines
  2. Dependabot
  3. GitHub Pages

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@qiaozha qiaozha merged commit 81915b2 into feature/v4 Oct 25, 2021
@qiaozha qiaozha deleted the ramya-rao-a-patch-3 branch October 25, 2021 02:31
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Mar 22, 2022
Review request for Microsoft.ContainerService to add version 2022-02-01 (Azure#18324)

* Adds base for updating Microsoft.ContainerService from version stable/2022-01-01 to version 2022-02-01

* Updates readme

* Updates API version in new specs and examples

* Update readmes for the 2022-02-01 dev branch of container service (Azure#17887)

* update readme

* remove useless -only tags

* Fix violated rule R2026 for 2022-02-01 managedCluster swagger (Azure#18024)

* fix allof

* add missing type

* GA alias minor version (Azure#18038)

* GA alias minor version

* polish more details on kubernetesVersion and currentKubernetesVersion

* Update specification/containerservice/resource-manager/Microsoft.ContainerService/stable/2022-02-01/managedClusters.json

minor revision

Co-authored-by: Matthew Christopher <matthchr@microsoft.com>

Co-authored-by: Matthew Christopher <matthchr@microsoft.com>

* add missing type object (Azure#18115)

* Revert "GA alias minor version (Azure#18038)" (Azure#18291)

This reverts commit 3a99cda3cb48e05c74923f5467c0737014322b0f.

* Align modifications of several common definitions with 2022-02-02-preview for container service 2022-02-01 (Azure#18216)

* sync modification

* fix ref

Co-authored-by: Jianping Zeng <zjpjack@users.noreply.github.com>
Co-authored-by: Matthew Christopher <matthchr@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants