Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form Recognizer]It will return error when use documentAnalysisClient with AAD authentication to run integration tests on UsGov cloud and China cloud #19442

Closed
zzhxiaofeng opened this issue Dec 17, 2021 · 12 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer test-sovereign-cloud
Milestone

Comments

@zzhxiaofeng
Copy link
Contributor

We are running live Tests against other clouds like US Gov and Azure China Cloud. The goal is to check whether new azure sdk package work with other clouds or not.

Error Description:
When we use documentAnalysisClient with azure active directory credential to run integration tests on UsGov cloud and China cloud, it will return an error. The error message is shown as following, for more details please check here:
image

Error Track:
The failed reason is that when we use azure active directory credential, the scope of credential is just supported on Public cloud. The scope of credential defines the set of permissions being requested by the application. In form recognizer client, the process code is here.
image
the value of scope is here.
image

Expected Behavior:
Add different scopes for different clouds in Form Recognizer SDK.
The value of the scope in different clouds is follow:
Public cloud: https://cognitiveservices.azure.com/.default
UsGov cloud: https://cognitiveservices.azure.us/.default
China cloud: https://cognitiveservices.azure.cn/.default

@benbp, @ramya-rao-a, @meeraharidasa, @jeremymeng for notification.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 17, 2021
@v-xuto v-xuto added Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer needs-team-triage Workflow: This issue needs the team to triage. test-manual-pass test-sovereign-cloud and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. test-manual-pass labels Dec 17, 2021
@ramya-rao-a ramya-rao-a added this to the [2022] January milestone Dec 17, 2021
@witemple-msft
Copy link
Member

@deyaaeldeen I know you've been working on similar issues in TA. What's your advice here?

@deyaaeldeen
Copy link
Member

@witemple-msft we went to the archboard for this as tracked by Azure/azure-sdk#3353. Next step is to design the actual cloud configuration.

@witemple-msft
Copy link
Member

@deyaaeldeen I'm mortally certain that I've seen an automatic cloud config system somewhere in really old code. ms-rest-azure-js maybe?

@witemple-msft
Copy link
Member

witemple-msft commented Jan 6, 2022

@ramya-rao-a This won't make it into January. I'm going to add it to Feb and take a look at adding something like an audience field to FormRecognizerCommonClientOptions. (Feel free to re-triage it if you think it's better in a different milestone.)

@HarshaNalluru HarshaNalluru added this to the Backlog milestone Apr 13, 2022
@v-xuto
Copy link
Member

v-xuto commented May 13, 2022

@HarshaNalluru About the fix of this issue, how is the current progress? Or what are your plans?

@HarshaNalluru
Copy link
Member

Hi @v-xuto,

#20522 should fix the problem, but the samples were failing in the China Cloud with conflict errors as far as I recall, which I thought could be avoided if the samples were run sequentially(one after the other).
Samples failure related investigation is pending along with the related support from dev-tool itself - #20522 (comment)
So, mostly waiting on that.

cc @witemple-msft

@HarshaNalluru HarshaNalluru modified the milestones: Backlog, [2022] July May 13, 2022
@v-xuto
Copy link
Member

v-xuto commented May 16, 2022

@HarshaNalluru Thank you for your prompt reply. I look forward to your PR being merged soon.
Please let me know if there is any progress. Thanks a lot.

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Jun 15, 2022
modify putLab in labservices (Azure#19442)

Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <v-ziweichen@microsoft.com>
@witemple-msft witemple-msft modified the milestones: 2022-07, 2022-08 Jun 29, 2022
@xirzec xirzec modified the milestones: 2022-08, 2022-09 Aug 9, 2022
@zedy-wj
Copy link
Member

zedy-wj commented Aug 30, 2022

Currently AAD tests are skipped in the test code, this issue no longer affects multi-cloud tests, can we close it first?
image

@HarshaNalluru HarshaNalluru modified the milestones: 2022-09, 2022-10 Sep 8, 2022
@HarshaNalluru HarshaNalluru modified the milestones: 2022-10, 2022-11 Oct 31, 2022
@HarshaNalluru HarshaNalluru modified the milestones: 2022-11, 2022-12 Nov 11, 2022
@xirzec xirzec modified the milestones: 2022-12, 2023-02 Jan 11, 2023
@HarshaNalluru HarshaNalluru modified the milestones: 2023-02, 2023-03 Feb 7, 2023
@HarshaNalluru HarshaNalluru modified the milestones: 2023-03, 2023-04 Feb 28, 2023
@v-xuto
Copy link
Member

v-xuto commented Mar 8, 2023

@HarshaNalluru Regarding this issue, what is the current progress?

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Mar 8, 2023

Recently, I've tested the service in those regions, the service is flaky right now, so blocked on this.

@v-xuto
Copy link
Member

v-xuto commented Mar 9, 2023

@HarshaNalluru Got it. Please let me know if there is any progress. Thanks in advance.

Copy link

Hi @zzhxiaofeng, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer test-sovereign-cloud
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants