[service-bus] Track 2 - push down methods of MessageReceiver that are only used for StreamingReceiver #10322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…sessionId and partitionKey is now considered a failure.
richardpark-msft
force-pushed
the
richardpark-sb-track2-refactor-streamingreceiver
branch
from
e188e51
to
9ab9a94
Compare
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ramya-rao-a
approved these changes
Jul 29, 2020
chradek
approved these changes
Jul 29, 2020
There was a problem hiding this comment.
Overall looks good! Thanks for making this change before refactoring the streaming receiver...I think this will help us focus on the important parts of the refactor 😄
Also wanted to make sure the changes to atomXml.spec.ts were intentional. Assuming your other PR that fixes live tests will unblock your CI here!
…live test run on my BatchingReceiverLite PR * Moved the receiverInit.spec.ts into 'internal' since it is purely a unit test.
…o StreamingReceiver. - maxConcurrentCalls - onDetach
…g receiver's onDetached.
…atch code flow explicit. * Push ReceiverHelper down - it wasn't used by the batching code path.
…ing ReceiverHelper in all the code but never removed it.
…_init() from MessageReceiver.
…od for the tests.
HarshaNalluru
approved these changes
Jul 29, 2020
richardpark-msft
force-pushed
the
richardpark-sb-track2-refactor-streamingreceiver
branch
from
9ab9a94
to
f8a4133
Compare
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ack2-refactor-streamingreceiver
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
richardpark-msft
deleted the
richardpark-sb-track2-refactor-streamingreceiver
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the refactor/re-use work it became obvious that a large part of MessageReceiver was actually just hosting StreamingReceiver's code.
This PR pushes the methods that are completely StreamingReceiver specific down so they're no longer in the shared base between StreamingReceiver and BatchingReceiver.
No real refactoring has taken place, it's more or less a mechanical move*
*(Well...okay a little refactoring):