Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[service-bus] Track 2 - push down methods of MessageReceiver that are only used for StreamingReceiver #10322

Merged
merged 22 commits into from
Jul 29, 2020
Merged

[service-bus] Track 2 - push down methods of MessageReceiver that are only used for StreamingReceiver #10322

merged 22 commits into from
Jul 29, 2020

Commits on Jul 29, 2020

  1. A service side change has made it so specifying different values for … 

    …sessionId and partitionKey is now considered a failure.
    @richardpark-msft
    richardpark-msft committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    cddf95d View commit details
    Browse the repository at this point in the history

  2. Another spot that tries to set the session ID independent of the part… 

    …ition key.
    @richardpark-msft
    richardpark-msft committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    3615407 View commit details
    Browse the repository at this point in the history

  3. * Fix a broken test that got through when I accidentally skipped the … 

    …live test run on my BatchingReceiverLite PR

* Moved the receiverInit.spec.ts into 'internal' since it is purely a unit test.
    @richardpark-msft
    richardpark-msft committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    399d6f2 View commit details
    Browse the repository at this point in the history

  4. Another spot where partition key and session ID did not line up.

    @richardpark-msft
    richardpark-msft committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    fbf6284 View commit details
    Browse the repository at this point in the history

  5. * Pushing down methods from MessageReceiver that really only belong t… 

    …o StreamingReceiver.

- maxConcurrentCalls
- onDetach
    @richardpark-msft
    richardpark-msft committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    bd4c7fd View commit details
    Browse the repository at this point in the history

  6. Migrating retryOptions into here as well. It's only used for streamin… 

    …g receiver's onDetached.
    @richardpark-msft
    richardpark-msft committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    98fa009 View commit details
    Browse the repository at this point in the history

  7. Use the publicly accessible receiverHelper

    @richardpark-msft
    richardpark-msft committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    2ae83e6 View commit details
    Browse the repository at this point in the history

  8. Moved the _on*Close handlers as well

    @richardpark-msft
    richardpark-msft committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    11755e0 View commit details
    Browse the repository at this point in the history

  9. Moved all the default handlers - they're all streaming receiver (appa… 

    …rently).
    @richardpark-msft
    richardpark-msft committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    1e6e892 View commit details
    Browse the repository at this point in the history

  10. * Start removing areas that used to default - make the streaming vs b… 

    …atch code flow explicit.

* Push ReceiverHelper down - it wasn't used by the batching code path.
    @richardpark-msft
    richardpark-msft committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    70d8f7b View commit details
    Browse the repository at this point in the history

  11. Move receiverHelper into it's own file

    @richardpark-msft
    richardpark-msft committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    a342ea0 View commit details
    Browse the repository at this point in the history

  12. Remove the older stopReceivingMessages function. I swapped over to us… 

    …ing ReceiverHelper in all the code but never removed it.
    @richardpark-msft
    richardpark-msft committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    ceeca3b View commit details
    Browse the repository at this point in the history

  13. Define a real init() function for StreamingReceiver and stop calling … 

    …_init() from MessageReceiver.
    @richardpark-msft
    richardpark-msft committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    bbe0ed1 View commit details
    Browse the repository at this point in the history

  14. Use the proper public facing method to stop receiving messages.

    @richardpark-msft
    richardpark-msft committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    4e3e9a6 View commit details
    Browse the repository at this point in the history

  15. Removing unused imports

    @richardpark-msft
    richardpark-msft committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    bd7434e View commit details
    Browse the repository at this point in the history

  16. Fixing broken unit tests.

    @richardpark-msft
    richardpark-msft committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    6cada13 View commit details
    Browse the repository at this point in the history

  17. Remove another redundant method

    @richardpark-msft
    richardpark-msft committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    36f7516 View commit details
    Browse the repository at this point in the history

  18. Use the public init() method, not the underlying private _init() meth… 

    …od for the tests.
    @richardpark-msft
    richardpark-msft committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    150f34d View commit details
    Browse the repository at this point in the history

  19. Addressing Ramya's feedback.

    @richardpark-msft
    richardpark-msft committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    f8a4133 View commit details
    Browse the repository at this point in the history

  20. Update the name

    @richardpark-msft
    richardpark-msft committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    baaf1f7 View commit details
    Browse the repository at this point in the history

  21. Fixing a test that was trying to stub an internal method when a publi… 

    …c one would do.
    @richardpark-msft
    richardpark-msft committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    fc271a9 View commit details
    Browse the repository at this point in the history

  22. Merge remote-tracking branch 'upstream/master' into richardpark-sb-tr… 

    …ack2-refactor-streamingreceiver
    @richardpark-msft
    richardpark-msft committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    c6cf2c0 View commit details
    Browse the repository at this point in the history