[core-http] Move challenge based auth to core-http #11226

sophiajt · 2020-09-13T20:51:29Z

This moves challenge-based auth from keyvault-common to core-http, so that more parts of the SDK can use it without taking a dependency on keyvault.

It also removes keyvault-common as challenge-based auth was the only thing keyvault-common was used for.

Fixes: #11225

sadasant

Also removing keyvault-admin repo in the same PR adds noise indeed, but sounds good to me as long as CI passes.

sadasant · 2020-09-14T15:29:14Z

sdk/core/core-http/review/core-http.api.md

+// @public
+export class AuthenticationChallenge {
+    constructor(authorization: string, scope: string);
+    // (undocumented)


Interesting, so:

In Key Vault, these functionalities are never published. Now we should probably add documentation.

If not in this PR, perhaps we could make an issue.

I'd prefer it be in this PR, since these types are made public in this PR

sdk/core/core-http/review/core-http.api.md

jeremymeng

Looks good. One comment about ae-forgotten warning

xirzec

I really like the cleanup of moving this type into core, I think the only part that bothers me now is the test story, though maybe I'm misunderstanding what the tests in the client packages are doing.

xirzec · 2020-09-14T19:54:18Z

sdk/core/core-http/review/core-http.api.md

+// @public
+export class AuthenticationChallenge {
+    constructor(authorization: string, scope: string);
+    // (undocumented)


I'd prefer it be in this PR, since these types are made public in this PR

sdk/core/core-http/review/core-http.api.md

sdk/keyvault/keyvault-certificates/test/internal/challengeBasedAuthenticationPolicy.spec.ts

sdk/keyvault/keyvault-keys/test/internal/challengeBasedAuthenticationPolicy.spec.ts

…_auth

sadasant · 2020-09-14T23:38:35Z

/azp run js - keyvault-keys - tests

azure-pipelines · 2020-09-14T23:38:44Z

Azure Pipelines successfully started running 1 pipeline(s).

sadasant · 2020-09-14T23:39:00Z

/azp run js - keyvault-certificates - tests

azure-pipelines · 2020-09-14T23:39:10Z

Azure Pipelines successfully started running 1 pipeline(s).

sadasant · 2020-09-14T23:59:06Z

MinMax tests will fail since this doesn't exist in any released version of core-http, so we can ignore that, as long as the other live tests pass.

sadasant · 2020-09-15T11:58:07Z

CI seems to work. Min Max doesn't work, probably because core-http doesn't have this feature in any of the artifacts released. On MacOS, we're getting the error below, but that seems unrelated - it seems more like a dependency availability issue:

VERBOSE: Total package yield:'0' for the specified package 'Az'.
Install-Package: /usr/local/microsoft/powershell/7/Modules/PowerShellGet/PSModule.psm1:9709
Line |
9709 |  … talledPackages = PackageManagement\Install-Package @PSBoundParameters
     |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | No match was found for the specified search criteria and
     | module name 'Az'. Try Get-PSRepository to see all available
     | registered module repositories.

sadasant · 2020-09-15T13:08:28Z

I think this is good to merge now, but @jonathandturner your review of my changes is appreciated.

sadasant · 2020-09-15T13:09:16Z

We might need to skip CI. cc: @KarishmaGhiya

…r/azure-sdk-for-js into move_challenge_based_auth

sophiajt · 2020-09-17T22:14:46Z

Addressed comments. I also moved the tests to core-http and mocked them using the same style as the existing tests. Going ahead and landing.

This reverts commit 43033ff.

…11320) This reverts commit 43033ff.

@ignore

* Sdk automation/@Azure arm operationalinsights (#10935) * Generated from ba891b7274af8cb22ee173e1998b4145d2d8d98b Adding a point get. * version 4.0.0 Co-authored-by: SDK Automation <sdkautomation@microsoft.com> * Increment package version after release of azure-cosmos (#11311) * [Text Analytics] Ignore document index when parsing opinion pointers (#11302) * [Text Analytics] Ignore Document Index * adding a test * update tests * add recordings * [Text Analytics] Update release date (#11313) * [Text Analytics] Update release date for 5.1.0-beta.1 * format * [core-http] Move challenge based auth to core-http (#11226) * Begin move of challenge-based auth * Begin move of challenge-based auth * Remove keyvault-common * Update paths * Fixing paths after removing keyvault-common * fixed bad dist-esm index.js references * Update paths * Update docs * Add mock tests * Add mock tests Co-authored-by: Daniel Rodríguez <sadasant@gmail.com> * Revert "[core-http] Move challenge based auth to core-http (#11226)" (#11320) This reverts commit 43033ff. * [AnomalyDetector] Update AnomalyDetector README (#11110) * Update AnomalyDetector README * Update pto beta * Update changelog * Address PR comments * Replaced relative link with absolute links and remove locale (#11317) Replaced relative link with absolute links and remove locale * Enable the link check on aggregate-report (#11330) * Increment package version after release of azure-ai-text-analytics (#11315) * [Tables] Enable recorded tests in CI (#11238) * Enable recorded tests in CI * Update test script * Add pollyfill * [Anomaly Detector] Add sample snippet to README (#11335) * Add samples to readme * Update changelog date * [Core-http] Support xml namespaces (#11201) * Prototype xmlns * Update prototype * Additional tests * Address PR comments * formatting * Apply changes to core-client * Address comments * update core-client api-extractor * use getXmlObjectValue * Increment package version after release of azure-ai-anomaly-detector (#11340) * [event-hubs] Update docs to mention the checkpoint store updates made when the subscription is closed. (#11345) As part of investigating #11316 we found it was non-obvious that we would be using the checkpoint store when closing. The reason we use it is when we close the subscription we also mark, in the checkpoint store, that the partitions are abandoned. This lets other consumers more quickly pick up abandoned partitions rather than forcing them to wait for an expiration interval and discover it. Fixes #11316 * Add testcases for handling odata (#11321) * Add testcases for handling odata * Formatting code * PR Comments * Minor Formatting * Update sdk/search/search-documents/src/odata.ts Co-authored-by: Jeff Fisher <xirzec@xirzec.com> * Update sdk/search/search-documents/src/odata.ts Co-authored-by: Jeff Fisher <xirzec@xirzec.com> Co-authored-by: Jeff Fisher <xirzec@xirzec.com> * release arm-netapp (#10849) * release arm-netapp * Generated from efcb7ecf4722c919d5528c53671b124046badcdb update netapp readme.java.md * version change Co-authored-by: SDK Automation <sdkautomation@microsoft.com> * Sdk automation/@Azure arm hybridcompute (#11307) * Generated from a35b1cd98e20d7c9b3c4fdcb23125b7ea85acca6 add alias for auto_rev_minor_version * v2.0.0 Co-authored-by: SDK Automation <sdkautomation@microsoft.com> * [Event Grid] Remove some 'en-us' from some links (#11185) * [Identity] Fix broken eslint in the builds (#11354) * [Identity] Fix broken eslint in the builds * .eslintignore was being ignored * Feedback by Deya * [Abort Controller] Update linting and fix linting errors (#11269) * update linting and fix linting errors * update linting scripts * formatting * fix linting errors * fixes * fix * run api-extractor * include the shim files in shipped files * use the unrolledup type declarations * do not lint package.json * still lint package.json * remove the call to api-extractor from the npm build script * simplify eslint commands * only ship src types * [Identity] Idea for the Device Code Credential Use Console Feature (#11355) * [Identity] Idea for the Device Code Credential Use Console Feature * Feedback by Schaab and Vinay * [Key Vault] Use the swagger generated from the service 7.2-preview (#11370) * swagger reference to 7.2-preview/keys.json * generated update * 7.2 on keys * 7.2 preview on certs and secrets * generated files for secrets and certs * secrets and certs * sticking the swagger change to a specific commit * Add placeholder yml file for pipeline generation * Smoke test failure due to rollup peer dependency error (#11372) * Change to move @rollup/plugin-json as dev dependency * Add client libraries for Azure Communication Services (#11385) * Add Communication service mapping * Communication - Add code owners and label triggers (#11401) * Communication - Add code owners and label triggers * [ESLint Plugin] fix docs link (#11400) * Increment package version after release of azure-keyvault-admin (#11216) * Sync eng/common directory with azure-sdk-tools repository for Tools PR 1022 (#11347) * Disable smoke test for storage-blob-changefeed (#11406) * [Core paging] Update linting scripts and auto linting (#11274) * [Core paging] Update linting scripts and auto linting * formatting changes * addressing Jeff's comments * fixes * turn sideEffects back on * adding comments to address Ramya's feedback * a typo * adding dist-esm/index.js back * Update sdk/core/core-paging/.eslintrc.json Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com> * remove dist-esm/src from files in package.json Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com> * fix package.json (#11412) * [Service Bus] Remove stream-browserify dependency (#11221) * [Core asynciterator] Update linting scripts and apply auto linting and some formatting (#11272) * update linting scripts * edits * turn off relevant rules and lint package.json back * adding .eslintrc.json * [service-bus] Fixing broken option - we renamed it to maxWaitTimeInMs a few previews back. (#11410) * Communication: fix test-resources config (#11434) * [core-http] Add NDJSON support (#11325) * [EventGrid] Add Azure Communication Service Events (#11428) This change adds typings for the new events sent by the Azure Communication Services * Sync eng/common directory with azure-sdk-tools repository for Tools PR 989 (#11214) * [Cosmos] Adding missing copyright headers (#11449) * [Service Bus] Type docs fix - Added @internal and @ignore tags for internal methods (#11427) * logger, isError, toAmqpAnnotatedMessage changed to internal * SubQueue renamed to _SubQueue and changed to internal for jsdoc * Revert "SubQueue renamed to _SubQueue and changed to internal for jsdoc" This reverts commit b97b682. * [Storage] Recursive ACL swagger transform patch * [Storage] Add support for recursive ACL * [Storage] Recording for recursive ACL * [Storage] Update changelog for recursive acl * [Storage] Add comments for recursive ACL parameters; Resolve review comments * Add continueOnFailure option for set AccessControlRecursive methods * Removed PathSetAccessControlRecursiveMode from public API list * Update AccessControlChangeFailure to AccessControlChangeError with typical name and message properties * Resolve build failures * Resolve build failures Co-authored-by: changlong-liu <59815250+changlong-liu@users.noreply.github.com> Co-authored-by: SDK Automation <sdkautomation@microsoft.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com> Co-authored-by: Jonathan Turner <jonathandturner@users.noreply.github.com> Co-authored-by: Daniel Rodríguez <sadasant@gmail.com> Co-authored-by: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com> Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com> Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com> Co-authored-by: Sarangan Rajamanickam <sarajama@microsoft.com> Co-authored-by: Jeff Fisher <xirzec@xirzec.com> Co-authored-by: colawwj <70128817+colawwj@users.noreply.github.com> Co-authored-by: Matt Ellis <matell@microsoft.com> Co-authored-by: Daniel Rodríguez <sadasant@users.noreply.github.com> Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com> Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com> Co-authored-by: Dominik <domessin@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com> Co-authored-by: Jeff Fisher <jeffish@microsoft.com> Co-authored-by: Mohsin Mehmood <mohsin85mehmood@gmail.com>

@ignore

* [storage][stg74] swagger update (#11171) * build:autorest * f7425b8 * update service and pacakge versions * queue updateMessage protocol layer breaking change * createPermissionOperationSpec.isXML=false * regenerate with 3360920245f8c06e10f5e349ce3dca5e4d10372e * fix ae-forgotten-export Co-authored-by: Lin Jian <ljian3377@gmail.com> * swagger-regenerate: 196d5c1 * smb multi-channel (#11178) * [Storage] Feature - Recursive ACL (#9689) * Sdk automation/@Azure arm operationalinsights (#10935) * Generated from ba891b7274af8cb22ee173e1998b4145d2d8d98b Adding a point get. * version 4.0.0 Co-authored-by: SDK Automation <sdkautomation@microsoft.com> * Increment package version after release of azure-cosmos (#11311) * [Text Analytics] Ignore document index when parsing opinion pointers (#11302) * [Text Analytics] Ignore Document Index * adding a test * update tests * add recordings * [Text Analytics] Update release date (#11313) * [Text Analytics] Update release date for 5.1.0-beta.1 * format * [core-http] Move challenge based auth to core-http (#11226) * Begin move of challenge-based auth * Begin move of challenge-based auth * Remove keyvault-common * Update paths * Fixing paths after removing keyvault-common * fixed bad dist-esm index.js references * Update paths * Update docs * Add mock tests * Add mock tests Co-authored-by: Daniel Rodríguez <sadasant@gmail.com> * Revert "[core-http] Move challenge based auth to core-http (#11226)" (#11320) This reverts commit 43033ff. * [AnomalyDetector] Update AnomalyDetector README (#11110) * Update AnomalyDetector README * Update pto beta * Update changelog * Address PR comments * Replaced relative link with absolute links and remove locale (#11317) Replaced relative link with absolute links and remove locale * Enable the link check on aggregate-report (#11330) * Increment package version after release of azure-ai-text-analytics (#11315) * [Tables] Enable recorded tests in CI (#11238) * Enable recorded tests in CI * Update test script * Add pollyfill * [Anomaly Detector] Add sample snippet to README (#11335) * Add samples to readme * Update changelog date * [Core-http] Support xml namespaces (#11201) * Prototype xmlns * Update prototype * Additional tests * Address PR comments * formatting * Apply changes to core-client * Address comments * update core-client api-extractor * use getXmlObjectValue * Increment package version after release of azure-ai-anomaly-detector (#11340) * [event-hubs] Update docs to mention the checkpoint store updates made when the subscription is closed. (#11345) As part of investigating #11316 we found it was non-obvious that we would be using the checkpoint store when closing. The reason we use it is when we close the subscription we also mark, in the checkpoint store, that the partitions are abandoned. This lets other consumers more quickly pick up abandoned partitions rather than forcing them to wait for an expiration interval and discover it. Fixes #11316 * Add testcases for handling odata (#11321) * Add testcases for handling odata * Formatting code * PR Comments * Minor Formatting * Update sdk/search/search-documents/src/odata.ts Co-authored-by: Jeff Fisher <xirzec@xirzec.com> * Update sdk/search/search-documents/src/odata.ts Co-authored-by: Jeff Fisher <xirzec@xirzec.com> Co-authored-by: Jeff Fisher <xirzec@xirzec.com> * release arm-netapp (#10849) * release arm-netapp * Generated from efcb7ecf4722c919d5528c53671b124046badcdb update netapp readme.java.md * version change Co-authored-by: SDK Automation <sdkautomation@microsoft.com> * Sdk automation/@Azure arm hybridcompute (#11307) * Generated from a35b1cd98e20d7c9b3c4fdcb23125b7ea85acca6 add alias for auto_rev_minor_version * v2.0.0 Co-authored-by: SDK Automation <sdkautomation@microsoft.com> * [Event Grid] Remove some 'en-us' from some links (#11185) * [Identity] Fix broken eslint in the builds (#11354) * [Identity] Fix broken eslint in the builds * .eslintignore was being ignored * Feedback by Deya * [Abort Controller] Update linting and fix linting errors (#11269) * update linting and fix linting errors * update linting scripts * formatting * fix linting errors * fixes * fix * run api-extractor * include the shim files in shipped files * use the unrolledup type declarations * do not lint package.json * still lint package.json * remove the call to api-extractor from the npm build script * simplify eslint commands * only ship src types * [Identity] Idea for the Device Code Credential Use Console Feature (#11355) * [Identity] Idea for the Device Code Credential Use Console Feature * Feedback by Schaab and Vinay * [Key Vault] Use the swagger generated from the service 7.2-preview (#11370) * swagger reference to 7.2-preview/keys.json * generated update * 7.2 on keys * 7.2 preview on certs and secrets * generated files for secrets and certs * secrets and certs * sticking the swagger change to a specific commit * Add placeholder yml file for pipeline generation * Smoke test failure due to rollup peer dependency error (#11372) * Change to move @rollup/plugin-json as dev dependency * Add client libraries for Azure Communication Services (#11385) * Add Communication service mapping * Communication - Add code owners and label triggers (#11401) * Communication - Add code owners and label triggers * [ESLint Plugin] fix docs link (#11400) * Increment package version after release of azure-keyvault-admin (#11216) * Sync eng/common directory with azure-sdk-tools repository for Tools PR 1022 (#11347) * Disable smoke test for storage-blob-changefeed (#11406) * [Core paging] Update linting scripts and auto linting (#11274) * [Core paging] Update linting scripts and auto linting * formatting changes * addressing Jeff's comments * fixes * turn sideEffects back on * adding comments to address Ramya's feedback * a typo * adding dist-esm/index.js back * Update sdk/core/core-paging/.eslintrc.json Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com> * remove dist-esm/src from files in package.json Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com> * fix package.json (#11412) * [Service Bus] Remove stream-browserify dependency (#11221) * [Core asynciterator] Update linting scripts and apply auto linting and some formatting (#11272) * update linting scripts * edits * turn off relevant rules and lint package.json back * adding .eslintrc.json * [service-bus] Fixing broken option - we renamed it to maxWaitTimeInMs a few previews back. (#11410) * Communication: fix test-resources config (#11434) * [core-http] Add NDJSON support (#11325) * [EventGrid] Add Azure Communication Service Events (#11428) This change adds typings for the new events sent by the Azure Communication Services * Sync eng/common directory with azure-sdk-tools repository for Tools PR 989 (#11214) * [Cosmos] Adding missing copyright headers (#11449) * [Service Bus] Type docs fix - Added @internal and @ignore tags for internal methods (#11427) * logger, isError, toAmqpAnnotatedMessage changed to internal * SubQueue renamed to _SubQueue and changed to internal for jsdoc * Revert "SubQueue renamed to _SubQueue and changed to internal for jsdoc" This reverts commit b97b682. * [Storage] Recursive ACL swagger transform patch * [Storage] Add support for recursive ACL * [Storage] Recording for recursive ACL * [Storage] Update changelog for recursive acl * [Storage] Add comments for recursive ACL parameters; Resolve review comments * Add continueOnFailure option for set AccessControlRecursive methods * Removed PathSetAccessControlRecursiveMode from public API list * Update AccessControlChangeFailure to AccessControlChangeError with typical name and message properties * Resolve build failures * Resolve build failures Co-authored-by: changlong-liu <59815250+changlong-liu@users.noreply.github.com> Co-authored-by: SDK Automation <sdkautomation@microsoft.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com> Co-authored-by: Jonathan Turner <jonathandturner@users.noreply.github.com> Co-authored-by: Daniel Rodríguez <sadasant@gmail.com> Co-authored-by: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com> Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com> Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com> Co-authored-by: Sarangan Rajamanickam <sarajama@microsoft.com> Co-authored-by: Jeff Fisher <xirzec@xirzec.com> Co-authored-by: colawwj <70128817+colawwj@users.noreply.github.com> Co-authored-by: Matt Ellis <matell@microsoft.com> Co-authored-by: Daniel Rodríguez <sadasant@users.noreply.github.com> Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com> Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com> Co-authored-by: Dominik <domessin@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com> Co-authored-by: Jeff Fisher <jeffish@microsoft.com> Co-authored-by: Mohsin Mehmood <mohsin85mehmood@gmail.com> * lastAccessed in BlobDownloadResponse wrapper * [storage][stg74] container restore (#11457) * interface * includeDeleted * [storage][stg74] get file range diff (#11455) * wip * circular dependency * move share, dirctory and file clients to the same file * swagger-regeneration: df297c8 * get file range diff * nit: PR comments * [storage][stg74] quick query new output format "arrow" (#11423) * quick query new outputSerialization "arrow" * for datalake, and remove preprod * [storage][stg74] Delegation SAS v2 and Directory SAS (#11395) * move under sas/ * wip * wip * test wip * autofill directoryDepth * update allow optional messageText (#11258) * [storage][stg74] 4TB file for standard account (#11177) * build:autorest * update service and pacakge versions * createPermissionOperationSpec.isXML=false * test create, resize, uploadRange for 4tb file with a preprod account * record test then manually remove preprod from recording file, fix documentation * update comments 1TB -> 4TB Co-authored-by: Lin Jian <ljian3377@gmail.com> * add set expiry (#11461) Co-authored-by: Lin Jian <ljian3377@gmail.com> * fix merge issue * Continuation Token wrapped with Error when Recursive Acl call is interrupted (#11716) * [storage][stg74] address PR comments (#11520) * wip * overload SASQueryParameters constructor * api extract * Rename leaseTime -> leaseTimeInSeconds * share lease tests * container restore test wip * restore container test fixed * fix CI * make options optional and add comments * [storage][stg74] set file tier (#11735) * format datalake * re-generate file with de8a4f0 * add set share tier * edit import * [storage] temporary fix for issue #11505 (#11737) * temporary fix for issue #11505 * format * update pacakge versions and change log (#11739) * [storage][stg74] fix ci (#11752) * use beta * fix listContainers when include = [] * fix CI * unskip quick query record & support include-leased for x-ms-delete-snapshots (#11754) * Resolve CRI failure (#11756) * fix lease test case * Record RecAcl (#11765) * [storage][stg74] test coverage improvement (#11757) * use preview for blob and use defaultCredential in datalake * use preview subscription for datalake * turn on log * throw when accountName is invalid * CONTAINER_SOFT_DELETE_ * set cors in service properties * PREMIUM_FILE_ * blob remove .only * SOFT_DELETE_ for both blob and share * unskip a tag case * unskip all f,t cases in browser * file use production subscription * add role for datalakeAccount * me * undo datalake roleAssignment * unskip blob delegation SAS cases via using DefaultCredential * add blobDataOwnerRoleId * premiumFileAccountName * me * unskip last access tracking case * me * delegation sas refactor * fix CI * getRangeListDiff .only * run all cases in file * skip getRangeListDiff in live tests * rename and add comments * last access * skip LAT * me * re-record blob delegation SAS cases * modify testutils and re-record * record for browser * me * fix CI and unskip cases * tune setProperties in IE * remove .only Co-authored-by: Lin Jian <ljian3377@gmail.com> Co-authored-by: xiaonlimsft <xiaonli@microsoft.com> Co-authored-by: changlong-liu <59815250+changlong-liu@users.noreply.github.com> Co-authored-by: SDK Automation <sdkautomation@microsoft.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com> Co-authored-by: Jonathan Turner <jonathandturner@users.noreply.github.com> Co-authored-by: Daniel Rodríguez <sadasant@gmail.com> Co-authored-by: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com> Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com> Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com> Co-authored-by: Sarangan Rajamanickam <sarajama@microsoft.com> Co-authored-by: Jeff Fisher <xirzec@xirzec.com> Co-authored-by: colawwj <70128817+colawwj@users.noreply.github.com> Co-authored-by: Matt Ellis <matell@microsoft.com> Co-authored-by: Daniel Rodríguez <sadasant@users.noreply.github.com> Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com> Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com> Co-authored-by: Dominik <domessin@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com> Co-authored-by: Jeff Fisher <jeffish@microsoft.com> Co-authored-by: Mohsin Mehmood <mohsin85mehmood@gmail.com>

Jonathan Turner added 3 commits September 14, 2020 07:58

Begin move of challenge-based auth

d39d154

Begin move of challenge-based auth

b8c7ac1

Remove keyvault-common

05df53a

sophiajt requested review from bterlson, chradek, danieljurek, daviwil, jeremymeng, KarishmaGhiya, mikeharder, mitchdenny, sadasant, weshaggard and xirzec as code owners September 13, 2020 20:51

ghost added Azure.Core KeyVault labels Sep 13, 2020

Update paths

e86d4f7

sadasant approved these changes Sep 14, 2020

View reviewed changes

sadasant reviewed Sep 14, 2020

View reviewed changes

jeremymeng reviewed Sep 14, 2020

View reviewed changes

sdk/core/core-http/review/core-http.api.md Outdated Show resolved Hide resolved

jeremymeng approved these changes Sep 14, 2020

View reviewed changes

xirzec reviewed Sep 14, 2020

View reviewed changes

Merge remote-tracking branch 'Azure/master' into move_challenge_based…

548d148

…_auth

sadasant force-pushed the move_challenge_based_auth branch from f3645cf to 39ac163 Compare September 14, 2020 22:05

Fixing paths after removing keyvault-common

2c27e20

sadasant force-pushed the move_challenge_based_auth branch from 39ac163 to 2c27e20 Compare September 14, 2020 22:09

fixed bad dist-esm index.js references

b73d635

Azure deleted a comment from azure-pipelines bot Sep 14, 2020

Jonathan Turner added 7 commits September 16, 2020 08:00

Update paths

ff22856

Merge branch 'move_challenge_based_auth' of github.com:jonathandturne…

5ca7be4

…r/azure-sdk-for-js into move_challenge_based_auth

Update docs

d54478c

Update docs

63f1aaa

Add mock tests

b88a6a5

Add mock tests

4ae98bd

Merge master, remove old tests

1a92811

sophiajt merged commit 43033ff into Azure:master Sep 17, 2020

sophiajt deleted the move_challenge_based_auth branch September 17, 2020 22:20

sophiajt pushed a commit that referenced this pull request Sep 17, 2020

Revert "[core-http] Move challenge based auth to core-http (#11226)"

7c4d718

This reverts commit 43033ff.

sophiajt mentioned this pull request Sep 17, 2020

Revert "[core-http] Move challenge based auth to core-http" #11320

Merged

sophiajt pushed a commit that referenced this pull request Sep 17, 2020

Revert "[core-http] Move challenge based auth to core-http (#11226)" (#…

f2c3880

…11320) This reverts commit 43033ff.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[core-http] Move challenge based auth to core-http #11226

[core-http] Move challenge based auth to core-http #11226

sophiajt commented Sep 13, 2020 •

edited

Loading

sadasant left a comment

sadasant Sep 14, 2020

sadasant Sep 14, 2020

xirzec Sep 14, 2020

jeremymeng left a comment •

edited

Loading

xirzec left a comment

xirzec Sep 14, 2020

sadasant commented Sep 14, 2020

azure-pipelines bot commented Sep 14, 2020

sadasant commented Sep 14, 2020

azure-pipelines bot commented Sep 14, 2020

sadasant commented Sep 14, 2020

sadasant commented Sep 15, 2020

sadasant commented Sep 15, 2020

sadasant commented Sep 15, 2020

sophiajt commented Sep 17, 2020

[core-http] Move challenge based auth to core-http #11226

[core-http] Move challenge based auth to core-http #11226

Conversation

sophiajt commented Sep 13, 2020 • edited Loading

sadasant left a comment

Choose a reason for hiding this comment

sadasant Sep 14, 2020

Choose a reason for hiding this comment

sadasant Sep 14, 2020

Choose a reason for hiding this comment

xirzec Sep 14, 2020

Choose a reason for hiding this comment

jeremymeng left a comment • edited Loading

Choose a reason for hiding this comment

xirzec left a comment

Choose a reason for hiding this comment

xirzec Sep 14, 2020

Choose a reason for hiding this comment

sadasant commented Sep 14, 2020

azure-pipelines bot commented Sep 14, 2020

sadasant commented Sep 14, 2020

azure-pipelines bot commented Sep 14, 2020

sadasant commented Sep 14, 2020

sadasant commented Sep 15, 2020

sadasant commented Sep 15, 2020

sadasant commented Sep 15, 2020

sophiajt commented Sep 17, 2020

sophiajt commented Sep 13, 2020 •

edited

Loading

jeremymeng left a comment •

edited

Loading