Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Abort Controller] Update linting and fix linting errors #11269

Merged
merged 14 commits into from
Sep 21, 2020
Merged

[Abort Controller] Update linting and fix linting errors #11269

merged 14 commits into from
Sep 21, 2020

Conversation

deyaaeldeen
Copy link
Member

No description provided.

@ghost ghost added the Azure.Core label Sep 15, 2020
xirzec
xirzec approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good; I notice some questionable code that predates your changes that we might want to clean up.

sdk/core/abort-controller/src/AbortController.ts Show resolved Hide resolved
@deyaaeldeen
Copy link
Member Author

/azp run js - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

willmtemple
willmtemple reviewed Sep 16, 2020
View reviewed changes
sdk/core/abort-controller/package.json Outdated Show resolved Hide resolved
sdk/core/abort-controller/package.json Outdated Show resolved Hide resolved
willmtemple
willmtemple reviewed Sep 16, 2020
View reviewed changes
Copy link
Contributor

@willmtemple willmtemple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this is leading to some confusion about what the state of the APi surface should be.

CC @xirzec Some really strange errors are showing up here.

sdk/core/abort-controller/review/abort-controller.api.md Outdated
@@ -9,7 +9,7 @@ export class AbortController {
constructor(parentSignals?: AbortSignalLike[]);
constructor(...parentSignals: AbortSignalLike[]);
abort(): void;
readonly signal: AbortSignal;
get signal(): AbortSignal;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically downlevel TypeScript get accessor signatures to readonly properties. Was that something we were doing on the older types file that didn't get carried in?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize this was an accessor before, yes we should use downlevel-dts here if so

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willmtemple and @xirzec
So to be clear, we should not ship a get accessor at all? if so, why?
If not, would #11319 take care of this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to avoid them since:

  1. They have TS compatibility concerns before/after 3.7
  2. They are harder for developers to reason about, as property accesses are usually assumed to be cheap and without side-effects.

There are times where for compat purposes we can't avoid them (and maybe this is one of those times) but for new code I'd like to steer away from using getters.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I turned off extract-api again. We already have an issue opened for it: #10320.

sdk/core/abort-controller/review/abort-controller.api.md Outdated
addEventListener(_type: "abort", listener: (this: AbortSignalLike, ev: any) => any): void;
static readonly none: AbortSignal;
onabort?: (ev?: Event) => any;
dispatchEvent(_event: Event): boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other four changes seem reasonable if weird, but here dispatchEvent has just appeared out of thin air. Did we modify this signature somewhere to export it?

sdk/core/abort-controller/review/abort-controller.api.md Outdated
onabort?: (ev?: Event) => any;
dispatchEvent(_event: Event): boolean;
static get none(): AbortSignal;
onabort: ((ev?: Event) => any) | null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we change an undefined to null? The change in this signature doesn't seem compatible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also seems like the forward-declaration of Event fell out from shims-public.d.ts. API Extractor doesn't yet support rolling up file-based references, so we'll have to work around it. I think core-http has a solution of some kind, but I can't remember exactly. I think @jeremymeng knows more.

@deyaaeldeen deyaaeldeen merged commit 3495fe3 into Azure:master Sep 21, 2020
@deyaaeldeen deyaaeldeen deleted the abort-linting branch September 21, 2020 20:29
XiaoningLiu added a commit that referenced this pull request Sep 24, 2020
@XiaoningLiu @changlong-liu
@azure-sdk @deyaaeldeen @sadasant @joheredi @sima-zhu @richardpark-msft @sarangan12 @xirzec @colawwj @ellismg @weshaggard @praveenkuttappan @DominikMe @ramya-rao-a @mohsin-mehmood
[Storage] Feature - Recursive ACL (#9689)
47b6b70 
* Sdk automation/@Azure arm operationalinsights (#10935)

* Generated from ba891b7274af8cb22ee173e1998b4145d2d8d98b

Adding a point get.

* version 4.0.0

Co-authored-by: SDK Automation <sdkautomation@microsoft.com>

* Increment package version after release of azure-cosmos (#11311)

* [Text Analytics] Ignore document index when parsing opinion pointers (#11302)

* [Text Analytics] Ignore Document Index

* adding a test

* update tests

* add recordings

* [Text Analytics] Update release date (#11313)

* [Text Analytics] Update release date for 5.1.0-beta.1

* format

* [core-http] Move challenge based auth to core-http (#11226)

* Begin move of challenge-based auth

* Begin move of challenge-based auth

* Remove keyvault-common

* Update paths

* Fixing paths after removing keyvault-common

* fixed bad dist-esm index.js references

* Update paths

* Update docs

* Add mock tests

* Add mock tests

Co-authored-by: Daniel Rodríguez <sadasant@gmail.com>

* Revert "[core-http] Move challenge based auth to core-http (#11226)" (#11320)

This reverts commit 43033ff.

* [AnomalyDetector] Update AnomalyDetector README (#11110)

* Update AnomalyDetector README

* Update pto beta

* Update changelog

* Address PR comments

* Replaced relative link with absolute links and remove locale (#11317)

Replaced relative link with absolute links and remove locale

* Enable the link check on aggregate-report (#11330)

* Increment package version after release of azure-ai-text-analytics (#11315)

* [Tables] Enable recorded tests in CI (#11238)

* Enable recorded tests in CI

* Update test script

* Add pollyfill

* [Anomaly Detector] Add sample snippet to README (#11335)

* Add samples to readme

* Update changelog date

* [Core-http] Support xml namespaces (#11201)

* Prototype xmlns

* Update prototype

* Additional tests

* Address PR comments

* formatting

* Apply changes to core-client

* Address  comments

* update core-client api-extractor

* use getXmlObjectValue

* Increment package version after release of azure-ai-anomaly-detector (#11340)

* [event-hubs] Update docs to mention the checkpoint store updates made when the subscription is closed. (#11345)

As part of investigating #11316 we found it was non-obvious that we would be using the checkpoint store when closing. 

The reason we use it is when we close the subscription we also mark, in the checkpoint store, that the partitions are abandoned. This lets other consumers more quickly pick up abandoned partitions rather than forcing them to wait for an expiration interval and discover it.

Fixes #11316

* Add testcases for handling odata (#11321)

* Add testcases for handling odata

* Formatting code

* PR Comments

* Minor Formatting

* Update sdk/search/search-documents/src/odata.ts

Co-authored-by: Jeff Fisher <xirzec@xirzec.com>

* Update sdk/search/search-documents/src/odata.ts

Co-authored-by: Jeff Fisher <xirzec@xirzec.com>

Co-authored-by: Jeff Fisher <xirzec@xirzec.com>

* release arm-netapp (#10849)

* release arm-netapp

* Generated from efcb7ecf4722c919d5528c53671b124046badcdb

update netapp readme.java.md

* version change

Co-authored-by: SDK Automation <sdkautomation@microsoft.com>

* Sdk automation/@Azure arm hybridcompute (#11307)

* Generated from a35b1cd98e20d7c9b3c4fdcb23125b7ea85acca6

add alias for auto_rev_minor_version

* v2.0.0

Co-authored-by: SDK Automation <sdkautomation@microsoft.com>

* [Event Grid] Remove some 'en-us' from some links (#11185)

* [Identity] Fix broken eslint in the builds (#11354)

* [Identity] Fix broken eslint in the builds

* .eslintignore was being ignored

* Feedback by Deya

* [Abort Controller] Update linting and fix linting errors (#11269)

* update linting and fix linting errors

* update linting scripts

* formatting

* fix linting errors

* fixes

* fix

* run api-extractor

* include the shim files in shipped files

* use the unrolledup type declarations

* do not lint package.json

* still lint package.json

* remove the call to api-extractor from the npm build script

* simplify eslint commands

* only ship src types

* [Identity] Idea for the Device Code Credential Use Console Feature (#11355)

* [Identity] Idea for the Device Code Credential Use Console Feature

* Feedback by Schaab and Vinay

* [Key Vault] Use the swagger generated from the service 7.2-preview (#11370)

* swagger reference to 7.2-preview/keys.json

* generated update

* 7.2 on keys

* 7.2 preview on certs and secrets

* generated files for secrets and certs

* secrets and certs

* sticking the swagger change to a specific commit

* Add placeholder yml file for pipeline generation

* Smoke test failure due to rollup peer dependency error (#11372)

* Change to move @rollup/plugin-json as dev dependency

* Add client libraries for Azure Communication Services (#11385)

* Add Communication service mapping

* Communication - Add code owners and label triggers (#11401)

* Communication - Add code owners and label triggers

* [ESLint Plugin] fix docs link (#11400)

* Increment package version after release of azure-keyvault-admin (#11216)

* Sync eng/common directory with azure-sdk-tools repository for Tools PR 1022 (#11347)

* Disable smoke test for storage-blob-changefeed (#11406)

* [Core paging] Update linting scripts and auto linting (#11274)

* [Core paging] Update linting scripts and auto linting

* formatting changes

* addressing Jeff's comments

* fixes

* turn sideEffects back on

* adding comments to address Ramya's feedback

* a typo

* adding dist-esm/index.js back

* Update sdk/core/core-paging/.eslintrc.json

Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>

* remove dist-esm/src from files in package.json

Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>

* fix package.json (#11412)

* [Service Bus] Remove stream-browserify dependency (#11221)

* [Core asynciterator] Update linting scripts and apply auto linting and some formatting (#11272)

* update linting scripts

* edits

* turn off relevant rules and lint package.json back

* adding .eslintrc.json

* [service-bus] Fixing broken option - we renamed it to maxWaitTimeInMs a few previews back. (#11410)

* Communication: fix test-resources config (#11434)

* [core-http] Add NDJSON support (#11325)

* [EventGrid] Add Azure Communication Service Events (#11428)

This change adds typings for the new events sent by the Azure
Communication Services

* Sync eng/common directory with azure-sdk-tools repository for Tools PR 989 (#11214)

* [Cosmos] Adding missing copyright headers (#11449)

* [Service Bus] Type docs fix - Added @internal and @ignore tags for internal methods (#11427)

* logger, isError, toAmqpAnnotatedMessage changed to internal

* SubQueue renamed to _SubQueue and changed to internal for jsdoc

* Revert "SubQueue renamed to _SubQueue and changed to internal for jsdoc"

This reverts commit b97b682.

* [Storage] Recursive ACL swagger transform patch

* [Storage] Add support for recursive ACL

* [Storage] Recording for recursive ACL

* [Storage] Update changelog for recursive acl

* [Storage] Add comments for recursive ACL parameters; Resolve review comments

* Add continueOnFailure option for set AccessControlRecursive methods

* Removed PathSetAccessControlRecursiveMode from public API list

* Update AccessControlChangeFailure to AccessControlChangeError with typical name and message properties

* Resolve build failures

* Resolve build failures

Co-authored-by: changlong-liu <59815250+changlong-liu@users.noreply.github.com>
Co-authored-by: SDK Automation <sdkautomation@microsoft.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Co-authored-by: Jonathan Turner <jonathandturner@users.noreply.github.com>
Co-authored-by: Daniel Rodríguez <sadasant@gmail.com>
Co-authored-by: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com>
Co-authored-by: Sarangan Rajamanickam <sarajama@microsoft.com>
Co-authored-by: Jeff Fisher <xirzec@xirzec.com>
Co-authored-by: colawwj <70128817+colawwj@users.noreply.github.com>
Co-authored-by: Matt Ellis <matell@microsoft.com>
Co-authored-by: Daniel Rodríguez <sadasant@users.noreply.github.com>
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
Co-authored-by: Dominik <domessin@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
Co-authored-by: Jeff Fisher <jeffish@microsoft.com>
Co-authored-by: Mohsin Mehmood <mohsin85mehmood@gmail.com>
ljian3377 added a commit that referenced this pull request Oct 13, 2020
@ljian3377 @XiaoningLiu
@changlong-liu @azure-sdk @deyaaeldeen @sadasant @joheredi @sima-zhu @richardpark-msft @sarangan12 @xirzec @colawwj @ellismg @weshaggard @praveenkuttappan @DominikMe @ramya-rao-a @mohsin-mehmood
[storage] stg74 (#11459)
0a567a0 
* [storage][stg74] swagger update (#11171)

* build:autorest

* f7425b8

* update service and pacakge versions

* queue updateMessage protocol layer breaking change

* createPermissionOperationSpec.isXML=false

* regenerate with 3360920245f8c06e10f5e349ce3dca5e4d10372e

* fix ae-forgotten-export

Co-authored-by: Lin Jian <ljian3377@gmail.com>

* swagger-regenerate: 196d5c1

* smb multi-channel (#11178)

* [Storage] Feature - Recursive ACL (#9689)

* Sdk automation/@Azure arm operationalinsights (#10935)

* Generated from ba891b7274af8cb22ee173e1998b4145d2d8d98b

Adding a point get.

* version 4.0.0

Co-authored-by: SDK Automation <sdkautomation@microsoft.com>

* Increment package version after release of azure-cosmos (#11311)

* [Text Analytics] Ignore document index when parsing opinion pointers (#11302)

* [Text Analytics] Ignore Document Index

* adding a test

* update tests

* add recordings

* [Text Analytics] Update release date (#11313)

* [Text Analytics] Update release date for 5.1.0-beta.1

* format

* [core-http] Move challenge based auth to core-http (#11226)

* Begin move of challenge-based auth

* Begin move of challenge-based auth

* Remove keyvault-common

* Update paths

* Fixing paths after removing keyvault-common

* fixed bad dist-esm index.js references

* Update paths

* Update docs

* Add mock tests

* Add mock tests

Co-authored-by: Daniel Rodríguez <sadasant@gmail.com>

* Revert "[core-http] Move challenge based auth to core-http (#11226)" (#11320)

This reverts commit 43033ff.

* [AnomalyDetector] Update AnomalyDetector README (#11110)

* Update AnomalyDetector README

* Update pto beta

* Update changelog

* Address PR comments

* Replaced relative link with absolute links and remove locale (#11317)

Replaced relative link with absolute links and remove locale

* Enable the link check on aggregate-report (#11330)

* Increment package version after release of azure-ai-text-analytics (#11315)

* [Tables] Enable recorded tests in CI (#11238)

* Enable recorded tests in CI

* Update test script

* Add pollyfill

* [Anomaly Detector] Add sample snippet to README (#11335)

* Add samples to readme

* Update changelog date

* [Core-http] Support xml namespaces (#11201)

* Prototype xmlns

* Update prototype

* Additional tests

* Address PR comments

* formatting

* Apply changes to core-client

* Address  comments

* update core-client api-extractor

* use getXmlObjectValue

* Increment package version after release of azure-ai-anomaly-detector (#11340)

* [event-hubs] Update docs to mention the checkpoint store updates made when the subscription is closed. (#11345)

As part of investigating #11316 we found it was non-obvious that we would be using the checkpoint store when closing. 

The reason we use it is when we close the subscription we also mark, in the checkpoint store, that the partitions are abandoned. This lets other consumers more quickly pick up abandoned partitions rather than forcing them to wait for an expiration interval and discover it.

Fixes #11316

* Add testcases for handling odata (#11321)

* Add testcases for handling odata

* Formatting code

* PR Comments

* Minor Formatting

* Update sdk/search/search-documents/src/odata.ts

Co-authored-by: Jeff Fisher <xirzec@xirzec.com>

* Update sdk/search/search-documents/src/odata.ts

Co-authored-by: Jeff Fisher <xirzec@xirzec.com>

Co-authored-by: Jeff Fisher <xirzec@xirzec.com>

* release arm-netapp (#10849)

* release arm-netapp

* Generated from efcb7ecf4722c919d5528c53671b124046badcdb

update netapp readme.java.md

* version change

Co-authored-by: SDK Automation <sdkautomation@microsoft.com>

* Sdk automation/@Azure arm hybridcompute (#11307)

* Generated from a35b1cd98e20d7c9b3c4fdcb23125b7ea85acca6

add alias for auto_rev_minor_version

* v2.0.0

Co-authored-by: SDK Automation <sdkautomation@microsoft.com>

* [Event Grid] Remove some 'en-us' from some links (#11185)

* [Identity] Fix broken eslint in the builds (#11354)

* [Identity] Fix broken eslint in the builds

* .eslintignore was being ignored

* Feedback by Deya

* [Abort Controller] Update linting and fix linting errors (#11269)

* update linting and fix linting errors

* update linting scripts

* formatting

* fix linting errors

* fixes

* fix

* run api-extractor

* include the shim files in shipped files

* use the unrolledup type declarations

* do not lint package.json

* still lint package.json

* remove the call to api-extractor from the npm build script

* simplify eslint commands

* only ship src types

* [Identity] Idea for the Device Code Credential Use Console Feature (#11355)

* [Identity] Idea for the Device Code Credential Use Console Feature

* Feedback by Schaab and Vinay

* [Key Vault] Use the swagger generated from the service 7.2-preview (#11370)

* swagger reference to 7.2-preview/keys.json

* generated update

* 7.2 on keys

* 7.2 preview on certs and secrets

* generated files for secrets and certs

* secrets and certs

* sticking the swagger change to a specific commit

* Add placeholder yml file for pipeline generation

* Smoke test failure due to rollup peer dependency error (#11372)

* Change to move @rollup/plugin-json as dev dependency

* Add client libraries for Azure Communication Services (#11385)

* Add Communication service mapping

* Communication - Add code owners and label triggers (#11401)

* Communication - Add code owners and label triggers

* [ESLint Plugin] fix docs link (#11400)

* Increment package version after release of azure-keyvault-admin (#11216)

* Sync eng/common directory with azure-sdk-tools repository for Tools PR 1022 (#11347)

* Disable smoke test for storage-blob-changefeed (#11406)

* [Core paging] Update linting scripts and auto linting (#11274)

* [Core paging] Update linting scripts and auto linting

* formatting changes

* addressing Jeff's comments

* fixes

* turn sideEffects back on

* adding comments to address Ramya's feedback

* a typo

* adding dist-esm/index.js back

* Update sdk/core/core-paging/.eslintrc.json

Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>

* remove dist-esm/src from files in package.json

Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>

* fix package.json (#11412)

* [Service Bus] Remove stream-browserify dependency (#11221)

* [Core asynciterator] Update linting scripts and apply auto linting and some formatting (#11272)

* update linting scripts

* edits

* turn off relevant rules and lint package.json back

* adding .eslintrc.json

* [service-bus] Fixing broken option - we renamed it to maxWaitTimeInMs a few previews back. (#11410)

* Communication: fix test-resources config (#11434)

* [core-http] Add NDJSON support (#11325)

* [EventGrid] Add Azure Communication Service Events (#11428)

This change adds typings for the new events sent by the Azure
Communication Services

* Sync eng/common directory with azure-sdk-tools repository for Tools PR 989 (#11214)

* [Cosmos] Adding missing copyright headers (#11449)

* [Service Bus] Type docs fix - Added @internal and @ignore tags for internal methods (#11427)

* logger, isError, toAmqpAnnotatedMessage changed to internal

* SubQueue renamed to _SubQueue and changed to internal for jsdoc

* Revert "SubQueue renamed to _SubQueue and changed to internal for jsdoc"

This reverts commit b97b682.

* [Storage] Recursive ACL swagger transform patch

* [Storage] Add support for recursive ACL

* [Storage] Recording for recursive ACL

* [Storage] Update changelog for recursive acl

* [Storage] Add comments for recursive ACL parameters; Resolve review comments

* Add continueOnFailure option for set AccessControlRecursive methods

* Removed PathSetAccessControlRecursiveMode from public API list

* Update AccessControlChangeFailure to AccessControlChangeError with typical name and message properties

* Resolve build failures

* Resolve build failures

Co-authored-by: changlong-liu <59815250+changlong-liu@users.noreply.github.com>
Co-authored-by: SDK Automation <sdkautomation@microsoft.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Co-authored-by: Jonathan Turner <jonathandturner@users.noreply.github.com>
Co-authored-by: Daniel Rodríguez <sadasant@gmail.com>
Co-authored-by: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com>
Co-authored-by: Sarangan Rajamanickam <sarajama@microsoft.com>
Co-authored-by: Jeff Fisher <xirzec@xirzec.com>
Co-authored-by: colawwj <70128817+colawwj@users.noreply.github.com>
Co-authored-by: Matt Ellis <matell@microsoft.com>
Co-authored-by: Daniel Rodríguez <sadasant@users.noreply.github.com>
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
Co-authored-by: Dominik <domessin@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
Co-authored-by: Jeff Fisher <jeffish@microsoft.com>
Co-authored-by: Mohsin Mehmood <mohsin85mehmood@gmail.com>

* lastAccessed in BlobDownloadResponse wrapper

* [storage][stg74] container restore (#11457)

* interface

* includeDeleted

* [storage][stg74] get file range diff (#11455)

* wip

* circular dependency

* move share, dirctory and file clients to the same file

* swagger-regeneration: df297c8

* get file range diff

* nit: PR comments

* [storage][stg74] quick query new output format "arrow" (#11423)

* quick query new outputSerialization "arrow"

* for datalake, and remove preprod

* [storage][stg74] Delegation SAS v2 and Directory SAS (#11395)

* move under sas/

* wip

* wip

* test wip

* autofill directoryDepth

* update allow optional messageText (#11258)

* [storage][stg74] 4TB file for standard account (#11177)

* build:autorest

* update service and pacakge versions

* createPermissionOperationSpec.isXML=false

* test create, resize, uploadRange for 4tb file with a preprod account

* record test then manually remove preprod from recording file, fix documentation

* update comments 1TB -> 4TB

Co-authored-by: Lin Jian <ljian3377@gmail.com>

* add set expiry (#11461)

Co-authored-by: Lin Jian <ljian3377@gmail.com>

* fix merge issue

* Continuation Token wrapped with Error when Recursive Acl call is interrupted (#11716)

* [storage][stg74] address PR comments (#11520)

* wip

* overload SASQueryParameters constructor

* api extract

* Rename leaseTime -> leaseTimeInSeconds

* share lease tests

* container restore test wip

* restore container test fixed

* fix CI

* make options optional and add comments

* [storage][stg74] set file tier (#11735)

* format datalake

* re-generate file with de8a4f0

* add set share tier

* edit import

* [storage] temporary fix for issue #11505 (#11737)

* temporary fix for issue #11505

* format

* update pacakge versions and change log (#11739)

* [storage][stg74] fix ci (#11752)

* use beta

* fix listContainers when include = []

* fix CI

* unskip quick query record & support include-leased for x-ms-delete-snapshots (#11754)

* Resolve CRI failure (#11756)

* fix lease test case

* Record RecAcl (#11765)

* [storage][stg74] test coverage improvement (#11757)

* use preview for blob and use defaultCredential in datalake

* use preview subscription for datalake

* turn on log

* throw when accountName is invalid

* CONTAINER_SOFT_DELETE_

* set cors in service properties

* PREMIUM_FILE_

* blob remove .only

* SOFT_DELETE_ for both blob and share

* unskip a tag case

* unskip all f,t cases in browser

* file use production subscription

* add role for datalakeAccount

* me

* undo datalake roleAssignment

* unskip blob delegation SAS cases via using DefaultCredential

* add blobDataOwnerRoleId

* premiumFileAccountName

* me

* unskip last access tracking case

* me

* delegation sas refactor

* fix CI

* getRangeListDiff .only

* run all cases in file

* skip getRangeListDiff in live tests

* rename and add comments

* last access

* skip LAT

* me

* re-record blob delegation SAS cases

* modify testutils and re-record

* record for browser

* me

* fix CI and unskip cases

* tune setProperties in IE

* remove .only

Co-authored-by: Lin Jian <ljian3377@gmail.com>
Co-authored-by: xiaonlimsft <xiaonli@microsoft.com>
Co-authored-by: changlong-liu <59815250+changlong-liu@users.noreply.github.com>
Co-authored-by: SDK Automation <sdkautomation@microsoft.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Co-authored-by: Jonathan Turner <jonathandturner@users.noreply.github.com>
Co-authored-by: Daniel Rodríguez <sadasant@gmail.com>
Co-authored-by: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com>
Co-authored-by: Sarangan Rajamanickam <sarajama@microsoft.com>
Co-authored-by: Jeff Fisher <xirzec@xirzec.com>
Co-authored-by: colawwj <70128817+colawwj@users.noreply.github.com>
Co-authored-by: Matt Ellis <matell@microsoft.com>
Co-authored-by: Daniel Rodríguez <sadasant@users.noreply.github.com>
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
Co-authored-by: Dominik <domessin@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
Co-authored-by: Jeff Fisher <jeffish@microsoft.com>
Co-authored-by: Mohsin Mehmood <mohsin85mehmood@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xirzec xirzec xirzec approved these changes

@willmtemple willmtemple willmtemple left review comments

@ramya-rao-a ramya-rao-a ramya-rao-a approved these changes

@bterlson bterlson Awaiting requested review from bterlson

@chradek chradek Awaiting requested review from chradek

Assignees
No one assigned
Labels
Azure.Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deyaaeldeen @xirzec @willmtemple @ramya-rao-a