[Key Vault Keys] Add new algorithms #11380
Conversation
ghost
added
the
| @@ -737,33 +742,3 @@ export class CryptographyClient { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Options for {@link encrypt}. | |||
There was a problem hiding this comment.
I moved these from this file to the models file. It made more sense to me.
| @@ -137,3 +154,52 @@ export interface VerifyResult { | |||
| */ | |||
| keyID?: string; | |||
| } | |||
|
|
|||
| /** | |||
| * Common optional properties for encrypt, decrypt, wrap and unwrap. | |||
There was a problem hiding this comment.
I moved these from this file to the models file. It made more sense to me.
| @@ -184,6 +184,13 @@ export type KeyCurveName = "P-256" | "P-384" | "P-521" | "P-256K"; | |||
| // @public | |||
| export type KeyOperation = "encrypt" | "decrypt" | "sign" | "verify" | "wrapKey" | "unwrapKey" | "import"; | |||
|
|
|||
| // @public | |||
| export interface KeyOperationsOptions extends CryptographyOptions { | |||
| aad?: Uint8Array; | |||
There was a problem hiding this comment.
Should be additionalAuthenticatedData.
There was a problem hiding this comment.
additionalAuthenticatedData is way better! Thank you!
|
@heaths thank you! |
| @@ -107,6 +107,7 @@ describe("CryptographyClient (all decrypts happen remotely)", () => { | |||
| const hash = createHash("sha256"); | |||
| hash.update(signatureValue); | |||
| const digest = hash.digest(); | |||
| console.log({ digest }); | |||
There was a problem hiding this comment.
this seems like something not meant to be left in?
There was a problem hiding this comment.
Oh my bad, thank you!
| @@ -148,6 +153,10 @@ export class CryptographyClient { | |||
| } | |||
| } | |||
|
|
|||
| // Renaming parameters | |||
|
|
|||
| requestOptions.aad = options.additionalAuthenticatedData; | |||
There was a problem hiding this comment.
why do we have to do this? Feels like a swagger transform could make the generated client take the better name.
There was a problem hiding this comment.
Thank you! I'll try with something like this: https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/textanalytics/ai-text-analytics/swagger/README.md
* [Key Vault Keys] Add new algorithms * seems like this was necessary. Not sure how I didnt catch it before * Renamed aad as additionalAuthenticatedData * formatting * this seems better * API changes after recent feedback * lint fix * swagger property rename WIP * generated changes * removed console.log
This PR only adds the new algorithms from v7.2.
I'll add the tests as part of another PR. I'll keep track of that through this issue: #11396
Closes: #11260