Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Event Hub] Use our ESLint plugin #11468

Merged
merged 3 commits into from
Sep 24, 2020
Merged

[Event Hub] Use our ESLint plugin #11468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fe3da8
[Event Hub] Use our ESLint plugin
deyaaeldeen Sep 24, 2020
cfaa7dc
remove it from the config file
deyaaeldeen Sep 24, 2020
9f53591
improve lint command
deyaaeldeen Sep 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/eventhub/event-processor-host/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"plugins": ["@azure/azure-sdk"],
"extends": ["../../.eslintrc.old.json", "plugin:@azure/azure-sdk/recommended"],
deyaaeldeen marked this conversation as resolved.
Show resolved Hide resolved
"extends": ["plugin:@azure/azure-sdk/recommended"],
"parserOptions": {
"createDefaultProgram": true
}
Expand Down
5 changes: 3 additions & 2 deletions sdk/eventhub/eventhubs-checkpointstore-blob/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@
"integration-test:browser": "echo skipped",
"integration-test:node": "nyc mocha -r esm --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 1200000 --full-trace dist-esm/test/*.spec.js",
"integration-test": "npm run integration-test:node && npm run integration-test:browser",
"lint:fix": "eslint -c ../../.eslintrc.old.json src test --ext .ts --fix",
"lint": "eslint -c ../../.eslintrc.old.json src test --ext .ts -f html -o event-hubs-lintReport.html || exit 0",
"lint:fix": "eslint package.json api-extractor.json src test --ext .ts --fix",
"lint": "eslint package.json api-extractor.json src test --ext .ts -f html -o event-hubs-lintReport.html || exit 0",
"pack": "npm pack 2>&1",
"prebuild": "npm run clean",
"test:browser": "npm run build:test && npm run unit-test:browser && npm run integration-test:browser",
Expand All @@ -66,6 +66,7 @@
"tslib": "^2.0.0"
},
"devDependencies": {
"@azure/eslint-plugin-azure-sdk": "^3.0.0",
"@microsoft/api-extractor": "7.7.11",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-inject": "^4.0.0",
Expand Down