Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev-tool] Fix relative import of prettier options. #14560

Merged
merged 1 commit into from
Mar 26, 2021
Merged

[dev-tool] Fix relative import of prettier options. #14560

merged 1 commit into from
Mar 26, 2021

Conversation

witemple-msft
Copy link
Member

The import path isn't quite correct and ts-to-js throws.

@witemple-msft witemple-msft self-assigned this Mar 26, 2021
deyaaeldeen
deyaaeldeen approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a hunch my change would not work because require is dynamically called and indeed this is the case. Thanks for the fix! Please consider adding integration tests in this PR or in another.

@witemple-msft
Copy link
Member Author

Going to add a few tests for this in a different PR. Merging this to unblock samples publish.

@witemple-msft witemple-msft merged commit d6dd0d3 into Azure:master Mar 26, 2021
jay-most pushed a commit to jay-most/azure-sdk-for-js that referenced this pull request Apr 26, 2021
@witemple-msft @vindicatesociety
[dev-tool] Fix relative import of prettier options. (Azure#14560)
1b535b5
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Jul 29, 2021
CodeGen from PR 14560 in Azure/azure-rest-api-specs
442293d 
Exposing reviewers property on accessReviewInstance model (Azure#14560)

* Cloning version 2021-07-01-preview from version 2021-03-01-preview

* Exposing reviewers properties on accessReviewInstance model

* Fixing SDK validation warnings

* Prettier check fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deyaaeldeen deyaaeldeen deyaaeldeen approved these changes

@mikeharder mikeharder Awaiting requested review from mikeharder

@praveenkuttappan praveenkuttappan Awaiting requested review from praveenkuttappan

Assignees

@witemple-msft witemple-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witemple-msft @deyaaeldeen