CodeGen from PR 14560 in Azure/azure-rest-api-specs

Exposing reviewers property on accessReviewInstance model (Azure#14560)

* Cloning version 2021-07-01-preview from version 2021-03-01-preview

* Exposing reviewers properties on accessReviewInstance model

* Fixing SDK validation warnings

* Prettier check fixes

sdk/authorization/arm-authorization/LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2019 Microsoft
+Copyright (c) 2021 Microsoft
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

sdk/authorization/arm-authorization/README.md

@@ -1,11 +1,11 @@
 ## Azure AuthorizationManagementClient SDK for JavaScript
 
-This package contains an isomorphic SDK (runs both in Node.js and in browsers) for AuthorizationManagementClient.
+This package contains an isomorphic SDK (runs both in node.js and in browsers) for AuthorizationManagementClient.
 
 ### Currently supported environments
 
 - [LTS versions of Node.js](https://nodejs.org/about/releases/)
-- Latest versions of Safari, Chrome, Edge, and Firefox.
+- Latest versions of Safari, Chrome, Edge and Firefox.
 
 ### Prerequisites
 
@@ -21,7 +21,6 @@ Install both packages using the below command:
 ```bash
 npm install --save @azure/arm-authorization @azure/identity
 ```
-
 > **Note**: You may have used either `@azure/ms-rest-nodeauth` or `@azure/ms-rest-browserauth` in the past. These packages are in maintenance mode receiving critical bug fixes, but no new features.
 If you are on a [Node.js that has LTS status](https://nodejs.org/about/releases/), or are writing a client side browser application, we strongly encourage you to upgrade to `@azure/identity` which uses the latest versions of Azure Active Directory and MSAL APIs and provides more authentication options.
 
@@ -37,8 +36,7 @@ If you are on a [Node.js that has LTS status](https://nodejs.org/about/releases/
 
 In the below samples, we pass the credential and the Azure subscription id to instantiate the client.
 Once the client is created, explore the operations on it either in your favorite editor or in our [API reference documentation](https://docs.microsoft.com/javascript/api) to get started.
-
-#### nodejs - Authentication, client creation, and list classicAdministrators as an example written in JavaScript.
+#### nodejs - Authentication, client creation, and listForResource roleAssignments as an example written in JavaScript.
 
 ##### Sample code
 
@@ -51,8 +49,14 @@ const subscriptionId = process.env["AZURE_SUBSCRIPTION_ID"];
 // Please note that you can also use credentials from the `@azure/ms-rest-nodeauth` package instead.
 const creds = new DefaultAzureCredential();
 const client = new AuthorizationManagementClient(creds, subscriptionId);
-
-client.classicAdministrators.list().then((result) => {
+const resourceGroupName = "testresourceGroupName";
+const resourceProviderNamespace = "testresourceProviderNamespace";
+const parentResourcePath = "testparentResourcePath";
+const resourceType = "testresourceType";
+const resourceName = "testresourceName";
+const filter = "testfilter";
+const tenantId = "testtenantId";
+client.roleAssignments.listForResource(resourceGroupName, resourceProviderNamespace, parentResourcePath, resourceType, resourceName, filter, tenantId).then((result) => {
   console.log("The result is:");
   console.log(result);
 }).catch((err) => {
@@ -61,7 +65,7 @@ client.classicAdministrators.list().then((result) => {
 });
 ```
 
-#### browser - Authentication, client creation, and list classicAdministrators as an example written in JavaScript.
+#### browser - Authentication, client creation, and listForResource roleAssignments as an example written in JavaScript.
 
 In browser applications, we recommend using the `InteractiveBrowserCredential` that interactively authenticates using the default system browser.
   - See [Single-page application: App registration guide](https://docs.microsoft.com/azure/active-directory/develop/scenario-spa-app-registration) to configure your app registration for the browser.
@@ -86,10 +90,17 @@ In browser applications, we recommend using the `InteractiveBrowserCredential` t
       const credential = new InteractiveBrowserCredential(
       {
         clientId: "<client id for your Azure AD app>",
-        tenantId: "<optional tenant for your organization>"
+        tenant: "<optional tenant for your organization>"
       });
       const client = new Azure.ArmAuthorization.AuthorizationManagementClient(creds, subscriptionId);
-      client.classicAdministrators.list().then((result) => {
+      const resourceGroupName = "testresourceGroupName";
+      const resourceProviderNamespace = "testresourceProviderNamespace";
+      const parentResourcePath = "testparentResourcePath";
+      const resourceType = "testresourceType";
+      const resourceName = "testresourceName";
+      const filter = "testfilter";
+      const tenantId = "testtenantId";
+      client.roleAssignments.listForResource(resourceGroupName, resourceProviderNamespace, parentResourcePath, resourceType, resourceName, filter, tenantId).then((result) => {
         console.log("The result is:");
         console.log(result);
       }).catch((err) => {

sdk/authorization/arm-authorization/package.json

@@ -7,7 +7,7 @@
     "@azure/ms-rest-azure-js": "^2.1.0",
     "@azure/ms-rest-js": "^2.2.0",
     "@azure/core-auth": "^1.1.4",
-    "tslib": "^1.9.3"
+    "tslib": "^1.10.0"
   },
   "keywords": [
     "node",
@@ -22,12 +22,12 @@
   "types": "./esm/authorizationManagementClient.d.ts",
   "devDependencies": {
     "typescript": "^3.6.0",
-    "rollup": "^0.66.2",
-    "rollup-plugin-node-resolve": "^3.4.0",
+    "rollup": "^1.18.0",
+    "rollup-plugin-node-resolve": "^5.2.0",
     "rollup-plugin-sourcemaps": "^0.4.2",
-    "uglify-js": "^3.4.9"
+    "uglify-js": "^3.6.0"
   },
-  "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/authorization/arm-authorization",
+  "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/authorization/arm-authorization",
   "repository": {
     "type": "git",
     "url": "https://github.com/Azure/azure-sdk-for-js.git"

sdk/authorization/arm-authorization/rollup.config.js

@@ -21,15 +21,15 @@ const config = {
       "@azure/ms-rest-azure-js": "msRestAzure"
     },
     banner: `/*
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for license information.
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
  * Changes may cause incorrect behavior and will be lost if the code is regenerated.
  */`
   },
   plugins: [
-    nodeResolve({ module: true }),
+    nodeResolve({ mainFields: ['module', 'main'] }),
     sourcemaps()
   ]
 };

sdk/authorization/arm-authorization/src/authorizationManagementClient.ts

@@ -1,7 +1,6 @@
 /*
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for
- * license information.
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
  * Changes may cause incorrect behavior and will be lost if the code is
@@ -18,13 +17,7 @@ import { AuthorizationManagementClientContext } from "./authorizationManagementC
 
 class AuthorizationManagementClient extends AuthorizationManagementClientContext {
   // Operation groups
-  classicAdministrators: operations.ClassicAdministrators;
-  globalAdministrator: operations.GlobalAdministrator;
-  providerOperationsMetadata: operations.ProviderOperationsMetadataOperations;
   roleAssignments: operations.RoleAssignments;
-  permissions: operations.Permissions;
-  roleDefinitions: operations.RoleDefinitions;
-  denyAssignments: operations.DenyAssignments;
 
   /**
    * Initializes a new instance of the AuthorizationManagementClient class.
@@ -39,13 +32,7 @@ class AuthorizationManagementClient extends AuthorizationManagementClientContext
    */
   constructor(credentials: msRest.ServiceClientCredentials | TokenCredential, subscriptionId: string, options?: Models.AuthorizationManagementClientOptions) {
     super(credentials, subscriptionId, options);
-    this.classicAdministrators = new operations.ClassicAdministrators(this);
-    this.globalAdministrator = new operations.GlobalAdministrator(this);
-    this.providerOperationsMetadata = new operations.ProviderOperationsMetadataOperations(this);
     this.roleAssignments = new operations.RoleAssignments(this);
-    this.permissions = new operations.Permissions(this);
-    this.roleDefinitions = new operations.RoleDefinitions(this);
-    this.denyAssignments = new operations.DenyAssignments(this);
   }
 }
 

sdk/authorization/arm-authorization/src/authorizationManagementClientContext.ts

@@ -1,7 +1,6 @@
 /*
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for
- * license information.
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
  * Changes may cause incorrect behavior and will be lost if the code is
@@ -10,14 +9,15 @@
 
 import * as Models from "./models";
 import * as msRest from "@azure/ms-rest-js";
-import { TokenCredential } from "@azure/core-auth";
 import * as msRestAzure from "@azure/ms-rest-azure-js";
+import { TokenCredential } from "@azure/core-auth";
 
 const packageName = "@azure/arm-authorization";
 const packageVersion = "8.4.0";
 
 export class AuthorizationManagementClientContext extends msRestAzure.AzureServiceClient {
   credentials: msRest.ServiceClientCredentials | TokenCredential;
+  apiVersion?: string;
   subscriptionId: string;
 
   /**
@@ -42,24 +42,25 @@ export class AuthorizationManagementClientContext extends msRestAzure.AzureServi
     if (!options) {
       options = {};
     }
-    if(!options.userAgent) {
+    if (!options.userAgent) {
       const defaultUserAgent = msRestAzure.getDefaultUserAgentValue();
       options.userAgent = `${packageName}/${packageVersion} ${defaultUserAgent}`;
     }
 
     super(credentials, options);
 
+    this.apiVersion = '2020-04-01-preview';
     this.acceptLanguage = 'en-US';
     this.longRunningOperationRetryTimeout = 30;
     this.baseUri = options.baseUri || this.baseUri || "https://management.azure.com";
     this.requestContentType = "application/json; charset=utf-8";
     this.credentials = credentials;
     this.subscriptionId = subscriptionId;
 
-    if(options.acceptLanguage !== null && options.acceptLanguage !== undefined) {
+    if (options.acceptLanguage !== null && options.acceptLanguage !== undefined) {
       this.acceptLanguage = options.acceptLanguage;
     }
-    if(options.longRunningOperationRetryTimeout !== null && options.longRunningOperationRetryTimeout !== undefined) {
+    if (options.longRunningOperationRetryTimeout !== null && options.longRunningOperationRetryTimeout !== undefined) {
       this.longRunningOperationRetryTimeout = options.longRunningOperationRetryTimeout;
     }
   }