Update CODEOWNERS paths: fix invalid paths
#24621
Conversation
konrad-jamrozik
added
the
Central-EngSys
| /sdk/netapp/ci.mgmt.yml @qiaozha @dw511214992 @MaryGao | ||
|
|
||
| # PRLabel: %Mgmt | ||
| /sdk/network/arm-network @qiaozha @dw511214992 @MaryGao | ||
| /sdk/network/ci.mgmt.yml @qiaozha @dw511214992 @MaryGao | ||
| /sdk/network/arm-network/ @qiaozha @dw511214992 @MaryGao |
There was a problem hiding this comment.
Do we need an extra rule for /sdk/network/arm-network-rest/ ? Currently it matches against /sdk/.
There are few more directories with similar issue:
/sdk/appservice/arm-appservice-rest/
/sdk/compute/arm-compute-rest/
/sdk/containerservice/arm-containerservice-rest/
/sdk/mysql/arm-mysql-flexible/
/sdk/servicefabric/arm-servicefabric-rest/
There was a problem hiding this comment.
Those are like any other directory under sdk without owners they fallback to the leads until an owners is identified.
There was a problem hiding this comment.
Or if they were matching another path that we fixed by adding a "/" we could make those map to what they used to map to.
These actually look like they are arm packages so we might want to consider a wildcard to map the all to the arm/mgmt owners.
There was a problem hiding this comment.
@qiaozha @dw511214992 @MaryGao can you let me know if you want to be owners of following paths?
/sdk/network/arm-network-rest/
/sdk/appservice/arm-appservice-rest/
/sdk/compute/arm-compute-rest/
/sdk/containerservice/arm-containerservice-rest/
/sdk/mysql/arm-mysql-flexible/
/sdk/servicefabric/arm-servicefabric-rest/
Currently their owner is @xirzec, via the /sdk/ rule.
There was a problem hiding this comment.
sorry just see this comment, @konrad-jamrozik yes, you can put us as owner.
There was a problem hiding this comment.
konrad-jamrozik
changed the title
CODEOWNERS paths: fix invalid paths and deprioritize /eng/ and Engineering System Team pathsCODEOWNERS paths: fix invalid paths
konrad-jamrozik
force-pushed
the
users/kojamroz/co
branch
from
e21ba96
to
16fc90e
Compare
konrad-jamrozik
force-pushed
the
users/kojamroz/co
branch
from
16fc90e
to
93b7817
Compare
|
/check-enforcer override |
…-reports.yml` path For context, see: - #24621 (review)
…e-reports.yml` path (#24841) For context, see: - #24621 (review) Related PR: - Azure/azure-sdk-tools#5088
As part of ongoing work of enabling wildcard support for
CODEOWNERS:and enabling stricter validation:
this PR:
/**/tests.ymland/**/ci.yml, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supportingCODEOWNERSmatcher, per: Enable the new, regex-based, wildcard-supporting CODEOWNERS matcher azure-sdk-tools#5088 (comment)As a consequence of this PR the automatically assigned PR reviewers will change for some paths. The full list of of such changes can be determined by running relevant test provided by this PR:
CODEOWNERSmatcher on all remaining repositories in scope. azure-sdk-tools#5266You can also reach out to me to get that information.
Once this PR is merged, I will enable the new
CODEOWNERSmatcher, similar to how it was done fornetrepo by these two PRs:azure-sdk-for-netrepo azure-sdk-tools#5241NotificationConfigurationpackage from20230119.1to20230127.4azure-sdk-tools#5240Doing so will also change to whom build failure notification emails are sent.
Related PRs:
netrepo: Fix invalid paths in CODEOWNERS azure-sdk-for-net#33584pythonrepo: DeprioritizeCODEOWNERSEngSys ownership + fix one invalid path azure-sdk-for-python#28534