Add manual tools for reporting information required to enable regex-based wildcard-supporting CODEOWNERS matcher on all remaining repositories in scope.
#5266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konrad-jamrozik
added
the
Central-EngSys
konrad-jamrozik
force-pushed
the
users/kojamroz/diff_all_cos
branch
from
a0b526e
to
259ffe6
Compare
konrad-jamrozik
changed the title
CODEOWNERS matcher on all remaining repositories in scope.CODEOWNERS matcher on all remaining repositories in scope.
konrad-jamrozik
force-pushed
the
users/kojamroz/diff_all_cos
branch
from
4572f59
to
261f562
Compare
… overwriting output files for diffs for wildcard paths removal
konrad-jamrozik
force-pushed
the
users/kojamroz/diff_all_cos
branch
from
261f562
to
c9abfdb
Compare
|
So this is just a temporary update to enable tracking the state of various codeowners files? If so, I'm ok with this. |
@benbp I plan to keep this for future use, too. These tools allow us to have full insight into how any CODEOWNERS changes will affect the owners. The logic that compares old vs new matcher will go away, and the validation logic will be moved into: But nevertheless I want to keep what remains, in case we need to make some significant and/or batch changes to CODEOWNERS in the future. |
This was referenced Jan 30, 2023
Merged
konrad-jamrozik
force-pushed
the
users/kojamroz/diff_all_cos
branch
from
4d41df2
to
0d6d96b
Compare
…m manually-provided CODEOWNERS2
konrad-jamrozik
force-pushed
the
users/kojamroz/diff_all_cos
branch
from
0d6d96b
to
d115844
Compare
added 4 commits
January 30, 2023 21:54
…ntents into one set of tests
weshaggard
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR context
This PR is done in preparation to enable the new regex-based wildcard-supporting
CODEOWNERSmatcher for Azure SDK repositories that have configured routing of build failure notifications via ADO groups, as explained in:This PR is a continuation of work done by this PR:
CODEOWNERSpaths that are missing suffix slash; add support for diffing toCODEOWNERSversion with some paths removed; add tools for analyzing azure-sdk-for-pythonCODEOWNERS. #5245This PR provides information required to make a PR analogous to this one, but for the remaining repositories in scope:
This PR is a prerequisite to enabling the new matcher on all the remaining repositories in scope, in similar way as this PR does:
azure-sdk-for-netrepo #5241Thus, overall, this PR contributes to:
Changes made
/;