Skip to content

Commit

Permalink
Fix Managed HSM test deployment (#21979)
Browse files Browse the repository at this point in the history
Also gets rid of unnecessary, deprecated enableSoftDelete parameter.
  • Loading branch information
heaths authored Jun 18, 2021
1 parent a111864 commit 6ac2f79
Showing 1 changed file with 7 additions and 14 deletions.
21 changes: 7 additions & 14 deletions sdk/keyvault/test-resources.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,6 @@
"description": "Whether to enable deployment of Managed HSM. The default is false."
}
},
"enableSoftDelete": {
"type": "bool",
"defaultValue": true,
"metadata": {
"description": "Whether to enable soft delete for the Key Vault. The default is true."
}
},
"keyVaultSku": {
"type": "string",
"defaultValue": "premium",
Expand All @@ -78,7 +71,7 @@
"variables": {
"kvApiVersion": "2019-09-01",
"kvName": "[parameters('baseName')]",
"hsmApiVersion": "2020-04-01-preview",
"hsmApiVersion": "2021-04-01-preview",
"hsmName": "[concat(parameters('baseName'), 'hsm')]",
"mgmtApiVersion": "2019-04-01",
"blobContainerName": "backup",
Expand All @@ -93,10 +86,8 @@
},
"networkAcls": {
"bypass": "AzureServices",
"virtualNetworkRules": [
],
"ipRules": [
],
"virtualNetworkRules": [],
"ipRules": [],
"defaultAction": "Allow"
}
},
Expand Down Expand Up @@ -169,7 +160,7 @@
"enabledForDeployment": false,
"enabledForDiskEncryption": false,
"enabledForTemplateDeployment": false,
"enableSoftDelete": "[parameters('enableSoftDelete')]"
"enableSoftDelete": true
}
},
{
Expand All @@ -188,7 +179,9 @@
"[parameters('testApplicationOid')]"
],
"enablePurgeProtection": false,
"enableSoftDelete": "[parameters('enableSoftDelete')]"
"enableSoftDelete": true,
"publicNetworkAccess": "Enabled",
"networkAcls": "[variables('networkAcls')]"
}
},
{
Expand Down

0 comments on commit 6ac2f79

Please sign in to comment.