Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Managed HSM test deployment #21979

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Fix Managed HSM test deployment #21979

merged 1 commit into from
Jun 18, 2021

Conversation

heaths
Copy link
Member

@heaths heaths commented Jun 18, 2021

Also gets rid of unnecessary, deprecated enableSoftDelete parameter.

@heaths
Fix Managed HSM test deployment
5eb16b3 
Also gets rid of unnecessary, deprecated enableSoftDelete parameter.
@heaths heaths requested a review from schaabs as a code owner June 18, 2021 22:44
@heaths heaths requested review from mccoyp and vcolin7 June 18, 2021 22:44
@ghost ghost added the KeyVault label Jun 18, 2021
@heaths
Copy link
Member Author

heaths commented Jun 18, 2021

Using "bypass": "AzureServices" works fine here, which I already had handy for another service. I tried this out using the initial admin OID (my test creds) and was able to successfully enumerate and create keys against Managed HSM.

@heaths heaths merged commit 6ac2f79 into Azure:main Jun 18, 2021
@heaths heaths deleted the keyvault-testresources branch June 18, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mccoyp mccoyp mccoyp approved these changes

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner

@vcolin7 vcolin7 Awaiting requested review from vcolin7

Assignees
No one assigned
Labels
KeyVault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heaths @mccoyp