Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support selection marks #14816

Closed
7 tasks done
maririos opened this issue Sep 2, 2020 · 4 comments · Fixed by #15248
Closed
7 tasks done

Support selection marks #14816

maririos opened this issue Sep 2, 2020 · 4 comments · Fixed by #15248
Assignees
@maririos
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer
Milestone
[2020] October

Comments

@maririos
Copy link
Member

maririos commented Sep 2, 2020 •
edited
Loading

  • As type on FormField
  • As a list[SelectionMarks] on FormPage
  • As an element type on FieldData/FormTableCell - requires parsing the json pointer
  • tests
  • samples
  • documentation
  • mocking
@maririos maririos added Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer labels Sep 2, 2020
@maririos maririos added this to the [2020] October milestone Sep 2, 2020
@AlexGhiondea AlexGhiondea added the blocking-release Blocks release label Sep 2, 2020
@maririos
Copy link
Member Author

maririos commented Sep 9, 2020 •
edited
Loading

  • Available only for supervised only models.
  • Selected, unselected are the only values returned on SelectionMark.State. In the future undetermined could be there too. No more. It is ok to treat them as enum as service wants to add modelAsString=false in the swagger file
  • Looks like for 2.1-preview.2 the SelectionMarks will be included as an json pointer under elements (need to confirm)

@maririos maririos mentioned this issue Sep 11, 2020
Merged
@maririos maririos self-assigned this Sep 14, 2020
@maririos
Copy link
Member Author

Design:
https://apiview.dev/Assemblies/Review/cf2c57b3d4c44ef08c2e8284f7441a2d?diffRevisionId=714267e3f977493fa2690daf64c2df11

Sample: https://github.com/Azure/azure-sdk-for-net/blob/feature/formrecognizer2.1/sdk/formrecognizer/Azure.AI.FormRecognizer/samples/Sample1_RecognizeFormContent.md#recognize-form-content-from-a-uri

@maririos
Copy link
Member Author

Looks like for 2.1-preview.2 the SelectionMarks will be included as an json pointer under elements (need to confirm)

Service made an update and it is now included in 2.1-preview.1. format is i.e. #/readResults/0/selectionMarks/2

@maririos
Copy link
Member Author

Info for documentation -> https://docs.microsoft.com/en-us/azure/cognitive-services/form-recognizer/whats-new#new-features

@maririos maririos mentioned this issue Sep 17, 2020
Merged
@ghost ghost closed this as completed in #15248 Oct 5, 2020
ghost pushed a commit that referenced this issue Oct 5, 2020
@maririos
[FR] Selectionmarks (#15248)
5f8c32a 
Includes additions to: 
- As type in FormField
- As a list on FormPage
- As an element type on FieldData/FormTableCell - requires parsing the json pointer
- Mocking
- Tests
- Samples
- Documentation

Fixes: #14816

~~Making it draft until I get green light to share the files for training/test selection mark~~
Test are disabled until we can upload the file here. I created issue #15495 to track that
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this issue Feb 17, 2021
@maririos @annelo-msft
[FR] Selectionmarks (Azure#15248)
1b77777 
Includes additions to: 
- As type in FormField
- As a list on FormPage
- As an element type on FieldData/FormTableCell - requires parsing the json pointer
- Mocking
- Tests
- Samples
- Documentation

Fixes: Azure#14816

~~Making it draft until I get green light to share the files for training/test selection mark~~
Test are disabled until we can upload the file here. I created issue Azure#15495 to track that
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maririos maririos

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer
Projects
None yet
Milestone
[2020] October
Development

Successfully merging a pull request may close this issue.

[FR] Selectionmarks maririos/azure-sdk-for-net
2 participants
@AlexGhiondea @maririos