[FR] Selectionmarks #15248
Merged
[FR] Selectionmarks #15248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run net - formrecognizer - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
maririos
requested review from
kristapratico,
samvaity,
willmtemple and
kinelski
maririos
force-pushed
the
selectionmarks
branch
from
f016f6e to
e631b5a
Compare
samvaity
reviewed
Sep 18, 2020
kinelski
reviewed
Sep 21, 2020
sdk/formrecognizer/Azure.AI.FormRecognizer/src/RecognizeContentOperation.cs
Show resolved
Hide resolved
...cognizer/Azure.AI.FormRecognizer/tests/FormRecognizerClient/FormRecognizerClientLiveTests.cs
Show resolved
Hide resolved
...cognizer/Azure.AI.FormRecognizer/tests/FormRecognizerClient/FormRecognizerClientLiveTests.cs
Outdated
Show resolved
Hide resolved
...cognizer/Azure.AI.FormRecognizer/tests/FormRecognizerClient/FormRecognizerClientLiveTests.cs
Show resolved
Hide resolved
sdk/formrecognizer/Azure.AI.FormRecognizer/samples/Sample1_RecognizeFormContent.md
Outdated
Show resolved
Hide resolved
maririos
force-pushed
the
selectionmarks
branch
from
fe743db to
57e3d79
Compare
maririos
requested review from
annelo-msft,
KrzysztofCwalina and
tg-msft
as code owners
| @@ -101,7 +101,7 @@ var client = new FormRecognizerClient(new Uri(endpoint), new DefaultAzureCredent | |||
| `FormRecognizerClient` provides operations for: | |||
|
|
|||
| - Recognizing form fields and content, using custom models trained to recognize your custom forms. These values are returned in a collection of `RecognizedForm` objects. See example [Recognize Custom Forms](#recognize-custom-forms). | |||
| - Recognizing form content, including tables, lines and words, without the need to train a model. Form content is returned in a collection of `FormPage` objects. See example [Recognize Content](#recognize-content). | |||
| - Recognizing form content, including tables, lines, words, and selection marks like radio buttons and check boxes without the need to train a model. Form content is returned in a collection of `FormPage` objects. See example [Recognize Content](#recognize-content). | |||
There was a problem hiding this comment.
I wonder if we should say something about training custom models with labels to recognize selection marks as well
There was a problem hiding this comment.
I thought about it but looking at Recognizing form fields and content, using custom models trained to recognize your custom forms. makes me think that it already includes it. Although selectionmarks is a new concept, the idea of recognizing fields and content still applies.
sdk/formrecognizer/Azure.AI.FormRecognizer/src/FormSelectionMarkState.cs
Outdated
Show resolved
Hide resolved
kristapratico
approved these changes
Oct 5, 2020
samvaity
reviewed
Oct 5, 2020
| [Test] | ||
| [TestCase(true)] | ||
| [TestCase(false)] | ||
| [Ignore("Need to get an approved file to test")] |
There was a problem hiding this comment.
Are we following up on this?
Is this test still ignored?
There was a problem hiding this comment.
Yes. I keep pinging service team about it.
And yes, test is ignored
|
/azp run net - formrecognizer - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hello @maririos! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
Includes additions to: - As type in FormField - As a list on FormPage - As an element type on FieldData/FormTableCell - requires parsing the json pointer - Mocking - Tests - Samples - Documentation Fixes: Azure#14816 ~~Making it draft until I get green light to share the files for training/test selection mark~~ Test are disabled until we can upload the file here. I created issue Azure#15495 to track that
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes additions to:
Fixes: #14816
Making it draft until I get green light to share the files for training/test selection markTest are disabled until we can upload the file here. I created issue #15495 to track that