Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use KeyVaultIdentifier everywhere in Key Vault #24262

Closed
heaths opened this issue Sep 28, 2021 · 0 comments · Fixed by #25593
Closed

Use KeyVaultIdentifier everywhere in Key Vault #24262

heaths opened this issue Sep 28, 2021 · 0 comments · Fixed by #25593
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault

Comments

@heaths
Copy link
Member

heaths commented Sep 28, 2021

While working on another issue, I found duplicated logic that the KeyVaultIdentifier struct in .Shared already does. In Secrets, it's ObjectId. Keys has KeyProperties.ParseId, and Certificates has CertificateProperties.ParseId.

The exceptions are more specific to what is wrong, but all throw an ArgumentException already. They also assert the collection, but I think this might largely be irrelevant. At the very least, we should consolidate that logic into KeyVaultIdentifier much like the original struct was which did assert the collection like "secrets" or "keys".

@heaths heaths added KeyVault Client This issue points to a problem in the data-plane of the library. labels Sep 28, 2021
@heaths heaths added this to the [2021] November milestone Sep 28, 2021
@heaths heaths self-assigned this Sep 28, 2021
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Dec 1, 2021
heaths added a commit that referenced this issue Dec 2, 2021
* Use operation helpers

Partially fixes #22912

* Resolve PR feedback

* Add OperationInternal tests

* Use OperationInternal for all pseudo-LROs

Resolves #22912

* Use KeyVaultPipeline for SecretClient

Resolves #8115

* Deduplicate identifier parsing

Resolves #24262

* Resolve PR feedback
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant