You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working on another issue, I found duplicated logic that the KeyVaultIdentifier struct in .Shared already does. In Secrets, it's ObjectId. Keys has KeyProperties.ParseId, and Certificates has CertificateProperties.ParseId.
The exceptions are more specific to what is wrong, but all throw an ArgumentException already. They also assert the collection, but I think this might largely be irrelevant. At the very least, we should consolidate that logic into KeyVaultIdentifier much like the original struct was which did assert the collection like "secrets" or "keys".
The text was updated successfully, but these errors were encountered:
While working on another issue, I found duplicated logic that the KeyVaultIdentifier struct in .Shared already does. In Secrets, it's
ObjectId
. Keys hasKeyProperties.ParseId
, and Certificates hasCertificateProperties.ParseId
.The exceptions are more specific to what is wrong, but all throw an
ArgumentException
already. They also assert the collection, but I think this might largely be irrelevant. At the very least, we should consolidate that logic intoKeyVaultIdentifier
much like the original struct was which did assert the collection like "secrets" or "keys".The text was updated successfully, but these errors were encountered: