Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyVault clients should use KeyVaultPipeline consistently #8115

Closed
heaths opened this issue Oct 15, 2019 · 1 comment · Fixed by #25593
Closed

KeyVault clients should use KeyVaultPipeline consistently #8115

heaths opened this issue Oct 15, 2019 · 1 comment · Fixed by #25593
Assignees
@heaths
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2021] December

Comments

@heaths
Copy link
Member

heaths commented Oct 15, 2019

One specific example is that SecretClient constructs its own Uri for pageables and should use KeyVaultPipeline.CreateFirstPageUri like KeyClient.
@heaths heaths added KeyVault Client This issue points to a problem in the data-plane of the library. labels Oct 15, 2019
@heaths heaths self-assigned this Oct 15, 2019
@AlexGhiondea AlexGhiondea added this to the [2020] March milestone Mar 2, 2020
@heaths heaths removed this from the [2020] March milestone Mar 3, 2020
@heaths heaths added this to the Backlog milestone May 20, 2020
@heaths heaths modified the milestones: Backlog, [2021] August Jun 9, 2021
@heaths
Copy link
Member Author

heaths commented Sep 22, 2021

Pushing to November since this has no impact on the public APIs.

heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Dec 1, 2021
@heaths
Use KeyVaultPipeline for SecretClient
5a0f002 
Resolves Azure#8115
@heaths heaths mentioned this issue Dec 1, 2021
Merged
heaths added a commit that referenced this issue Dec 2, 2021
@heaths
Resolve several Key Vault backlog issues (#25593)
71054d5 
* Use operation helpers

Partially fixes #22912

* Resolve PR feedback

* Add OperationInternal tests

* Use OperationInternal for all pseudo-LROs

Resolves #22912

* Use KeyVaultPipeline for SecretClient

Resolves #8115

* Deduplicate identifier parsing

Resolves #24262

* Resolve PR feedback
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@heaths heaths

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2021] December
Development

Successfully merging a pull request may close this issue.

Resolve several Key Vault backlog issues heaths/azure-sdk-for-net
2 participants
@heaths @AlexGhiondea