Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in ClientCertificateCredentialOptions #15901

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Fix typo in ClientCertificateCredentialOptions #15901

merged 2 commits into from
Oct 19, 2020

Conversation

noamher
Copy link
Contributor

@noamher noamher commented Oct 13, 2020

No description provided.

@ghost ghost added Azure.Identity customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Oct 13, 2020
@ghost
Copy link

ghost commented Oct 13, 2020

Thank you for your contribution noamher! We will review the pull request and get back to you soon.

@ghost
Copy link

ghost commented Oct 13, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@jsquire jsquire added breaking-change Client This issue points to a problem in the data-plane of the library. Community Contribution Community members are working on the issue and removed customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Oct 13, 2020
@jsquire
Copy link
Member

jsquire commented Oct 13, 2020

Hi @noamher. Thank you your contribution and interest in helping to improve the Azure SDK experience. I've tagged and routed to the team member best able to provide feedback.

@noamher
Copy link
Contributor Author

noamher commented Oct 18, 2020

@schaabs any comments or things I should change?

schaabs
schaabs approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@schaabs schaabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noamher Great catch, thanks for the contribution!

@schaabs schaabs merged commit f5f0e76 into Azure:master Oct 19, 2020
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
@noamher @nohersht @annelo-msft
Fix typo in ClientCertificateCredentialOptions (Azure#15901)
9211d77 
* Fix typo in ClientCertificateCredentialOptions

* Update api of Azure.Identity

Co-authored-by: Noam Hershtig <nohersht@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schaabs schaabs schaabs approved these changes

@AlexanderSher AlexanderSher Awaiting requested review from AlexanderSher

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina

@tg-msft tg-msft Awaiting requested review from tg-msft

Assignees

@schaabs schaabs

Labels
Azure.Identity breaking-change Client This issue points to a problem in the data-plane of the library. Community Contribution Community members are working on the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noamher @jsquire @schaabs @nohersht